From: Michal Kubiak <michal.kubiak@intel.com>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <rkannoth@marvell.com>,
<shenjian15@huawei.com>, <wangjie125@huawei.com>,
<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED
Date: Mon, 18 Mar 2024 15:16:15 +0100 [thread overview]
Message-ID: <ZfhMr6t0pQG+Dp63@localhost.localdomain> (raw)
In-Reply-To: <20240318132948.3624333-4-shaojijie@huawei.com>
On Mon, Mar 18, 2024 at 09:29:48PM +0800, Jijie Shao wrote:
> From: Jian Shen <shenjian15@huawei.com>
>
> Currently, loopback test may be skipped when resetting, but the test
> result will still show as 'PASS', because the driver doesn't set
> ETH_TEST_FL_FAILED flag. Fix it by setting the flag and
> initializating the value to UNEXECUTED.
>
> Fixes: 4c8dab1c709c ("net: hns3: reconstruct function hns3_self_test")
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
> .../ethernet/hisilicon/hns3/hns3_ethtool.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 999a0ee162a6..941cb529d671 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -78,6 +78,9 @@ static const struct hns3_stats hns3_rxq_stats[] = {
> #define HNS3_NIC_LB_TEST_NO_MEM_ERR 1
> #define HNS3_NIC_LB_TEST_TX_CNT_ERR 2
> #define HNS3_NIC_LB_TEST_RX_CNT_ERR 3
> +#define HNS3_NIC_LB_TEST_UNEXECUTED 4
> +
> +static int hns3_get_sset_count(struct net_device *netdev, int stringset);
>
> static int hns3_lp_setup(struct net_device *ndev, enum hnae3_loop loop, bool en)
> {
> @@ -418,18 +421,26 @@ static void hns3_do_external_lb(struct net_device *ndev,
> static void hns3_self_test(struct net_device *ndev,
> struct ethtool_test *eth_test, u64 *data)
> {
> + int cnt = hns3_get_sset_count(ndev, ETH_SS_TEST);
> struct hns3_nic_priv *priv = netdev_priv(ndev);
> struct hnae3_handle *h = priv->ae_handle;
> int st_param[HNAE3_LOOP_NONE][2];
> bool if_running = netif_running(ndev);
> + int i;
> +
> + /* initialize the loopback test result, avoid marking an unexcuted
> + * loopback test as PASS.
> + */
> + for (i = 0; i < cnt; i++)
> + data[i] = HNS3_NIC_LB_TEST_UNEXECUTED;
>
> if (hns3_nic_resetting(ndev)) {
> netdev_err(ndev, "dev resetting!");
> - return;
> + goto failure;
> }
>
> if (!(eth_test->flags & ETH_TEST_FL_OFFLINE))
> - return;
> + goto failure;
>
> if (netif_msg_ifdown(h))
> netdev_info(ndev, "self test start\n");
> @@ -451,6 +462,10 @@ static void hns3_self_test(struct net_device *ndev,
>
> if (netif_msg_ifdown(h))
> netdev_info(ndev, "self test end\n");
> + return;
> +
> +failure:
> + eth_test->flags |= ETH_TEST_FL_FAILED;
> }
>
> static void hns3_update_limit_promisc_mode(struct net_device *netdev,
> --
> 2.30.0
>
Thanks!
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
prev parent reply other threads:[~2024-03-18 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 13:29 [PATCH V3 net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-18 14:26 ` Michal Kubiak
2024-03-18 14:36 ` Kalesh Anakkur Purayil
2024-03-25 12:55 ` Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-18 14:25 ` Michal Kubiak
2024-03-19 11:17 ` Jiri Pirko
2024-03-25 12:51 ` Jijie Shao
2024-03-18 13:29 ` [PATCH V3 net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-18 14:16 ` Michal Kubiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfhMr6t0pQG+Dp63@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).