From: "Fuzzey, Martin" <martin.fuzzey@flowbird.group>
To: Andy Duan <fugang.duan@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH net 2/4] dt-bindings: fec: update the gpr property
Date: Sat, 23 May 2020 12:15:59 +0200 [thread overview]
Message-ID: <CANh8QzxfVtk+3N=5UttjXK6CR9ZQ=qD-Twu7y-zKabLJZGQ2yQ@mail.gmail.com> (raw)
In-Reply-To: <1589963516-26703-3-git-send-email-fugang.duan@nxp.com>
> - gpr: phandle of SoC general purpose register mode. Required for wake on LAN
> - on some SoCs
> + on some SoCs. Register bits of stop mode control, the format is
> + <&gpr req_gpr req_bit>.
> + gpr is the phandle to general purpose register node.
> + req_gpr is the gpr register offset for ENET stop request.
> + req_bit is the gpr bit offset for ENET stop request.
>
More of a DT binding changes policy question, do we care about
supporting the old
no argument binding too?
I don't think it actually matters seeing as the no argument gpr node
binding was only added recently anyway.
But it was backported to the stable trees and
Documentation/bindings/ABI.txt says
"Bindings can be augmented, but the driver shouldn't break when given
the old binding. ie. add additional properties, but don't change the
meaning of an existing property. For drivers, default to the original
behaviour when a newly added property is missing."
Myself I think this is overkill in this case and am fine with just
changing the binding without the driver handling the old case but
that's Rob's call to make I think.
Martin
next prev parent reply other threads:[~2020-05-23 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:31 [PATCH net 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT fugang.duan
2020-05-20 8:31 ` [PATCH net 1/4] net: ethernet: fec: move GPR register " fugang.duan
2020-05-20 16:54 ` Jakub Kicinski
2020-05-21 2:40 ` [EXT] " Andy Duan
2020-05-23 9:55 ` Fuzzey, Martin
2020-05-25 2:36 ` [EXT] " Andy Duan
2020-05-20 8:31 ` [PATCH net 2/4] dt-bindings: fec: update the gpr property fugang.duan
2020-05-23 10:15 ` Fuzzey, Martin [this message]
2020-05-25 3:16 ` [EXT] " Andy Duan
2020-05-20 8:31 ` [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format fugang.duan
2020-05-20 17:03 ` Andrew Lunn
2020-05-21 3:15 ` [EXT] " Andy Duan
2020-05-21 13:07 ` Andrew Lunn
2020-05-22 1:01 ` Andy Duan
2020-05-22 18:02 ` Fuzzey, Martin
2020-05-22 23:50 ` Andrew Lunn
2020-05-25 2:32 ` Andy Duan
2020-05-25 2:29 ` Andy Duan
2020-05-20 8:31 ` [PATCH net 4/4] ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANh8QzxfVtk+3N=5UttjXK6CR9ZQ=qD-Twu7y-zKabLJZGQ2yQ@mail.gmail.com' \
--to=martin.fuzzey@flowbird.group \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).