* crash since commit "net/flow_dissector: switch to siphash"
@ 2019-11-13 11:52 Koen Vandeputte
2019-11-13 14:50 ` Eric Dumazet
0 siblings, 1 reply; 6+ messages in thread
From: Koen Vandeputte @ 2019-11-13 11:52 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, Greg KH
Hi Eric,
I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
below on my testing boards.
They all reboot continuously nearly immediately when linked.
It feels like it's tied to a commit of yours [1]
Any idea?
If you need more info, please let me know.
Thanks,
Koen
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
[ 48.269789] wlan0: Trigger new scan to find an IBSS to join
[ 48.680754] wlan0: Trigger new scan to find an IBSS to join
[ 49.041907] wlan0: Trigger new scan to find an IBSS to join
[ 49.079668] wlan0: Trigger new scan to find an IBSS to join
[ 49.149738] wlan0: Selected IBSS BSSID 16:5b:94:39:cb:5f based on
configured SSID
[ 49.199633] Unhandled kernel unaligned access[#1]:
[ 49.204505] CPU: 0 PID: 1634 Comm: wpa_supplicant Tainted: G
W 4.14.153 #0
[ 49.212619] task: 87d14580 task.stack: 860c6000
[ 49.217209] $ 0 : 00000000 77ea0b33 00000000 ceb5840c
[ 49.222515] $ 4 : 860c7a78 00000014 67aae3bf 00000000
[ 49.227821] $ 8 : 00000000 8040c9b0 87d1e460 0000d000
[ 49.233128] $12 : 74650000 00000000 00000001 00000002
[ 49.238435] $16 : 0000fffe 804f0000 67aae3bf 8766e5a4
[ 49.243741] $20 : 00000000 804f0000 804f3978 87d1e054
[ 49.249048] $24 : 00000002 00000003
[ 49.254353] $28 : 860c6000 860c7a30 00000000 8032cff8
[ 49.259661] Hi : 00000050
[ 49.262573] Lo : 00000002
[ 49.265500] epc : 804061a4 __siphash_aligned+0x24/0x730
[ 49.270985] ra : 8032cff8 skb_get_hash_perturb+0x160/0x1a8
[ 49.276803] Status: 1100dc03 KERNEL EXL IE
[ 49.281045] Cause : 00800010 (ExcCode 04)
[ 49.285110] BadVA : 67aae3c7
[ 49.288024] PrId : 00019750 (MIPS 74Kc)
[ 49.291990] Modules linked in: mbt ath9k ath9k_common qcserial pppoe
ppp_async option cdc_mbim ath9k_hw ath10k_pci ath10k_core ath usb_wwan
sierra_net sierra rndis_host qmi_wwan pppox ppp_generic mac80211
iptable_nat iptable_mangle iptable_filter ipt_REJECT ipt_MASQUERADE
ip_tables huawei_cdc_ncm ftdi_sio cfg80211 cdc_subset cdc_ncm cdc_ether
xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_lim2
[ 49.363914] cls_tcindex cls_route cls_matchall cls_fw cls_flow
cls_basic act_skbedit act_mirred i2c_dev ledtrig_usbport cryptodev msdos
bonding ip_gre gre dummy udp_tunnel ip_tunnel tun vfat fat nls_utf8
nls_iso8859_1 nls_cp437 authenc ehci_platform sd_mod scsi_mod ehci_hcd
gpio_button_hotplug ext4 mbcache jbd2 usbcore nls_base usb_common ptp
pps_core mii aead crypto_null cryptomgr crc32c_generic crypto_hash
[ 49.400738] Process wpa_supplicant (pid: 1634, threadinfo=860c6000,
task=87d14580, tls=77f6defc)
[ 49.409638] Stack : 67aae3bf 0000fffe 804f0000 67aae3bf 8766e5a4
00000000 804f0000 804f3978
[ 49.418121] 00000056 80580000 879b84c8 879cb088 00000000
00000000 00000085 00000004
[ 49.426604] 00220000 00000000 888e0000 00000000 00000000
00000000 00000000 00000000
[ 49.435087] 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000
[ 49.443570] 860c7b68 ceb5840c 86cb0bc0 860c2300 8766e508
86d2b604 879cb088 8793a750
[ 49.452053] ...
[ 49.454537] Call Trace:
[ 49.457014] [<804061a4>] __siphash_aligned+0x24/0x730
[ 49.462146] [<8032cff8>] skb_get_hash_perturb+0x160/0x1a8
[ 49.467737] [<86d2b604>] ieee80211_reserve_tid+0x26c/0xeb8 [mac80211]
[ 49.474300] Code: afb2000c afb10008 afb00004 <8cd40008> 8cc90000
3c136c79 3c02646f 3c07736f 24427261
[ 49.484200]
[ 49.485774] ---[ end trace ec8947d373843bf7 ]---
[ 49.492228] Kernel panic - not syncing: Fatal exception in interrupt
[ 49.499642] Rebooting in 3 seconds..
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: crash since commit "net/flow_dissector: switch to siphash"
2019-11-13 11:52 crash since commit "net/flow_dissector: switch to siphash" Koen Vandeputte
@ 2019-11-13 14:50 ` Eric Dumazet
2019-11-15 11:30 ` Koen Vandeputte
0 siblings, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2019-11-13 14:50 UTC (permalink / raw)
To: Koen Vandeputte; +Cc: netdev, Greg KH
On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
<koen.vandeputte@ncentric.com> wrote:
>
> Hi Eric,
>
> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
> below on my testing boards.
> They all reboot continuously nearly immediately when linked.
>
> It feels like it's tied to a commit of yours [1]
Have you tried current upstream kernels ?
Is is a backport issue, or a bug in original commit ?
Can you give us gcc version ?
Can you check what SIPHASH_ALIGNMENT value is at compile time ?
>
> Any idea?
>
> If you need more info, please let me know.
>
> Thanks,
>
> Koen
>
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
>
>
> [ 48.269789] wlan0: Trigger new scan to find an IBSS to join
> [ 48.680754] wlan0: Trigger new scan to find an IBSS to join
> [ 49.041907] wlan0: Trigger new scan to find an IBSS to join
> [ 49.079668] wlan0: Trigger new scan to find an IBSS to join
> [ 49.149738] wlan0: Selected IBSS BSSID 16:5b:94:39:cb:5f based on
> configured SSID
> [ 49.199633] Unhandled kernel unaligned access[#1]:
> [ 49.204505] CPU: 0 PID: 1634 Comm: wpa_supplicant Tainted: G
> W 4.14.153 #0
> [ 49.212619] task: 87d14580 task.stack: 860c6000
> [ 49.217209] $ 0 : 00000000 77ea0b33 00000000 ceb5840c
> [ 49.222515] $ 4 : 860c7a78 00000014 67aae3bf 00000000
> [ 49.227821] $ 8 : 00000000 8040c9b0 87d1e460 0000d000
> [ 49.233128] $12 : 74650000 00000000 00000001 00000002
> [ 49.238435] $16 : 0000fffe 804f0000 67aae3bf 8766e5a4
> [ 49.243741] $20 : 00000000 804f0000 804f3978 87d1e054
> [ 49.249048] $24 : 00000002 00000003
> [ 49.254353] $28 : 860c6000 860c7a30 00000000 8032cff8
> [ 49.259661] Hi : 00000050
> [ 49.262573] Lo : 00000002
> [ 49.265500] epc : 804061a4 __siphash_aligned+0x24/0x730
> [ 49.270985] ra : 8032cff8 skb_get_hash_perturb+0x160/0x1a8
> [ 49.276803] Status: 1100dc03 KERNEL EXL IE
> [ 49.281045] Cause : 00800010 (ExcCode 04)
> [ 49.285110] BadVA : 67aae3c7
> [ 49.288024] PrId : 00019750 (MIPS 74Kc)
> [ 49.291990] Modules linked in: mbt ath9k ath9k_common qcserial pppoe
> ppp_async option cdc_mbim ath9k_hw ath10k_pci ath10k_core ath usb_wwan
> sierra_net sierra rndis_host qmi_wwan pppox ppp_generic mac80211
> iptable_nat iptable_mangle iptable_filter ipt_REJECT ipt_MASQUERADE
> ip_tables huawei_cdc_ncm ftdi_sio cfg80211 cdc_subset cdc_ncm cdc_ether
> xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_lim2
> [ 49.363914] cls_tcindex cls_route cls_matchall cls_fw cls_flow
> cls_basic act_skbedit act_mirred i2c_dev ledtrig_usbport cryptodev msdos
> bonding ip_gre gre dummy udp_tunnel ip_tunnel tun vfat fat nls_utf8
> nls_iso8859_1 nls_cp437 authenc ehci_platform sd_mod scsi_mod ehci_hcd
> gpio_button_hotplug ext4 mbcache jbd2 usbcore nls_base usb_common ptp
> pps_core mii aead crypto_null cryptomgr crc32c_generic crypto_hash
> [ 49.400738] Process wpa_supplicant (pid: 1634, threadinfo=860c6000,
> task=87d14580, tls=77f6defc)
> [ 49.409638] Stack : 67aae3bf 0000fffe 804f0000 67aae3bf 8766e5a4
> 00000000 804f0000 804f3978
> [ 49.418121] 00000056 80580000 879b84c8 879cb088 00000000
> 00000000 00000085 00000004
> [ 49.426604] 00220000 00000000 888e0000 00000000 00000000
> 00000000 00000000 00000000
> [ 49.435087] 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000
> [ 49.443570] 860c7b68 ceb5840c 86cb0bc0 860c2300 8766e508
> 86d2b604 879cb088 8793a750
> [ 49.452053] ...
> [ 49.454537] Call Trace:
> [ 49.457014] [<804061a4>] __siphash_aligned+0x24/0x730
> [ 49.462146] [<8032cff8>] skb_get_hash_perturb+0x160/0x1a8
> [ 49.467737] [<86d2b604>] ieee80211_reserve_tid+0x26c/0xeb8 [mac80211]
> [ 49.474300] Code: afb2000c afb10008 afb00004 <8cd40008> 8cc90000
> 3c136c79 3c02646f 3c07736f 24427261
> [ 49.484200]
> [ 49.485774] ---[ end trace ec8947d373843bf7 ]---
> [ 49.492228] Kernel panic - not syncing: Fatal exception in interrupt
> [ 49.499642] Rebooting in 3 seconds..
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: crash since commit "net/flow_dissector: switch to siphash"
2019-11-13 14:50 ` Eric Dumazet
@ 2019-11-15 11:30 ` Koen Vandeputte
2019-11-15 17:09 ` Eric Dumazet
0 siblings, 1 reply; 6+ messages in thread
From: Koen Vandeputte @ 2019-11-15 11:30 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, Greg KH
On 13.11.19 15:50, Eric Dumazet wrote:
> On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
> <koen.vandeputte@ncentric.com> wrote:
>> Hi Eric,
>>
>> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
>> below on my testing boards.
>> They all reboot continuously nearly immediately when linked.
>>
>> It feels like it's tied to a commit of yours [1]
> Have you tried current upstream kernels ?
No.
This board is only supported on OpenWrt currently using 4.14 and it's
not natively supported by upstream.
>
> Is is a backport issue, or a bug in original commit ?
No idea .. and I'm not profound enough on that part of the code to judge
this,
which is why I'm consulting your expert opinion.
>
> Can you give us gcc version ?
7.4.0
>
> Can you check what SIPHASH_ALIGNMENT value is at compile time ?
8 (exposed it in dmesg on boot)
Hw used:
system type : Qualcomm Atheros QCA9558 ver 1 rev 0
machine : MikroTik RouterBOARD 922UAGS-5HPacD
processor : 0
cpu model : MIPS 74Kc V5.0
>
>
>> Any idea?
>>
>> If you need more info, please let me know.
>>
>> Thanks,
>>
>> Koen
>>
>>
>> [1]:
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
>>
>>
>> [ 48.269789] wlan0: Trigger new scan to find an IBSS to join
>> [ 48.680754] wlan0: Trigger new scan to find an IBSS to join
>> [ 49.041907] wlan0: Trigger new scan to find an IBSS to join
>> [ 49.079668] wlan0: Trigger new scan to find an IBSS to join
>> [ 49.149738] wlan0: Selected IBSS BSSID 16:5b:94:39:cb:5f based on
>> configured SSID
>> [ 49.199633] Unhandled kernel unaligned access[#1]:
>> [ 49.204505] CPU: 0 PID: 1634 Comm: wpa_supplicant Tainted: G
>> W 4.14.153 #0
>> [ 49.212619] task: 87d14580 task.stack: 860c6000
>> [ 49.217209] $ 0 : 00000000 77ea0b33 00000000 ceb5840c
>> [ 49.222515] $ 4 : 860c7a78 00000014 67aae3bf 00000000
>> [ 49.227821] $ 8 : 00000000 8040c9b0 87d1e460 0000d000
>> [ 49.233128] $12 : 74650000 00000000 00000001 00000002
>> [ 49.238435] $16 : 0000fffe 804f0000 67aae3bf 8766e5a4
>> [ 49.243741] $20 : 00000000 804f0000 804f3978 87d1e054
>> [ 49.249048] $24 : 00000002 00000003
>> [ 49.254353] $28 : 860c6000 860c7a30 00000000 8032cff8
>> [ 49.259661] Hi : 00000050
>> [ 49.262573] Lo : 00000002
>> [ 49.265500] epc : 804061a4 __siphash_aligned+0x24/0x730
>> [ 49.270985] ra : 8032cff8 skb_get_hash_perturb+0x160/0x1a8
>> [ 49.276803] Status: 1100dc03 KERNEL EXL IE
>> [ 49.281045] Cause : 00800010 (ExcCode 04)
>> [ 49.285110] BadVA : 67aae3c7
>> [ 49.288024] PrId : 00019750 (MIPS 74Kc)
>> [ 49.291990] Modules linked in: mbt ath9k ath9k_common qcserial pppoe
>> ppp_async option cdc_mbim ath9k_hw ath10k_pci ath10k_core ath usb_wwan
>> sierra_net sierra rndis_host qmi_wwan pppox ppp_generic mac80211
>> iptable_nat iptable_mangle iptable_filter ipt_REJECT ipt_MASQUERADE
>> ip_tables huawei_cdc_ncm ftdi_sio cfg80211 cdc_subset cdc_ncm cdc_ether
>> xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_lim2
>> [ 49.363914] cls_tcindex cls_route cls_matchall cls_fw cls_flow
>> cls_basic act_skbedit act_mirred i2c_dev ledtrig_usbport cryptodev msdos
>> bonding ip_gre gre dummy udp_tunnel ip_tunnel tun vfat fat nls_utf8
>> nls_iso8859_1 nls_cp437 authenc ehci_platform sd_mod scsi_mod ehci_hcd
>> gpio_button_hotplug ext4 mbcache jbd2 usbcore nls_base usb_common ptp
>> pps_core mii aead crypto_null cryptomgr crc32c_generic crypto_hash
>> [ 49.400738] Process wpa_supplicant (pid: 1634, threadinfo=860c6000,
>> task=87d14580, tls=77f6defc)
>> [ 49.409638] Stack : 67aae3bf 0000fffe 804f0000 67aae3bf 8766e5a4
>> 00000000 804f0000 804f3978
>> [ 49.418121] 00000056 80580000 879b84c8 879cb088 00000000
>> 00000000 00000085 00000004
>> [ 49.426604] 00220000 00000000 888e0000 00000000 00000000
>> 00000000 00000000 00000000
>> [ 49.435087] 00000000 00000000 00000000 00000000 00000000
>> 00000000 00000000 00000000
>> [ 49.443570] 860c7b68 ceb5840c 86cb0bc0 860c2300 8766e508
>> 86d2b604 879cb088 8793a750
>> [ 49.452053] ...
>> [ 49.454537] Call Trace:
>> [ 49.457014] [<804061a4>] __siphash_aligned+0x24/0x730
>> [ 49.462146] [<8032cff8>] skb_get_hash_perturb+0x160/0x1a8
>> [ 49.467737] [<86d2b604>] ieee80211_reserve_tid+0x26c/0xeb8 [mac80211]
>> [ 49.474300] Code: afb2000c afb10008 afb00004 <8cd40008> 8cc90000
>> 3c136c79 3c02646f 3c07736f 24427261
>> [ 49.484200]
>> [ 49.485774] ---[ end trace ec8947d373843bf7 ]---
>> [ 49.492228] Kernel panic - not syncing: Fatal exception in interrupt
>> [ 49.499642] Rebooting in 3 seconds..
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: crash since commit "net/flow_dissector: switch to siphash"
2019-11-15 11:30 ` Koen Vandeputte
@ 2019-11-15 17:09 ` Eric Dumazet
2019-11-18 0:11 ` Hauke Mehrtens
0 siblings, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2019-11-15 17:09 UTC (permalink / raw)
To: Koen Vandeputte; +Cc: netdev, Greg KH
On Fri, Nov 15, 2019 at 3:30 AM Koen Vandeputte
<koen.vandeputte@ncentric.com> wrote:
>
>
> On 13.11.19 15:50, Eric Dumazet wrote:
> > On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
> > <koen.vandeputte@ncentric.com> wrote:
> >> Hi Eric,
> >>
> >> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
> >> below on my testing boards.
> >> They all reboot continuously nearly immediately when linked.
> >>
> >> It feels like it's tied to a commit of yours [1]
> > Have you tried current upstream kernels ?
>
> No.
>
> This board is only supported on OpenWrt currently using 4.14 and it's
> not natively supported by upstream.
>
> >
> > Is is a backport issue, or a bug in original commit ?
>
> No idea .. and I'm not profound enough on that part of the code to judge
> this,
>
> which is why I'm consulting your expert opinion.
>
> >
> > Can you give us gcc version ?
> 7.4.0
> >
> > Can you check what SIPHASH_ALIGNMENT value is at compile time ?
> 8 (exposed it in dmesg on boot)
Please ask OpenWrt specialists for support.
The code is probably mishandled by the compiler.
siphash() is supposed to handle misaligned data just fine, and
net/core/flow_dissector.c tries hard to align the keys anyway.
>
>
> Hw used:
>
> system type : Qualcomm Atheros QCA9558 ver 1 rev 0
> machine : MikroTik RouterBOARD 922UAGS-5HPacD
> processor : 0
> cpu model : MIPS 74Kc V5.0
>
> >
> >
> >> Any idea?
> >>
> >> If you need more info, please let me know.
> >>
> >> Thanks,
> >>
> >> Koen
> >>
> >>
> >> [1]:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
> >>
> >>
> >> [ 48.269789] wlan0: Trigger new scan to find an IBSS to join
> >> [ 48.680754] wlan0: Trigger new scan to find an IBSS to join
> >> [ 49.041907] wlan0: Trigger new scan to find an IBSS to join
> >> [ 49.079668] wlan0: Trigger new scan to find an IBSS to join
> >> [ 49.149738] wlan0: Selected IBSS BSSID 16:5b:94:39:cb:5f based on
> >> configured SSID
> >> [ 49.199633] Unhandled kernel unaligned access[#1]:
> >> [ 49.204505] CPU: 0 PID: 1634 Comm: wpa_supplicant Tainted: G
> >> W 4.14.153 #0
> >> [ 49.212619] task: 87d14580 task.stack: 860c6000
> >> [ 49.217209] $ 0 : 00000000 77ea0b33 00000000 ceb5840c
> >> [ 49.222515] $ 4 : 860c7a78 00000014 67aae3bf 00000000
> >> [ 49.227821] $ 8 : 00000000 8040c9b0 87d1e460 0000d000
> >> [ 49.233128] $12 : 74650000 00000000 00000001 00000002
> >> [ 49.238435] $16 : 0000fffe 804f0000 67aae3bf 8766e5a4
> >> [ 49.243741] $20 : 00000000 804f0000 804f3978 87d1e054
> >> [ 49.249048] $24 : 00000002 00000003
> >> [ 49.254353] $28 : 860c6000 860c7a30 00000000 8032cff8
> >> [ 49.259661] Hi : 00000050
> >> [ 49.262573] Lo : 00000002
> >> [ 49.265500] epc : 804061a4 __siphash_aligned+0x24/0x730
> >> [ 49.270985] ra : 8032cff8 skb_get_hash_perturb+0x160/0x1a8
> >> [ 49.276803] Status: 1100dc03 KERNEL EXL IE
> >> [ 49.281045] Cause : 00800010 (ExcCode 04)
> >> [ 49.285110] BadVA : 67aae3c7
> >> [ 49.288024] PrId : 00019750 (MIPS 74Kc)
> >> [ 49.291990] Modules linked in: mbt ath9k ath9k_common qcserial pppoe
> >> ppp_async option cdc_mbim ath9k_hw ath10k_pci ath10k_core ath usb_wwan
> >> sierra_net sierra rndis_host qmi_wwan pppox ppp_generic mac80211
> >> iptable_nat iptable_mangle iptable_filter ipt_REJECT ipt_MASQUERADE
> >> ip_tables huawei_cdc_ncm ftdi_sio cfg80211 cdc_subset cdc_ncm cdc_ether
> >> xt_time xt_tcpudp xt_state xt_nat xt_multiport xt_mark xt_mac xt_lim2
> >> [ 49.363914] cls_tcindex cls_route cls_matchall cls_fw cls_flow
> >> cls_basic act_skbedit act_mirred i2c_dev ledtrig_usbport cryptodev msdos
> >> bonding ip_gre gre dummy udp_tunnel ip_tunnel tun vfat fat nls_utf8
> >> nls_iso8859_1 nls_cp437 authenc ehci_platform sd_mod scsi_mod ehci_hcd
> >> gpio_button_hotplug ext4 mbcache jbd2 usbcore nls_base usb_common ptp
> >> pps_core mii aead crypto_null cryptomgr crc32c_generic crypto_hash
> >> [ 49.400738] Process wpa_supplicant (pid: 1634, threadinfo=860c6000,
> >> task=87d14580, tls=77f6defc)
> >> [ 49.409638] Stack : 67aae3bf 0000fffe 804f0000 67aae3bf 8766e5a4
> >> 00000000 804f0000 804f3978
> >> [ 49.418121] 00000056 80580000 879b84c8 879cb088 00000000
> >> 00000000 00000085 00000004
> >> [ 49.426604] 00220000 00000000 888e0000 00000000 00000000
> >> 00000000 00000000 00000000
> >> [ 49.435087] 00000000 00000000 00000000 00000000 00000000
> >> 00000000 00000000 00000000
> >> [ 49.443570] 860c7b68 ceb5840c 86cb0bc0 860c2300 8766e508
> >> 86d2b604 879cb088 8793a750
> >> [ 49.452053] ...
> >> [ 49.454537] Call Trace:
> >> [ 49.457014] [<804061a4>] __siphash_aligned+0x24/0x730
> >> [ 49.462146] [<8032cff8>] skb_get_hash_perturb+0x160/0x1a8
> >> [ 49.467737] [<86d2b604>] ieee80211_reserve_tid+0x26c/0xeb8 [mac80211]
> >> [ 49.474300] Code: afb2000c afb10008 afb00004 <8cd40008> 8cc90000
> >> 3c136c79 3c02646f 3c07736f 24427261
> >> [ 49.484200]
> >> [ 49.485774] ---[ end trace ec8947d373843bf7 ]---
> >> [ 49.492228] Kernel panic - not syncing: Fatal exception in interrupt
> >> [ 49.499642] Rebooting in 3 seconds..
> >>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: crash since commit "net/flow_dissector: switch to siphash"
2019-11-15 17:09 ` Eric Dumazet
@ 2019-11-18 0:11 ` Hauke Mehrtens
2019-11-18 14:12 ` Koen Vandeputte
0 siblings, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2019-11-18 0:11 UTC (permalink / raw)
To: Eric Dumazet, Koen Vandeputte; +Cc: netdev, Greg KH
On 11/15/19 6:09 PM, Eric Dumazet wrote:
> On Fri, Nov 15, 2019 at 3:30 AM Koen Vandeputte
> <koen.vandeputte@ncentric.com> wrote:
>>
>>
>> On 13.11.19 15:50, Eric Dumazet wrote:
>>> On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
>>> <koen.vandeputte@ncentric.com> wrote:
>>>> Hi Eric,
>>>>
>>>> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
>>>> below on my testing boards.
>>>> They all reboot continuously nearly immediately when linked.
>>>>
>>>> It feels like it's tied to a commit of yours [1]
>>> Have you tried current upstream kernels ?
>>
>> No.
>>
>> This board is only supported on OpenWrt currently using 4.14 and it's
>> not natively supported by upstream.
>>
>>>
>>> Is is a backport issue, or a bug in original commit ?
>>
>> No idea .. and I'm not profound enough on that part of the code to judge
>> this,
>>
>> which is why I'm consulting your expert opinion.
>>
>>>
>>> Can you give us gcc version ?
>> 7.4.0
>>>
>>> Can you check what SIPHASH_ALIGNMENT value is at compile time ?
>> 8 (exposed it in dmesg on boot)
>
> Please ask OpenWrt specialists for support.
>
> The code is probably mishandled by the compiler.
>
> siphash() is supposed to handle misaligned data just fine, and
> net/core/flow_dissector.c tries hard to align the keys anyway.
Hi Koen,
This is probably related to backports for the wireless driver which uses
its own fq.h and fq_impl.h implementation and this is now conflicting
with Eric's patch which got backported.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
I saw this as a compile warning when creating a new backports version
and created this patch:
https://www.spinics.net/lists/backports/msg04930.html
This is for the other way around.
I will try to create a patch for OpenWrt backports tomorrow to fix this
problem and I am also planning to create a new backports release in the
next few days.
Hauke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: crash since commit "net/flow_dissector: switch to siphash"
2019-11-18 0:11 ` Hauke Mehrtens
@ 2019-11-18 14:12 ` Koen Vandeputte
0 siblings, 0 replies; 6+ messages in thread
From: Koen Vandeputte @ 2019-11-18 14:12 UTC (permalink / raw)
To: Hauke Mehrtens, Eric Dumazet; +Cc: netdev, Greg KH
On 18.11.19 01:11, Hauke Mehrtens wrote:
> On 11/15/19 6:09 PM, Eric Dumazet wrote:
>> On Fri, Nov 15, 2019 at 3:30 AM Koen Vandeputte
>> <koen.vandeputte@ncentric.com> wrote:
>>>
>>> On 13.11.19 15:50, Eric Dumazet wrote:
>>>> On Wed, Nov 13, 2019 at 3:52 AM Koen Vandeputte
>>>> <koen.vandeputte@ncentric.com> wrote:
>>>>> Hi Eric,
>>>>>
>>>>> I'm currently testing kernel 4.14.153 bump for OpenWrt and noticed splat
>>>>> below on my testing boards.
>>>>> They all reboot continuously nearly immediately when linked.
>>>>>
>>>>> It feels like it's tied to a commit of yours [1]
>>>> Have you tried current upstream kernels ?
>>> No.
>>>
>>> This board is only supported on OpenWrt currently using 4.14 and it's
>>> not natively supported by upstream.
>>>
>>>> Is is a backport issue, or a bug in original commit ?
>>> No idea .. and I'm not profound enough on that part of the code to judge
>>> this,
>>>
>>> which is why I'm consulting your expert opinion.
>>>
>>>> Can you give us gcc version ?
>>> 7.4.0
>>>> Can you check what SIPHASH_ALIGNMENT value is at compile time ?
>>> 8 (exposed it in dmesg on boot)
>> Please ask OpenWrt specialists for support.
>>
>> The code is probably mishandled by the compiler.
>>
>> siphash() is supposed to handle misaligned data just fine, and
>> net/core/flow_dissector.c tries hard to align the keys anyway.
> Hi Koen,
>
> This is probably related to backports for the wireless driver which uses
> its own fq.h and fq_impl.h implementation and this is now conflicting
> with Eric's patch which got backported.
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v4.14.154&id=a9de6f42e945cdb24b59c7ab7ebad1eba6cb5875
>
> I saw this as a compile warning when creating a new backports version
> and created this patch:
> https://www.spinics.net/lists/backports/msg04930.html
> This is for the other way around.
>
> I will try to create a patch for OpenWrt backports tomorrow to fix this
> problem and I am also planning to create a new backports release in the
> next few days.
>
> Hauke
Hi Hauke,
This indeed fixes the issue.
Thank you!
Sorry for the noise here. ;-)
Koen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-18 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 11:52 crash since commit "net/flow_dissector: switch to siphash" Koen Vandeputte
2019-11-13 14:50 ` Eric Dumazet
2019-11-15 11:30 ` Koen Vandeputte
2019-11-15 17:09 ` Eric Dumazet
2019-11-18 0:11 ` Hauke Mehrtens
2019-11-18 14:12 ` Koen Vandeputte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).