From: Eric Dumazet <edumazet@google.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
David Miller <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>,
shaoyafang@didiglobal.com
Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG()
Date: Fri, 15 Feb 2019 10:22:33 -0800 [thread overview]
Message-ID: <CANn89iKgLBnC6wwDdUmM5XmgnODiL+sdHumg__jVC6FN_kKDEg@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpUR74cYzHL85fgdK72FGvk99zR6Kh46YH-kRnYb4icUsg@mail.gmail.com>
On Fri, Feb 15, 2019 at 10:13 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Fri, Feb 15, 2019 at 8:26 AM Eric Dumazet <edumazet@google.com> wrote:
> >
> > On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao <laoar.shao@gmail.com> wrote:
> > >
> > > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> > >
> >
> > No, we are still using this infrastructure from time to time.
> >
> > I told you I agreed to remove the current (obsolete) TCP call sites,
> > I never suggested to remove SOCK_DEBUG() completely.
>
> Since when do we upstream care about any out-of-tree users?
>
> You can always carry a patch to keep it downstream if you want,
> no one can stop you doing it.
Somehow the patch series seems to present things in this way :
Eric Dumazet suggested to remove completely the SOCK_DEBUG() interface.
I did not.
I sometimes am lazy and use SOCK_DEBUG() myself, so I would like we keep it.
I know that others are doing the same thing, so I do not feel any shame.
Feel free to ignore my feedback.
next prev parent reply other threads:[~2019-02-15 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 14:49 [net-next 0/5] clean up SOCK_DEBUG() Yafang Shao
2019-02-15 14:49 ` [net-next 1/5] tcp: " Yafang Shao
2019-02-15 14:49 ` [net-next 2/5] x25: " Yafang Shao
2019-02-15 14:49 ` [net-next 3/5] appletalk: " Yafang Shao
2019-02-15 14:49 ` [net-next 4/5] dccp: " Yafang Shao
2019-02-15 14:49 ` [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG() Yafang Shao
2019-02-15 14:58 ` Eric Dumazet
2019-02-15 15:41 ` Yafang Shao
2019-02-15 15:54 ` Eric Dumazet
2019-02-15 18:12 ` Cong Wang
2019-02-15 18:22 ` Eric Dumazet [this message]
2019-02-15 18:51 ` Joe Perches
2019-02-16 2:50 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iKgLBnC6wwDdUmM5XmgnODiL+sdHumg__jVC6FN_kKDEg@mail.gmail.com \
--to=edumazet@google.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didiglobal.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).