* [PATCH net] 8139cp: reset BQL when ring tx ring cleared
@ 2013-05-12 0:09 Stephen Hemminger
2013-05-12 1:21 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2013-05-12 0:09 UTC (permalink / raw)
To: David S. Miller, David Woodhouse, Francois Romieu; +Cc: netdev
While looking for other problem found this potential issue.
When the transmit ring is cleaned out, the Byte Queue Limit values
need to be reset.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/drivers/net/ethernet/realtek/8139cp.c 2013-05-02 14:30:52.182573290 -0700
+++ b/drivers/net/ethernet/realtek/8139cp.c 2013-05-11 17:06:51.163362372 -0700
@@ -1136,6 +1136,7 @@ static void cp_clean_rings (struct cp_pr
cp->dev->stats.tx_dropped++;
}
}
+ netdev_tx_reset_queue(cp->dev);
memset(cp->rx_ring, 0, sizeof(struct cp_desc) * CP_RX_RING_SIZE);
memset(cp->tx_ring, 0, sizeof(struct cp_desc) * CP_TX_RING_SIZE);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] 8139cp: reset BQL when ring tx ring cleared
2013-05-12 0:09 [PATCH net] 8139cp: reset BQL when ring tx ring cleared Stephen Hemminger
@ 2013-05-12 1:21 ` David Miller
2013-05-12 2:30 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-05-12 1:21 UTC (permalink / raw)
To: stephen; +Cc: David.Woodhouse, romieu, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 11 May 2013 17:09:23 -0700
> While looking for other problem found this potential issue.
> When the transmit ring is cleaned out, the Byte Queue Limit values
> need to be reset.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
You neither compiled, nor tested this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] 8139cp: reset BQL when ring tx ring cleared
2013-05-12 1:21 ` David Miller
@ 2013-05-12 2:30 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2013-05-12 2:30 UTC (permalink / raw)
To: David Miller; +Cc: David.Woodhouse, romieu, netdev
No forgot to refresh.
On Sat, May 11, 2013 at 6:21 PM, David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Sat, 11 May 2013 17:09:23 -0700
>
>> While looking for other problem found this potential issue.
>> When the transmit ring is cleaned out, the Byte Queue Limit values
>> need to be reset.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> You neither compiled, nor tested this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-12 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-12 0:09 [PATCH net] 8139cp: reset BQL when ring tx ring cleared Stephen Hemminger
2013-05-12 1:21 ` David Miller
2013-05-12 2:30 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).