From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: "Allan W . Nielsen" <allan.nielsen@microchip.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Subject: RE: [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP Ethernet frames
Date: Wed, 14 Aug 2019 04:56:26 +0000 [thread overview]
Message-ID: <VI1PR0401MB2237E0F32D6CC719682E8C1AF8AD0@VI1PR0401MB2237.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190813062525.5bgdzjc6kw5hqdxk@lx-anielsen.microsemi.net>
Hi Allan,
> -----Original Message-----
> From: Allan W . Nielsen <allan.nielsen@microchip.com>
> Sent: Tuesday, August 13, 2019 2:25 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>;
> Alexandre Belloni <alexandre.belloni@bootlin.com>; Microchip Linux Driver
> Support <UNGLinuxDriver@microchip.com>
> Subject: Re: [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP Ethernet frames
>
> The 08/13/2019 10:52, Yangbo Lu wrote:
> > All the PTP messages over Ethernet have etype 0x88f7 on them.
> > Use etype as the key to trap PTP messages.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > ---
> > Changes for v2:
> > - Added this patch.
> > ---
> > drivers/net/ethernet/mscc/ocelot.c | 28 ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c
> > b/drivers/net/ethernet/mscc/ocelot.c
> > index 6932e61..40f4e0d 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -1681,6 +1681,33 @@ int ocelot_probe_port(struct ocelot *ocelot, u8
> > port, } EXPORT_SYMBOL(ocelot_probe_port);
> >
> > +static int ocelot_ace_add_ptp_rule(struct ocelot *ocelot) {
> > + struct ocelot_ace_rule *rule;
> > +
> > + rule = kzalloc(sizeof(*rule), GFP_KERNEL);
> > + if (!rule)
> > + return -ENOMEM;
> > +
> > + /* Entry for PTP over Ethernet (etype 0x88f7)
> > + * Action: trap to CPU port
> > + */
> > + rule->ocelot = ocelot;
> > + rule->prio = 1;
> > + rule->type = OCELOT_ACE_TYPE_ETYPE;
> > + /* Available on all ingress port except CPU port */
> > + rule->ingress_port = ~BIT(ocelot->num_phys_ports);
> > + rule->dmac_mc = OCELOT_VCAP_BIT_1;
> > + rule->frame.etype.etype.value[0] = 0x88;
> > + rule->frame.etype.etype.value[1] = 0xf7;
> > + rule->frame.etype.etype.mask[0] = 0xff;
> > + rule->frame.etype.etype.mask[1] = 0xff;
> > + rule->action = OCELOT_ACL_ACTION_TRAP;
> > +
> > + ocelot_ace_rule_offload_add(rule);
> > + return 0;
> > +}
> > +
> > int ocelot_init(struct ocelot *ocelot) {
> > u32 port;
> > @@ -1708,6 +1735,7 @@ int ocelot_init(struct ocelot *ocelot)
> > ocelot_mact_init(ocelot);
> > ocelot_vlan_init(ocelot);
> > ocelot_ace_init(ocelot);
> > + ocelot_ace_add_ptp_rule(ocelot);
> >
> > for (port = 0; port < ocelot->num_phys_ports; port++) {
> > /* Clear all counters (5 groups) */
> This seems really wrong to me, and much too hard-coded...
>
> What if I want to forward the PTP frames to be forwarded like a normal
> non-aware PTP switch?
[Y.b. Lu] As Andrew said, other switches could identify PTP messages and forward to CPU for processing.
https://patchwork.ozlabs.org/patch/1145627/
I'm also wondering whether there is common method in linux to address your questions.
If no, I think trapping all PTP messages on all ports to CPU could be used for now.
If users require PTP synchronization, they actually don’t want a non-aware PTP switch.
I once see other ocelot code configure ptp trap rules in ioctl timestamping setting. But I don’t think it's proper either.
Enable timestamping doesn’t mean we want to trap PTP messages.
>
> What if do not want this on all ports?
[Y.b. Lu] Actually I don’t think there should be difference of handling PTP messages on each port.
You don’t need to run PTP protocol application on the specific port if you don’t want.
>
> If you do not have an application behind this implementing a boundary or
> transparent clock, then you are breaking PTP on the network.
[Y.b. Lu] You're right. But actually for PTP network, all PTP devices should run PTP protocol on it.
Of course, it's better to have a way to configure it as non-aware PTP switch.
>
> /Allan
next prev parent reply other threads:[~2019-08-14 4:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 2:52 [v2, 0/4] ocelot: support PTP Ethernet frames trapping Yangbo Lu
2019-08-13 2:52 ` [v2, 1/4] ocelot_ace: drop member port from ocelot_ace_rule structure Yangbo Lu
2019-08-13 2:52 ` [v2, 2/4] ocelot_ace: fix ingress ports setting for rule Yangbo Lu
2019-08-13 2:52 ` [v2, 3/4] ocelot_ace: fix action of trap Yangbo Lu
2019-08-13 6:16 ` Allan W . Nielsen
2019-08-13 6:30 ` Allan W . Nielsen
2019-08-14 4:35 ` Y.b. Lu
2019-08-20 4:23 ` Y.b. Lu
2019-08-13 2:52 ` [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP Ethernet frames Yangbo Lu
2019-08-13 6:25 ` Allan W . Nielsen
2019-08-14 4:56 ` Y.b. Lu [this message]
2019-08-14 9:16 ` Allan W . Nielsen
2019-08-15 12:08 ` Y.b. Lu
2019-08-15 12:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2237E0F32D6CC719682E8C1AF8AD0@VI1PR0401MB2237.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).