From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: "Allan W . Nielsen" <allan.nielsen@microchip.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Subject: RE: [v2, 3/4] ocelot_ace: fix action of trap
Date: Tue, 20 Aug 2019 04:23:34 +0000 [thread overview]
Message-ID: <VI1PR0401MB2237F95DABF498497A58702BF8AB0@VI1PR0401MB2237.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190813063011.7pwlzm7mtzlqwwkx@lx-anielsen.microsemi.net>
Hi,
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Allan W . Nielsen
> Sent: Tuesday, August 13, 2019 2:30 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>;
> Alexandre Belloni <alexandre.belloni@bootlin.com>; Microchip Linux Driver
> Support <UNGLinuxDriver@microchip.com>
> Subject: Re: [v2, 3/4] ocelot_ace: fix action of trap
>
> The 08/13/2019 08:16, Allan W . Nielsen wrote:
> > The 08/13/2019 10:52, Yangbo Lu wrote:
> > > The trap action should be copying the frame to CPU and dropping it
> > > for forwarding, but current setting was just copying frame to CPU.
> > >
> > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > > ---
> > > Changes for v2:
> > > - None.
> > > ---
> > > drivers/net/ethernet/mscc/ocelot_ace.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c
> > > b/drivers/net/ethernet/mscc/ocelot_ace.c
> > > index 91250f3..59ad590 100644
> > > --- a/drivers/net/ethernet/mscc/ocelot_ace.c
> > > +++ b/drivers/net/ethernet/mscc/ocelot_ace.c
> > > @@ -317,9 +317,9 @@ static void is2_action_set(struct vcap_data *data,
> > > break;
> > > case OCELOT_ACL_ACTION_TRAP:
> > > VCAP_ACT_SET(PORT_MASK, 0x0);
> > > - VCAP_ACT_SET(MASK_MODE, 0x0);
> > > - VCAP_ACT_SET(POLICE_ENA, 0x0);
> > > - VCAP_ACT_SET(POLICE_IDX, 0x0);
> > > + VCAP_ACT_SET(MASK_MODE, 0x1);
> > > + VCAP_ACT_SET(POLICE_ENA, 0x1);
> > > + VCAP_ACT_SET(POLICE_IDX, OCELOT_POLICER_DISCARD);
> > > VCAP_ACT_SET(CPU_QU_NUM, 0x0);
> > > VCAP_ACT_SET(CPU_COPY_ENA, 0x1);
> > > break;
> >
> > This is still wrong, please see the comments provided the first time
> > you submitted this.
> >
> > /Allan
>
> I believe this will make it work - but I have not tested it:
>
> case OCELOT_ACL_ACTION_TRAP:
> VCAP_ACT_SET(PORT_MASK, 0x0);
> - VCAP_ACT_SET(MASK_MODE, 0x0);
> + VCAP_ACT_SET(MASK_MODE, 0x1);
> VCAP_ACT_SET(CPU_QU_NUM, 0x0);
> VCAP_ACT_SET(CPU_COPY_ENA, 0x1);
> break;
>
[Y.b. Lu] It makes sense. And it worked.
I have sent out v3 which only included this one patch. I'd like to send the other patches once Felix driver is accepted, but I'd like to collect the suggestions :)
Thanks.
Sorry, I missed to add change logs for v3 patch...
https://patchwork.ozlabs.org/patch/1149770/
> --
> /Allan
next prev parent reply other threads:[~2019-08-20 4:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 2:52 [v2, 0/4] ocelot: support PTP Ethernet frames trapping Yangbo Lu
2019-08-13 2:52 ` [v2, 1/4] ocelot_ace: drop member port from ocelot_ace_rule structure Yangbo Lu
2019-08-13 2:52 ` [v2, 2/4] ocelot_ace: fix ingress ports setting for rule Yangbo Lu
2019-08-13 2:52 ` [v2, 3/4] ocelot_ace: fix action of trap Yangbo Lu
2019-08-13 6:16 ` Allan W . Nielsen
2019-08-13 6:30 ` Allan W . Nielsen
2019-08-14 4:35 ` Y.b. Lu
2019-08-20 4:23 ` Y.b. Lu [this message]
2019-08-13 2:52 ` [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP Ethernet frames Yangbo Lu
2019-08-13 6:25 ` Allan W . Nielsen
2019-08-14 4:56 ` Y.b. Lu
2019-08-14 9:16 ` Allan W . Nielsen
2019-08-15 12:08 ` Y.b. Lu
2019-08-15 12:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2237F95DABF498497A58702BF8AB0@VI1PR0401MB2237.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).