From: Ansuel Smith <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v3 05/20] net: dsa: qca8k: handle error with qca8k_read operation
Date: Wed, 5 May 2021 02:44:50 +0200 [thread overview]
Message-ID: <YJHqgnMLEI1gQZBm@Ansuel-xps.localdomain> (raw)
In-Reply-To: <YJHof4mwG7xYRc8f@lunn.ch>
On Wed, May 05, 2021 at 02:36:15AM +0200, Andrew Lunn wrote:
> On Wed, May 05, 2021 at 12:28:59AM +0200, Ansuel Smith wrote:
> > qca8k_read can fail. Rework any user to handle error values and
> > correctly return.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > drivers/net/dsa/qca8k.c | 90 +++++++++++++++++++++++++++++++----------
> > 1 file changed, 69 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> > index 411b42d38819..cde68ed6856b 100644
> > --- a/drivers/net/dsa/qca8k.c
> > +++ b/drivers/net/dsa/qca8k.c
> > @@ -146,12 +146,13 @@ qca8k_set_page(struct mii_bus *bus, u16 page)
> > static u32
> > qca8k_read(struct qca8k_priv *priv, u32 reg)
> > {
> > + struct mii_bus *bus = priv->bus;
> > u16 r1, r2, page;
> > u32 val;
> >
> > qca8k_split_addr(reg, &r1, &r2, &page);
> >
> > - mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED);
> > + mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
> >
> > val = qca8k_set_page(priv->bus, page);
> > if (val < 0)
> > @@ -160,8 +161,7 @@ qca8k_read(struct qca8k_priv *priv, u32 reg)
> > val = qca8k_mii_read32(priv->bus, 0x10 | r2, r1);
> >
> > exit:
> > - mutex_unlock(&priv->bus->mdio_lock);
> > -
> > + mutex_unlock(&bus->mdio_lock);
> > return val;
>
> This change does not have anything to do with the commit message.
>
> > }
Will split in another patch.
> >
> > @@ -226,8 +226,13 @@ static int
> > qca8k_regmap_read(void *ctx, uint32_t reg, uint32_t *val)
> > {
> > struct qca8k_priv *priv = (struct qca8k_priv *)ctx;
> > + int ret;
> >
> > - *val = qca8k_read(priv, reg);
> > + ret = qca8k_read(priv, reg);
> > + if (ret < 0)
> > + return ret;
> > +
> > + *val = ret;
> >
> > return 0;
> > }
> > @@ -280,15 +285,17 @@ static int
> > qca8k_busy_wait(struct qca8k_priv *priv, u32 reg, u32 mask)
> > {
> > unsigned long timeout;
> > + u32 val;
> >
> > timeout = jiffies + msecs_to_jiffies(20);
> >
> > /* loop until the busy flag has cleared */
> > do {
> > - u32 val = qca8k_read(priv, reg);
> > - int busy = val & mask;
> > + val = qca8k_read(priv, reg);
> > + if (val < 0)
> > + continue;
> >
> > - if (!busy)
> > + if (!(val & mask))
> > break;
> > cond_resched();
>
> Maybe there is a patch doing this already, but it would be good to
> make use of include/linux/iopoll.h
>
Will check if I can find something to replace this.
> > qca8k_fdb_next(struct qca8k_priv *priv, struct qca8k_fdb *fdb, int port)
> > {
> > - int ret;
> > + int ret, ret_read;
> >
> > qca8k_fdb_write(priv, fdb->vid, fdb->port_mask, fdb->mac, fdb->aging);
> > ret = qca8k_fdb_access(priv, QCA8K_FDB_NEXT, port);
> > - if (ret >= 0)
> > - qca8k_fdb_read(priv, fdb);
> > + if (ret >= 0) {
> > + ret_read = qca8k_fdb_read(priv, fdb);
> > + if (ret_read < 0)
> > + return ret_read;
> > + }
> >
> > return ret;
> > }
>
> This is oddly structured. Why not:
>
> qca8k_fdb_next(struct qca8k_priv *priv, struct qca8k_fdb *fdb, int port)
> {
> int ret;
>
> qca8k_fdb_write(priv, fdb->vid, fdb->port_mask, fdb->mac, fdb->aging);
>
> ret = qca8k_fdb_access(priv, QCA8K_FDB_NEXT, port);
> if (ret < 0)
> return ret;
>
> return qca8k_fdb_read(priv, fdb);
> }
>
It's late here and I could be wrong...
Doesn't your suggested code change the original function return value?
In the original function we returned qca8k_fdb_access, isn't wrong to
return qca8k_fdb_read on success? Or the function was wrong from the
start?
> Andrew
next prev parent reply other threads:[~2021-05-05 0:45 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 22:28 [RFC PATCH net-next v3 01/20] net: mdio: ipq8064: clean whitespaces in define Ansuel Smith
2021-05-04 22:28 ` [RFC PATCH net-next v3 02/20] net: mdio: ipq8064: add regmap config to disable REGCACHE Ansuel Smith
2021-05-04 22:28 ` [RFC PATCH net-next v3 03/20] net: mdio: ipq8064: enlarge sleep after read/write operation Ansuel Smith
2021-05-04 22:28 ` [RFC PATCH net-next v3 04/20] net: dsa: qca8k: handle qca8k_set_page errors Ansuel Smith
2021-05-05 0:25 ` Andrew Lunn
2021-05-05 0:26 ` Andrew Lunn
2021-05-04 22:28 ` [RFC PATCH net-next v3 05/20] net: dsa: qca8k: handle error with qca8k_read operation Ansuel Smith
2021-05-05 0:36 ` Andrew Lunn
2021-05-05 0:44 ` Ansuel Smith [this message]
2021-05-04 22:29 ` [RFC PATCH net-next v3 06/20] net: dsa: qca8k: handle error with qca8k_write operation Ansuel Smith
2021-05-05 0:41 ` Andrew Lunn
2021-05-05 0:47 ` Ansuel Smith
2021-05-06 11:19 ` Vladimir Oltean
2021-05-04 22:29 ` [RFC PATCH net-next v3 07/20] net: dsa: qca8k: handle error with qca8k_rmw operation Ansuel Smith
2021-05-05 0:46 ` Andrew Lunn
2021-05-05 0:51 ` Ansuel Smith
2021-05-04 22:29 ` [RFC PATCH net-next v3 08/20] net: dsa: qca8k: add support for qca8327 switch Ansuel Smith
2021-05-05 0:48 ` Andrew Lunn
2021-05-06 11:20 ` Vladimir Oltean
2021-05-04 22:29 ` [RFC PATCH net-next v3 09/20] devicetree: net: dsa: qca8k: Document new compatible qca8327 Ansuel Smith
2021-05-05 0:48 ` Andrew Lunn
2021-05-06 21:07 ` Rob Herring
2021-05-04 22:29 ` [RFC PATCH net-next v3 10/20] net: dsa: qca8k: add priority tweak to qca8337 switch Ansuel Smith
2021-05-05 0:53 ` Andrew Lunn
2021-05-06 11:16 ` Vladimir Oltean
2021-05-04 22:29 ` [RFC PATCH net-next v3 11/20] net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327 Ansuel Smith
2021-05-05 0:54 ` Andrew Lunn
2021-05-04 22:29 ` [RFC PATCH net-next v3 12/20] net: dsa: qca8k: add support for switch rev Ansuel Smith
2021-05-04 22:29 ` [RFC PATCH net-next v3 13/20] net: dsa: qca8k: make rgmii delay configurable Ansuel Smith
2021-05-05 1:00 ` Andrew Lunn
2021-05-05 1:07 ` Ansuel Smith
2021-05-06 11:10 ` Vladimir Oltean
2021-05-06 21:53 ` Ansuel Smith
2021-05-07 8:51 ` Vladimir Oltean
2021-05-04 22:29 ` [RFC PATCH net-next v3 14/20] net: dsa: qca8k: clear MASTER_EN after phy read/write Ansuel Smith
2021-05-04 22:29 ` [RFC PATCH net-next v3 15/20] net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex Ansuel Smith
2021-05-05 1:04 ` Andrew Lunn
2021-05-04 22:29 ` [RFC PATCH net-next v3 16/20] net: dsa: qca8k: enlarge mdio delay and timeout Ansuel Smith
2021-05-06 11:27 ` Vladimir Oltean
2021-05-04 22:29 ` [RFC PATCH net-next v3 17/20] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Ansuel Smith
2021-05-04 22:33 ` Florian Fainelli
2021-05-05 0:35 ` Ansuel Smith
2021-05-04 22:29 ` [RFC PATCH net-next v3 18/20] net: dsa: slave: pass dev_flags also to internal PHY Ansuel Smith
2021-05-04 22:29 ` [RFC PATCH net-next v3 19/20] net: dsa: qca8k: pass switch_revision info to phy dev_flags Ansuel Smith
2021-05-06 11:24 ` Vladimir Oltean
2021-05-07 23:26 ` Ansuel Smith
2021-05-07 23:33 ` Russell King - ARM Linux admin
2021-05-07 23:51 ` Ansuel Smith
2021-05-08 17:31 ` Andrew Lunn
2021-05-08 18:26 ` Vladimir Oltean
2021-05-08 19:39 ` Russell King - ARM Linux admin
2021-05-08 20:55 ` Andrew Lunn
2021-05-07 9:44 ` Russell King - ARM Linux admin
2021-05-04 22:29 ` [RFC PATCH net-next v3 20/20] net: phy: add qca8k driver for qca8k switch internal PHY Ansuel Smith
2021-05-05 1:11 ` Andrew Lunn
2021-05-05 1:17 ` Ansuel Smith
2021-05-05 12:06 ` Andrew Lunn
2021-05-04 22:29 ` [RFC PATCH next-next v3 00/20] Multiple improvement to qca8k stability Ansuel Smith
2021-05-05 0:17 ` [RFC PATCH net-next v3 01/20] net: mdio: ipq8064: clean whitespaces in define Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJHqgnMLEI1gQZBm@Ansuel-xps.localdomain \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).