* Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path [not found] ` <20230127135755.79929-3-mathieu.desnoyers@efficios.com> @ 2023-01-30 16:12 ` Shuah Khan 2023-01-30 16:26 ` Alexei Starovoitov 0 siblings, 1 reply; 12+ messages in thread From: Shuah Khan @ 2023-01-30 16:12 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Ingo Molnar, Alexei Starovoitov, Daniel Borkmann Cc: linux-kernel, stable, bpf, Networking, Shuah Khan On 1/27/23 06:57, Mathieu Desnoyers wrote: > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents > building against kernel headers from the build environment in scenarios > where kernel headers are installed into a specific output directory > (O=...). > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > Cc: Shuah Khan <shuah@kernel.org> > Cc: linux-kselftest@vger.kernel.org > Cc: Ingo Molnar <mingo@redhat.com> > Cc: <stable@vger.kernel.org> [5.18+] > --- > tools/testing/selftests/bpf/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index c22c43bbee19..6998c816afef 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -327,7 +327,7 @@ endif > CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH)) > BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN) \ > -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR) \ > - -I$(abspath $(OUTPUT)/../usr/include) > + $(KHDR_INCLUDES) > > CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \ > -Wno-compare-distinct-pointer-types Adding bpf maintainers - bpf patches usually go through bpf tree. Acked-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path 2023-01-30 16:12 ` [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path Shuah Khan @ 2023-01-30 16:26 ` Alexei Starovoitov 2023-01-30 17:00 ` Mathieu Desnoyers 0 siblings, 1 reply; 12+ messages in thread From: Alexei Starovoitov @ 2023-01-30 16:26 UTC (permalink / raw) To: Shuah Khan Cc: Mathieu Desnoyers, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, Alexei Starovoitov, Daniel Borkmann, LKML, stable, bpf, Networking On Mon, Jan 30, 2023 at 8:12 AM Shuah Khan <skhan@linuxfoundation.org> wrote: > > On 1/27/23 06:57, Mathieu Desnoyers wrote: > > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents > > building against kernel headers from the build environment in scenarios > > where kernel headers are installed into a specific output directory > > (O=...). > > > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > Cc: Shuah Khan <shuah@kernel.org> > > Cc: linux-kselftest@vger.kernel.org > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: <stable@vger.kernel.org> [5.18+] > > --- > > tools/testing/selftests/bpf/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > > index c22c43bbee19..6998c816afef 100644 > > --- a/tools/testing/selftests/bpf/Makefile > > +++ b/tools/testing/selftests/bpf/Makefile > > @@ -327,7 +327,7 @@ endif > > CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH)) > > BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN) \ > > -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR) \ > > - -I$(abspath $(OUTPUT)/../usr/include) > > + $(KHDR_INCLUDES) > > > > CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \ > > -Wno-compare-distinct-pointer-types > > > > Adding bpf maintainers - bpf patches usually go through bpf tree. > > Acked-by: Shuah Khan <skhan@linuxfoundation.org> Please resubmit as separate patch with [PATCH bpf-next] subj and cc bpf@vger, so that BPF CI can test it on various architectures and config combinations. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path 2023-01-30 16:26 ` Alexei Starovoitov @ 2023-01-30 17:00 ` Mathieu Desnoyers 2023-01-30 17:09 ` Shuah Khan 0 siblings, 1 reply; 12+ messages in thread From: Mathieu Desnoyers @ 2023-01-30 17:00 UTC (permalink / raw) To: Alexei Starovoitov, Shuah Khan Cc: Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, Alexei Starovoitov, Daniel Borkmann, LKML, stable, bpf, Networking On 2023-01-30 11:26, Alexei Starovoitov wrote: > On Mon, Jan 30, 2023 at 8:12 AM Shuah Khan <skhan@linuxfoundation.org> wrote: >> >> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents >>> building against kernel headers from the build environment in scenarios >>> where kernel headers are installed into a specific output directory >>> (O=...). >>> >>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> >>> Cc: Shuah Khan <shuah@kernel.org> >>> Cc: linux-kselftest@vger.kernel.org >>> Cc: Ingo Molnar <mingo@redhat.com> >>> Cc: <stable@vger.kernel.org> [5.18+] >>> --- >>> tools/testing/selftests/bpf/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile >>> index c22c43bbee19..6998c816afef 100644 >>> --- a/tools/testing/selftests/bpf/Makefile >>> +++ b/tools/testing/selftests/bpf/Makefile >>> @@ -327,7 +327,7 @@ endif >>> CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH)) >>> BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN) \ >>> -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR) \ >>> - -I$(abspath $(OUTPUT)/../usr/include) >>> + $(KHDR_INCLUDES) >>> >>> CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \ >>> -Wno-compare-distinct-pointer-types >> >> >> >> Adding bpf maintainers - bpf patches usually go through bpf tree. >> >> Acked-by: Shuah Khan <skhan@linuxfoundation.org> > > Please resubmit as separate patch with [PATCH bpf-next] subj > and cc bpf@vger, so that BPF CI can test it on various architectures > and config combinations. Hi Shuah, Do you have means to resubmit it on your end, or should I do it ? Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path 2023-01-30 17:00 ` Mathieu Desnoyers @ 2023-01-30 17:09 ` Shuah Khan 0 siblings, 0 replies; 12+ messages in thread From: Shuah Khan @ 2023-01-30 17:09 UTC (permalink / raw) To: Mathieu Desnoyers, Alexei Starovoitov Cc: Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, Alexei Starovoitov, Daniel Borkmann, LKML, stable, bpf, Networking, Shuah Khan On 1/30/23 10:00, Mathieu Desnoyers wrote: > On 2023-01-30 11:26, Alexei Starovoitov wrote: >> On Mon, Jan 30, 2023 at 8:12 AM Shuah Khan <skhan@linuxfoundation.org> wrote: >>> >>> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>>> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents >>>> building against kernel headers from the build environment in scenarios >>>> where kernel headers are installed into a specific output directory >>>> (O=...). >>>> >>>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> >>>> Cc: Shuah Khan <shuah@kernel.org> >>>> Cc: linux-kselftest@vger.kernel.org >>>> Cc: Ingo Molnar <mingo@redhat.com> >>>> Cc: <stable@vger.kernel.org> [5.18+] >>>> --- >>>> tools/testing/selftests/bpf/Makefile | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile >>>> index c22c43bbee19..6998c816afef 100644 >>>> --- a/tools/testing/selftests/bpf/Makefile >>>> +++ b/tools/testing/selftests/bpf/Makefile >>>> @@ -327,7 +327,7 @@ endif >>>> CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_ARCH)) >>>> BPF_CFLAGS = -g -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN) \ >>>> -I$(INCLUDE_DIR) -I$(CURDIR) -I$(APIDIR) \ >>>> - -I$(abspath $(OUTPUT)/../usr/include) >>>> + $(KHDR_INCLUDES) >>>> >>>> CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) \ >>>> -Wno-compare-distinct-pointer-types >>> >>> >>> >>> Adding bpf maintainers - bpf patches usually go through bpf tree. >>> >>> Acked-by: Shuah Khan <skhan@linuxfoundation.org> >> >> Please resubmit as separate patch with [PATCH bpf-next] subj >> and cc bpf@vger, so that BPF CI can test it on various architectures >> and config combinations. > > Hi Shuah, > > Do you have means to resubmit it on your end, or should I do it ? > Hi Mathieu, Please go ahead and resubmit. thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20230127135755.79929-18-mathieu.desnoyers@efficios.com>]
* Re: [PATCH 17/34] selftests: net: Fix incorrect kernel headers search path [not found] ` <20230127135755.79929-18-mathieu.desnoyers@efficios.com> @ 2023-01-30 16:24 ` Shuah Khan 0 siblings, 0 replies; 12+ messages in thread From: Shuah Khan @ 2023-01-30 16:24 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Ingo Molnar, kuba, David S. Miller Cc: linux-kernel, stable, Shuah Khan, Networking On 1/27/23 06:57, Mathieu Desnoyers wrote: > Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents > building against kernel headers from the build environment in scenarios > where kernel headers are installed into a specific output directory > (O=...). > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > Cc: Shuah Khan <shuah@kernel.org> > Cc: linux-kselftest@vger.kernel.org > Cc: Ingo Molnar <mingo@redhat.com> > Cc: <stable@vger.kernel.org> [5.18+] > --- > tools/testing/selftests/net/Makefile | 2 +- > tools/testing/selftests/net/bpf/Makefile | 2 +- > tools/testing/selftests/net/mptcp/Makefile | 2 +- > tools/testing/selftests/net/openvswitch/Makefile | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Adding net maintainers: Would you me to take this patch through kselftest tree? If you decide to take this through yours: Acked-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path [not found] <20230127135755.79929-1-mathieu.desnoyers@efficios.com> [not found] ` <20230127135755.79929-3-mathieu.desnoyers@efficios.com> [not found] ` <20230127135755.79929-18-mathieu.desnoyers@efficios.com> @ 2023-01-30 22:29 ` Shuah Khan 2023-01-30 23:45 ` Alexei Starovoitov 2023-02-02 2:07 ` Shuah Khan 2 siblings, 2 replies; 12+ messages in thread From: Shuah Khan @ 2023-01-30 22:29 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Ingo Molnar Cc: linux-kernel, bpf, Networking, linuxppc-dev, Shuah Khan On 1/27/23 06:57, Mathieu Desnoyers wrote: > Hi, > > This series fixes incorrect kernel header search path in kernel > selftests. > > Near the end of the series, a few changes are not tagged as "Fixes" > because the current behavior is to rely on the kernel sources uapi files > rather than on the installed kernel header files. Nevertheless, those > are updated for consistency. > > There are situations where "../../../../include/" was added to -I search > path, which is bogus for userspace tests and caused issues with types.h. > Those are removed. > > Thanks, > > Mathieu > > Mathieu Desnoyers (34): The below patches are now applied to linux-kselftest next for Linux 6.3-rc1 > selftests: arm64: Fix incorrect kernel headers search path > selftests: clone3: Fix incorrect kernel headers search path > selftests: core: Fix incorrect kernel headers search path > selftests: dma: Fix incorrect kernel headers search path > selftests: dmabuf-heaps: Fix incorrect kernel headers search path > selftests: drivers: Fix incorrect kernel headers search path > selftests: filesystems: Fix incorrect kernel headers search path > selftests: futex: Fix incorrect kernel headers search path > selftests: gpio: Fix incorrect kernel headers search path > selftests: ipc: Fix incorrect kernel headers search path > selftests: kcmp: Fix incorrect kernel headers search path > selftests: media_tests: Fix incorrect kernel headers search path > selftests: membarrier: Fix incorrect kernel headers search path > selftests: mount_setattr: Fix incorrect kernel headers search path > selftests: move_mount_set_group: Fix incorrect kernel headers search > path > selftests: perf_events: Fix incorrect kernel headers search path > selftests: pid_namespace: Fix incorrect kernel headers search path > selftests: pidfd: Fix incorrect kernel headers search path > selftests: ptp: Fix incorrect kernel headers search path > selftests: rseq: Fix incorrect kernel headers search path > selftests: sched: Fix incorrect kernel headers search path > selftests: seccomp: Fix incorrect kernel headers search path > selftests: sync: Fix incorrect kernel headers search path > selftests: user_events: Fix incorrect kernel headers search path > selftests: vm: Fix incorrect kernel headers search path > selftests: x86: Fix incorrect kernel headers search path > selftests: iommu: Use installed kernel headers search path > selftests: memfd: Use installed kernel headers search path > selftests: ptrace: Use installed kernel headers search path > selftests: tdx: Use installed kernel headers search path > These will be applied by maintainers to their trees. > selftests: bpf: Fix incorrect kernel headers search path # 02/34 > selftests: net: Fix incorrect kernel headers search path # 17/34 > selftests: powerpc: Fix incorrect kernel headers search path # 21/34 > selftests: bpf docs: Use installed kernel headers search path # 30/34 thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-01-30 22:29 ` [PATCH 00/34] selftests: " Shuah Khan @ 2023-01-30 23:45 ` Alexei Starovoitov 2023-01-30 23:48 ` Shuah Khan 2023-02-02 2:07 ` Shuah Khan 1 sibling, 1 reply; 12+ messages in thread From: Alexei Starovoitov @ 2023-01-30 23:45 UTC (permalink / raw) To: Shuah Khan Cc: Mathieu Desnoyers, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, LKML, bpf, Networking, ppc-dev On Mon, Jan 30, 2023 at 2:46 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > On 1/27/23 06:57, Mathieu Desnoyers wrote: > > Hi, > > > > This series fixes incorrect kernel header search path in kernel > > selftests. > > > > Near the end of the series, a few changes are not tagged as "Fixes" > > because the current behavior is to rely on the kernel sources uapi files > > rather than on the installed kernel header files. Nevertheless, those > > are updated for consistency. > > > > There are situations where "../../../../include/" was added to -I search > > path, which is bogus for userspace tests and caused issues with types.h. > > Those are removed. > > > > Thanks, > > > > Mathieu > > > > Mathieu Desnoyers (34): > > The below patches are now applied to linux-kselftest next for Linux 6.3-rc1 > > > selftests: arm64: Fix incorrect kernel headers search path > > selftests: clone3: Fix incorrect kernel headers search path > > selftests: core: Fix incorrect kernel headers search path > > selftests: dma: Fix incorrect kernel headers search path > > selftests: dmabuf-heaps: Fix incorrect kernel headers search path > > selftests: drivers: Fix incorrect kernel headers search path > > selftests: filesystems: Fix incorrect kernel headers search path > > selftests: futex: Fix incorrect kernel headers search path > > selftests: gpio: Fix incorrect kernel headers search path > > selftests: ipc: Fix incorrect kernel headers search path > > selftests: kcmp: Fix incorrect kernel headers search path > > selftests: media_tests: Fix incorrect kernel headers search path > > selftests: membarrier: Fix incorrect kernel headers search path > > selftests: mount_setattr: Fix incorrect kernel headers search path > > selftests: move_mount_set_group: Fix incorrect kernel headers search > > path > > selftests: perf_events: Fix incorrect kernel headers search path > > selftests: pid_namespace: Fix incorrect kernel headers search path > > selftests: pidfd: Fix incorrect kernel headers search path > > selftests: ptp: Fix incorrect kernel headers search path > > selftests: rseq: Fix incorrect kernel headers search path > > selftests: sched: Fix incorrect kernel headers search path > > selftests: seccomp: Fix incorrect kernel headers search path > > selftests: sync: Fix incorrect kernel headers search path > > selftests: user_events: Fix incorrect kernel headers search path > > selftests: vm: Fix incorrect kernel headers search path > > selftests: x86: Fix incorrect kernel headers search path > > selftests: iommu: Use installed kernel headers search path > > selftests: memfd: Use installed kernel headers search path > > selftests: ptrace: Use installed kernel headers search path > > selftests: tdx: Use installed kernel headers search path > > > > These will be applied by maintainers to their trees. Not in this form. They break the build. > > selftests: bpf: Fix incorrect kernel headers search path # 02/34 > > selftests: net: Fix incorrect kernel headers search path # 17/34 > > selftests: powerpc: Fix incorrect kernel headers search path # 21/34 > > selftests: bpf docs: Use installed kernel headers search path # 30/34 > > thanks, > -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-01-30 23:45 ` Alexei Starovoitov @ 2023-01-30 23:48 ` Shuah Khan 2023-01-30 23:49 ` Alexei Starovoitov 0 siblings, 1 reply; 12+ messages in thread From: Shuah Khan @ 2023-01-30 23:48 UTC (permalink / raw) To: Alexei Starovoitov Cc: Mathieu Desnoyers, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, LKML, bpf, Networking, ppc-dev, Shuah Khan On 1/30/23 16:45, Alexei Starovoitov wrote: > On Mon, Jan 30, 2023 at 2:46 PM Shuah Khan <skhan@linuxfoundation.org> wrote: >> >> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>> Hi, >>> >>> This series fixes incorrect kernel header search path in kernel >>> selftests. >>> >>> Near the end of the series, a few changes are not tagged as "Fixes" >>> because the current behavior is to rely on the kernel sources uapi files >>> rather than on the installed kernel header files. Nevertheless, those >>> are updated for consistency. >>> >>> There are situations where "../../../../include/" was added to -I search >>> path, which is bogus for userspace tests and caused issues with types.h. >>> Those are removed. >>> >>> Thanks, >>> >>> Mathieu >>> >>> Mathieu Desnoyers (34): >> >> The below patches are now applied to linux-kselftest next for Linux 6.3-rc1 >> >>> selftests: arm64: Fix incorrect kernel headers search path >>> selftests: clone3: Fix incorrect kernel headers search path >>> selftests: core: Fix incorrect kernel headers search path >>> selftests: dma: Fix incorrect kernel headers search path >>> selftests: dmabuf-heaps: Fix incorrect kernel headers search path >>> selftests: drivers: Fix incorrect kernel headers search path >>> selftests: filesystems: Fix incorrect kernel headers search path >>> selftests: futex: Fix incorrect kernel headers search path >>> selftests: gpio: Fix incorrect kernel headers search path >>> selftests: ipc: Fix incorrect kernel headers search path >>> selftests: kcmp: Fix incorrect kernel headers search path >>> selftests: media_tests: Fix incorrect kernel headers search path >>> selftests: membarrier: Fix incorrect kernel headers search path >>> selftests: mount_setattr: Fix incorrect kernel headers search path >>> selftests: move_mount_set_group: Fix incorrect kernel headers search >>> path >>> selftests: perf_events: Fix incorrect kernel headers search path >>> selftests: pid_namespace: Fix incorrect kernel headers search path >>> selftests: pidfd: Fix incorrect kernel headers search path >>> selftests: ptp: Fix incorrect kernel headers search path >>> selftests: rseq: Fix incorrect kernel headers search path >>> selftests: sched: Fix incorrect kernel headers search path >>> selftests: seccomp: Fix incorrect kernel headers search path >>> selftests: sync: Fix incorrect kernel headers search path >>> selftests: user_events: Fix incorrect kernel headers search path >>> selftests: vm: Fix incorrect kernel headers search path >>> selftests: x86: Fix incorrect kernel headers search path >>> selftests: iommu: Use installed kernel headers search path >>> selftests: memfd: Use installed kernel headers search path >>> selftests: ptrace: Use installed kernel headers search path >>> selftests: tdx: Use installed kernel headers search path >>> >> >> These will be applied by maintainers to their trees. > > Not in this form. They break the build. Mathieu is sending you the patches in the format you requested in the thread on this patch. thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-01-30 23:48 ` Shuah Khan @ 2023-01-30 23:49 ` Alexei Starovoitov 0 siblings, 0 replies; 12+ messages in thread From: Alexei Starovoitov @ 2023-01-30 23:49 UTC (permalink / raw) To: Shuah Khan Cc: Mathieu Desnoyers, Shuah Khan, open list:KERNEL SELFTEST FRAMEWORK, Ingo Molnar, LKML, bpf, Networking, ppc-dev On Mon, Jan 30, 2023 at 3:48 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > >> > >> These will be applied by maintainers to their trees. > > > > Not in this form. They break the build. > > Mathieu is sending you the patches in the format you requested in > the thread on this patch. It's not the format, but the patch itself is incorrect. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-01-30 22:29 ` [PATCH 00/34] selftests: " Shuah Khan 2023-01-30 23:45 ` Alexei Starovoitov @ 2023-02-02 2:07 ` Shuah Khan 2023-02-04 1:06 ` Shuah Khan 1 sibling, 1 reply; 12+ messages in thread From: Shuah Khan @ 2023-02-02 2:07 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Ingo Molnar Cc: linux-kernel, bpf, Networking, linuxppc-dev, Shuah Khan Hi Mathieu, On 1/30/23 15:29, Shuah Khan wrote: > On 1/27/23 06:57, Mathieu Desnoyers wrote: >> Hi, >> >> This series fixes incorrect kernel header search path in kernel >> selftests. >> >> Near the end of the series, a few changes are not tagged as "Fixes" >> because the current behavior is to rely on the kernel sources uapi files >> rather than on the installed kernel header files. Nevertheless, those >> are updated for consistency. >> >> There are situations where "../../../../include/" was added to -I search >> path, which is bogus for userspace tests and caused issues with types.h. >> Those are removed. >> Thanks again for taking care of this. I did out of tree build testing on x86 on linux-kselftest next with these patches below. I haven't seen any problems introduced by the patch set. >> selftests: dma: Fix incorrect kernel headers search path This one needs a change and I will send a patch on top of yours. Even with that this test depends on unexported header from the repo and won't build out of tree. This is not related to your change. >> selftests: mount_setattr: Fix incorrect kernel headers search path This one fails to build with our without patch - an existing error. I have to do cross-build tests on arm64 and other arch patches still. This will happen later this week. >> selftests: arm64: Fix incorrect kernel headers search path drivers patch below had arch specific tests - testing todo The rest looks good. I will try to run bpf patches on my system. I do have clang, llvm installed on mine. TODO thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-02-02 2:07 ` Shuah Khan @ 2023-02-04 1:06 ` Shuah Khan 2023-02-11 0:15 ` Shuah Khan 0 siblings, 1 reply; 12+ messages in thread From: Shuah Khan @ 2023-02-04 1:06 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Ingo Molnar Cc: linux-kernel, bpf, Networking, linuxppc-dev, Shuah Khan On 2/1/23 19:07, Shuah Khan wrote: > Hi Mathieu, > > On 1/30/23 15:29, Shuah Khan wrote: >> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>> Hi, >>> >>> This series fixes incorrect kernel header search path in kernel >>> selftests. >>> >>> Near the end of the series, a few changes are not tagged as "Fixes" >>> because the current behavior is to rely on the kernel sources uapi files >>> rather than on the installed kernel header files. Nevertheless, those >>> are updated for consistency. >>> >>> There are situations where "../../../../include/" was added to -I search >>> path, which is bogus for userspace tests and caused issues with types.h. >>> Those are removed. >>> > > Thanks again for taking care of this. I did out of tree build testing on > x86 on linux-kselftest next with these patches below. I haven't seen > any problems introduced by the patch set. > >>> selftests: dma: Fix incorrect kernel headers search path > This one needs a change and I will send a patch on top of yours. > Even with that this test depends on unexported header from the > repo and won't build out of tree. This is not related to your > change. > >>> selftests: mount_setattr: Fix incorrect kernel headers search path > This one fails to build with our without patch - an existing error. > > I have to do cross-build tests on arm64 and other arch patches still. > This will happen later this week. arm64, s390 patches look good. thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/34] selftests: Fix incorrect kernel headers search path 2023-02-04 1:06 ` Shuah Khan @ 2023-02-11 0:15 ` Shuah Khan 0 siblings, 0 replies; 12+ messages in thread From: Shuah Khan @ 2023-02-11 0:15 UTC (permalink / raw) To: Mathieu Desnoyers, Shuah Khan, linux-kselftest, Steven Rostedt, Christoph Hellwig Cc: linux-kernel, bpf, Networking, Ingo Molnar, linuxppc-dev On 2/3/23 18:06, Shuah Khan wrote: > On 2/1/23 19:07, Shuah Khan wrote: >> Hi Mathieu, >> >> On 1/30/23 15:29, Shuah Khan wrote: >>> On 1/27/23 06:57, Mathieu Desnoyers wrote: >>>> Hi, >>>> >>>> This series fixes incorrect kernel header search path in kernel >>>> selftests. >>>> >>>> Near the end of the series, a few changes are not tagged as "Fixes" >>>> because the current behavior is to rely on the kernel sources uapi files >>>> rather than on the installed kernel header files. Nevertheless, those >>>> are updated for consistency. >>>> >>>> There are situations where "../../../../include/" was added to -I search >>>> path, which is bogus for userspace tests and caused issues with types.h. >>>> Those are removed. >>>> >> >> Thanks again for taking care of this. I did out of tree build testing on >> x86 on linux-kselftest next with these patches below. I haven't seen >> any problems introduced by the patch set. >> >>>> selftests: dma: Fix incorrect kernel headers search path >> This one needs a change and I will send a patch on top of yours. >> Even with that this test depends on unexported header from the >> repo and won't build out of tree. This is not related to your >> change. >> >>>> selftests: mount_setattr: Fix incorrect kernel headers search path >> This one fails to build with our without patch - an existing error. >> >> I have to do cross-build tests on arm64 and other arch patches still. >> This will happen later this week. > > arm64, s390 patches look good. > I am seeing problem with selftests/dma and selfttests/user_events. 1. selftests: dma: Fix incorrect kernel headers search path dma test no longer builds. This test depends on linux/map_benchmark.h which is not included in uapi The order of include directorries -isystem followed by installed kernel headers, breaks the test build with the change to use KHDR_INCLUDES I am going to revert this patch for now and figure a longer term fix. The problem is the dependency on a non-uapi file: linux/map_benchmark.h Fixes: 8ddde07a3d28 ("dma-mapping: benchmark: extract a common header file for map_benchmark definition") change added this dependency on including linux/map_benchmark.h Christoph, Do you see this map_benchmark.h as part of uapi? 2. selftests: user_events: Fix incorrect kernel headers search path This one depends on linux/user_events.h which has bee removed from uapi in this commit: commit 5cfff569cab8bf544bab62c911c5d6efd5af5e05 Author: Steven Rostedt (Google) <rostedt@goodmis.org> Date: Fri Apr 1 14:39:03 2022 -0400 tracing: Move user_events.h temporarily out of include/uapi This isn't a regression from 6.2 - this test stopped building once user_events.h has been removed from uapi. I will add a note that this test depends on a non-uapi header and can't be built at the moment. thanks, -- Shuah ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-11 0:15 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230127135755.79929-1-mathieu.desnoyers@efficios.com> [not found] ` <20230127135755.79929-3-mathieu.desnoyers@efficios.com> 2023-01-30 16:12 ` [PATCH 02/34] selftests: bpf: Fix incorrect kernel headers search path Shuah Khan 2023-01-30 16:26 ` Alexei Starovoitov 2023-01-30 17:00 ` Mathieu Desnoyers 2023-01-30 17:09 ` Shuah Khan [not found] ` <20230127135755.79929-18-mathieu.desnoyers@efficios.com> 2023-01-30 16:24 ` [PATCH 17/34] selftests: net: " Shuah Khan 2023-01-30 22:29 ` [PATCH 00/34] selftests: " Shuah Khan 2023-01-30 23:45 ` Alexei Starovoitov 2023-01-30 23:48 ` Shuah Khan 2023-01-30 23:49 ` Alexei Starovoitov 2023-02-02 2:07 ` Shuah Khan 2023-02-04 1:06 ` Shuah Khan 2023-02-11 0:15 ` Shuah Khan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).