* [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement
@ 2020-11-16 3:42 Randy Dunlap
2020-11-16 9:26 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-11-16 3:42 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, kernel test robot, Jose M . Guisado Gomez,
Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
netfilter-devel, coreteam, Jakub Kicinski
Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
by selecting NF_REJECT_IPV4, which provides the missing symbols.
ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>
Cc: Jose M. Guisado Gomez <guigom@riseup.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
Cc: Jakub Kicinski <kuba@kernel.org>
---
net/bridge/netfilter/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
+++ linux-next-20201113/net/bridge/netfilter/Kconfig
@@ -18,6 +18,7 @@ config NFT_BRIDGE_META
config NFT_BRIDGE_REJECT
tristate "Netfilter nf_tables bridge reject support"
depends on NFT_REJECT
+ depends on NF_REJECT_IPV4
help
Add support to reject packets.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement
2020-11-16 3:42 [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement Randy Dunlap
@ 2020-11-16 9:26 ` Pablo Neira Ayuso
2020-11-16 16:58 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2020-11-16 9:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, kernel test robot, Jose M . Guisado Gomez,
Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
Jakub Kicinski
Hi,
Thanks for catching up this.
On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
> by selecting NF_REJECT_IPV4, which provides the missing symbols.
>
> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>
> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: kernel test robot <lkp@intel.com>
> Cc: Jose M. Guisado Gomez <guigom@riseup.net>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: netfilter-devel@vger.kernel.org
> Cc: coreteam@netfilter.org
> Cc: Jakub Kicinski <kuba@kernel.org>
> ---
> net/bridge/netfilter/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
> config NFT_BRIDGE_REJECT
> tristate "Netfilter nf_tables bridge reject support"
> depends on NFT_REJECT
> + depends on NF_REJECT_IPV4
I can update the patch here before applying to add:
depends on NF_REJECT_IPV6
as well. It seems both dependencies (IPv4 and IPv6) are missing.
Thanks.
> help
> Add support to reject packets.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement
2020-11-16 9:26 ` Pablo Neira Ayuso
@ 2020-11-16 16:58 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-11-16 16:58 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: netdev, kernel test robot, Jose M . Guisado Gomez,
Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
Jakub Kicinski
On 11/16/20 1:26 AM, Pablo Neira Ayuso wrote:
> Hi,
>
> Thanks for catching up this.
>
> On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
>> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
>> by selecting NF_REJECT_IPV4, which provides the missing symbols.
>>
>> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>>
>> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: kernel test robot <lkp@intel.com>
>> Cc: Jose M. Guisado Gomez <guigom@riseup.net>
>> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
>> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
>> Cc: Florian Westphal <fw@strlen.de>
>> Cc: netfilter-devel@vger.kernel.org
>> Cc: coreteam@netfilter.org
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> ---
>> net/bridge/netfilter/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
>> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
>> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
>> config NFT_BRIDGE_REJECT
>> tristate "Netfilter nf_tables bridge reject support"
>> depends on NFT_REJECT
>> + depends on NF_REJECT_IPV4
>
> I can update the patch here before applying to add:
>
> depends on NF_REJECT_IPV6
>
> as well. It seems both dependencies (IPv4 and IPv6) are missing.
>
> Thanks.
>
>> help
>> Add support to reject packets.
>>
Yes, that's good.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-16 16:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 3:42 [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement Randy Dunlap
2020-11-16 9:26 ` Pablo Neira Ayuso
2020-11-16 16:58 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).