[PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[Christophe JAILLET]

UTILITY_NAME_LENGTH is 16. So better use the former when defining the
'utility_name' array. This makes the intent clearer when it is used around
line 260.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 net/caif/cfctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c
index 8480684f2762..b6d9462f92b9 100644
--- a/net/caif/cfctrl.c
+++ b/net/caif/cfctrl.c
@@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer,
 	u8 tmp8;
 	struct cfctrl_request_info *req;
 	int ret;
-	char utility_name[16];
+	char utility_name[UTILITY_NAME_LENGTH];
 	struct cfpkt *pkt;
 	struct cflayer *dn = cfctrl->serv.layer.dn;
 
-- 
2.44.0

Re: [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[Ratheesh Kannoth]

On 2024-03-16 at 15:46:10, Christophe JAILLET (christophe.jaillet@wanadoo.fr) wrote:
> UTILITY_NAME_LENGTH is 16. So better use the former when defining the
> 'utility_name' array. This makes the intent clearer when it is used around
> line 260.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  net/caif/cfctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c
> index 8480684f2762..b6d9462f92b9 100644
> --- a/net/caif/cfctrl.c
> +++ b/net/caif/cfctrl.c
> @@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer,
>  	u8 tmp8;
>  	struct cfctrl_request_info *req;
>  	int ret;
> -	char utility_name[16];
> +	char utility_name[UTILITY_NAME_LENGTH];
Reverse xmas tree.

>  	struct cfpkt *pkt;
>  	struct cflayer *dn = cfctrl->serv.layer.dn;
>
> --
> 2.44.0
>

Re: [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[Dan Carpenter]

On Mon, Mar 18, 2024 at 08:51:33AM +0530, Ratheesh Kannoth wrote:
> On 2024-03-16 at 15:46:10, Christophe JAILLET (christophe.jaillet@wanadoo.fr) wrote:
> > UTILITY_NAME_LENGTH is 16. So better use the former when defining the
> > 'utility_name' array. This makes the intent clearer when it is used around
> > line 260.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  net/caif/cfctrl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c
> > index 8480684f2762..b6d9462f92b9 100644
> > --- a/net/caif/cfctrl.c
> > +++ b/net/caif/cfctrl.c
> > @@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer,
> >  	u8 tmp8;
> >  	struct cfctrl_request_info *req;
> >  	int ret;
> > -	char utility_name[16];
> > +	char utility_name[UTILITY_NAME_LENGTH];
> Reverse xmas tree.
> 

It's always hard to know what to do when the original code isn't in the
correct format.  Someone sent a patch last week which fixed a bug and
partially converted a declaration block into reverse Christmas tree...

regards,
dan carpenter

Re: [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[Christophe JAILLET]

Le 18/03/2024 à 04:21, Ratheesh Kannoth a écrit :
> On 2024-03-16 at 15:46:10, Christophe JAILLET (christophe.jaillet@wanadoo.fr) wrote:
>> UTILITY_NAME_LENGTH is 16. So better use the former when defining the
>> 'utility_name' array. This makes the intent clearer when it is used around
>> line 260.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   net/caif/cfctrl.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c
>> index 8480684f2762..b6d9462f92b9 100644
>> --- a/net/caif/cfctrl.c
>> +++ b/net/caif/cfctrl.c
>> @@ -206,7 +206,7 @@ int cfctrl_linkup_request(struct cflayer *layer,
>>   	u8 tmp8;
>>   	struct cfctrl_request_info *req;
>>   	int ret;
>> -	char utility_name[16];
>> +	char utility_name[UTILITY_NAME_LENGTH];
> Reverse xmas tree.

Hi,

I'll update and repost when net-next is reopened, but honestly, looking 
at this file, changing this to reverse xmas style won't change that much 
for the overall coding style!

Moreover, as said by Dan, it is not really easy to understand the wishes 
of different maintainers. Should I have updated the lay-out, someone 
could have argued that patches should be 1 thing at a time.

CJ

> 
>>   	struct cfpkt *pkt;
>>   	struct cflayer *dn = cfctrl->serv.layer.dn;
>>
>> --
>> 2.44.0
>>
> 
> 

Re: [PATCH] caif: Use UTILITY_NAME_LENGTH instead of hard-coding 16

[Jiri Pirko]

Sat, Mar 16, 2024 at 11:16:10AM CET, christophe.jaillet@wanadoo.fr wrote:
>UTILITY_NAME_LENGTH is 16. So better use the former when defining the
>'utility_name' array. This makes the intent clearer when it is used around
>line 260.
>
>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

This is net-next material, yet net-next is closed.

https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

pw-bot: defer