* [question] About triggering a region snapshot through the devlink cmd
@ 2019-09-27 7:40 Yunsheng Lin
2019-09-27 8:13 ` Jiri Pirko
0 siblings, 1 reply; 6+ messages in thread
From: Yunsheng Lin @ 2019-09-27 7:40 UTC (permalink / raw)
To: jiri, valex; +Cc: davem, netdev, linuxarm
Hi, Jiri & Alex
It seems that a region' snapshot is only created through the
driver when some error is detected, for example:
mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create()
We want to trigger a region' snapshot creation through devlink
cmd, maybe by adding the "devlink region triger", because we want
to check some hardware register/state when the driver or the hardware
does not detect the error sometimes.
Does about "devlink region triger" make sense?
If yes, is there plan to implement it? or any suggestion to implement
it?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [question] About triggering a region snapshot through the devlink cmd
2019-09-27 7:40 [question] About triggering a region snapshot through the devlink cmd Yunsheng Lin
@ 2019-09-27 8:13 ` Jiri Pirko
2019-09-29 12:21 ` Yunsheng Lin
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Pirko @ 2019-09-27 8:13 UTC (permalink / raw)
To: Yunsheng Lin; +Cc: jiri, valex, davem, netdev, linuxarm
Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsheng@huawei.com wrote:
>Hi, Jiri & Alex
>
> It seems that a region' snapshot is only created through the
>driver when some error is detected, for example:
>mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create()
>
> We want to trigger a region' snapshot creation through devlink
>cmd, maybe by adding the "devlink region triger", because we want
>to check some hardware register/state when the driver or the hardware
>does not detect the error sometimes.
>
>Does about "devlink region triger" make sense?
>
>If yes, is there plan to implement it? or any suggestion to implement
>it?
Actually, the plan is co convert mlx4 to "devlink health" api. Mlx5
already uses that.
You should look into "devlink health".
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [question] About triggering a region snapshot through the devlink cmd
2019-09-27 8:13 ` Jiri Pirko
@ 2019-09-29 12:21 ` Yunsheng Lin
0 siblings, 0 replies; 6+ messages in thread
From: Yunsheng Lin @ 2019-09-29 12:21 UTC (permalink / raw)
To: Jiri Pirko; +Cc: jiri, valex, davem, netdev, linuxarm
On 2019/9/27 16:13, Jiri Pirko wrote:
> Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsheng@huawei.com wrote:
>> Hi, Jiri & Alex
>>
>> It seems that a region' snapshot is only created through the
>> driver when some error is detected, for example:
>> mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create()
>>
>> We want to trigger a region' snapshot creation through devlink
>> cmd, maybe by adding the "devlink region triger", because we want
>> to check some hardware register/state when the driver or the hardware
>> does not detect the error sometimes.
>>
>> Does about "devlink region triger" make sense?
>>
>> If yes, is there plan to implement it? or any suggestion to implement
>> it?
>
> Actually, the plan is co convert mlx4 to "devlink health" api. Mlx5
> already uses that.
>
> You should look into "devlink health".
Thanks for mentioning the "devlink health" api.
I has sent a RFC adding the support of the dump hardware mac table.
Please have a look, any comment or suggestion will be very helpful.
>
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [question] About triggering a region snapshot through the devlink cmd
@ 2020-01-07 17:33 Keller, Jacob E
[not found] ` <HE1PR0502MB3771BD83B728249E6C21967AC33E0@HE1PR0502MB3771.eurprd05.prod.outlook.com>
0 siblings, 1 reply; 6+ messages in thread
From: Keller, Jacob E @ 2020-01-07 17:33 UTC (permalink / raw)
To: jiri; +Cc: davem, jiri, linuxarm, linyunsheng, netdev, valex
On 2019/9/27 16:13, Jiri Pirko wrote:
> Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsheng@huawei.com wrote:
>> Hi, Jiri & Alex
>>
>> It seems that a region' snapshot is only created through the
>> driver when some error is detected, for example:
>> mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create()
>>
>> We want to trigger a region' snapshot creation through devlink
>> cmd, maybe by adding the "devlink region triger", because we want
>> to check some hardware register/state when the driver or the hardware
>> does not detect the error sometimes.
>>
>> Does about "devlink region triger" make sense?
>>
>> If yes, is there plan to implement it? or any suggestion to implement
>> it?
>
> Actually, the plan is co convert mlx4 to "devlink health" api. Mlx5
> already uses that.
>
> You should look into "devlink health".
Hi Jiri,
I agree, the mlx4 firmware dump stuff should use the devlink health API, as it's for error conditions.
I've recently been investigating using devlink regions to expose non-error regions where it really does make sense to "trigger" a snapshot.
The original region commit message indicates that there were plans to support requesting snapshots, and even potentially writing to the region directly.
I wanted to use a region to expose some set of flash/NVM contents. Being able to request a snapshot is essential in this case. I saw that netdevsim does this through a debugfs hook, but that really doesn't make sense to me for a production driver.
It makes sense to me to be able to trigger a region snapshot directly through devlink. Should I spin up some patches to implement it?
Thanks,
Jake
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-09 20:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 7:40 [question] About triggering a region snapshot through the devlink cmd Yunsheng Lin
2019-09-27 8:13 ` Jiri Pirko
2019-09-29 12:21 ` Yunsheng Lin
2020-01-07 17:33 Keller, Jacob E
[not found] ` <HE1PR0502MB3771BD83B728249E6C21967AC33E0@HE1PR0502MB3771.eurprd05.prod.outlook.com>
[not found] ` <HE1PR0502MB3771D512C2D23F551EB922F4C33E0@HE1PR0502MB3771.eurprd05.prod.outlook.com>
2020-01-08 19:14 ` FW: " Jacob Keller
2020-01-09 19:41 ` Jakub Kicinski
2020-01-09 20:05 ` Jacob Keller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).