From: Heiner Kallweit <hkallweit1@gmail.com>
To: Chunhao Lin <hau@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, kuba@kernel.org,
grundler@chromium.org
Subject: Re: [PATCH net] r8169: fix rtl8125b dmar pte write access not set error
Date: Sat, 8 Oct 2022 23:53:13 +0200 [thread overview]
Message-ID: <f9657431-68d7-6d38-d140-a69c203808f2@gmail.com> (raw)
In-Reply-To: <20221004081037.34064-1-hau@realtek.com>
On 04.10.2022 10:10, Chunhao Lin wrote:
> When close device, rx will be enabled if wol is enabeld. When open device
> it will cause rx to dma to wrong address after pci_set_master().
>
> In this patch, driver will disable tx/rx when close device. If wol is
> eanbled only enable rx filter and disable rxdv_gate to let hardware
> can receive packet to fifo but not to dma it.
>
> Fixes: 120068481405 ("r8169: fix failing WoL")
> Signed-off-by: Chunhao Lin <hau@realtek.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 1b7fdb4f056b..c09cfbe1d3f0 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -2239,6 +2239,9 @@ static void rtl_wol_enable_rx(struct rtl8169_private *tp)
> if (tp->mac_version >= RTL_GIGA_MAC_VER_25)
> RTL_W32(tp, RxConfig, RTL_R32(tp, RxConfig) |
> AcceptBroadcast | AcceptMulticast | AcceptMyPhys);
> +
> + if (tp->mac_version >= RTL_GIGA_MAC_VER_40)
> + RTL_W32(tp, MISC, RTL_R32(tp, MISC) & ~RXDV_GATED_EN);
Wouldn't this be sufficient? Why is the change to rtl8169_cleanup() needed?
> }
>
> static void rtl_prepare_power_down(struct rtl8169_private *tp)
> @@ -3981,7 +3984,7 @@ static void rtl8169_tx_clear(struct rtl8169_private *tp)
> netdev_reset_queue(tp->dev);
> }
>
> -static void rtl8169_cleanup(struct rtl8169_private *tp, bool going_down)
> +static void rtl8169_private (struct rtl8169_private *tp)
> {
> napi_disable(&tp->napi);
>
> @@ -3993,9 +3996,6 @@ static void rtl8169_cleanup(struct rtl8169_private *tp, bool going_down)
>
> rtl_rx_close(tp);
>
> - if (going_down && tp->dev->wol_enabled)
> - goto no_reset;
> -
> switch (tp->mac_version) {
> case RTL_GIGA_MAC_VER_28:
> case RTL_GIGA_MAC_VER_31:
> @@ -4016,7 +4016,7 @@ static void rtl8169_cleanup(struct rtl8169_private *tp, bool going_down)
> }
>
> rtl_hw_reset(tp);
> -no_reset:
> +
> rtl8169_tx_clear(tp);
> rtl8169_init_ring_indexes(tp);
> }
> @@ -4027,7 +4027,7 @@ static void rtl_reset_work(struct rtl8169_private *tp)
>
> netif_stop_queue(tp->dev);
>
> - rtl8169_cleanup(tp, false);
> + rtl8169_cleanup(tp);
>
> for (i = 0; i < NUM_RX_DESC; i++)
> rtl8169_mark_to_asic(tp->RxDescArray + i);
> @@ -4715,7 +4715,7 @@ static void rtl8169_down(struct rtl8169_private *tp)
> pci_clear_master(tp->pci_dev);
> rtl_pci_commit(tp);
>
> - rtl8169_cleanup(tp, true);
> + rtl8169_cleanup(tp);
> rtl_disable_exit_l1(tp);
> rtl_prepare_power_down(tp);
> }
next prev parent reply other threads:[~2022-10-08 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 8:10 [PATCH net] r8169: fix rtl8125b dmar pte write access not set error Chunhao Lin
2022-10-04 20:14 ` Heiner Kallweit
2022-10-05 5:44 ` Hau
2022-10-05 16:29 ` Heiner Kallweit
2022-10-06 14:23 ` Hau
2022-10-08 21:53 ` Heiner Kallweit [this message]
2022-10-09 7:45 ` Heiner Kallweit
2022-10-12 7:59 ` Hau
2022-10-12 19:33 ` Heiner Kallweit
2022-10-13 6:04 ` Hau
2022-10-15 8:18 ` Heiner Kallweit
2022-10-17 17:23 ` Hau
2022-10-17 19:38 ` Heiner Kallweit
2022-10-20 18:01 ` Hau
2022-10-24 18:02 ` Hau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9657431-68d7-6d38-d140-a69c203808f2@gmail.com \
--to=hkallweit1@gmail.com \
--cc=grundler@chromium.org \
--cc=hau@realtek.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).