From: Florian Westphal <fw@strlen.de>
To: Todd Seidelmann <tseidelmann@linode.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: ebtables: Fix argument order to ADD_COUNTER
Date: Tue, 13 Aug 2019 15:29:00 +0200 [thread overview]
Message-ID: <20190813132900.o73rfe3h6vag7pdv@breakpoint.cc> (raw)
In-Reply-To: <0330b679-4649-df92-f0d7-a0b5c7dcc87d@linode.com>
Todd Seidelmann <tseidelmann@linode.com> wrote:
> The ordering of arguments to the x_tables ADD_COUNTER macro
> appears to be wrong in ebtables (cf. ip_tables.c, ip6_tables.c,
> and arp_tables.c).
>
> This causes data corruption in the ebtables userspace tools
> because they get incorrect packet & byte counts from the kernel.
Please resend with a 'Signed-off-by' tag and the
'Fixes:' tag that I provided when I reviewd this patch.
It will help stable maintainers to figure out which trees
need this fix applied.
next prev parent reply other threads:[~2019-08-13 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:22 [PATCH nf] netfilter: ebtables: Fix argument order to ADD_COUNTER Todd Seidelmann
2019-08-13 13:29 ` Florian Westphal [this message]
2019-08-14 14:54 Todd Seidelmann
2019-08-14 14:54 ` Florian Westphal
2019-08-19 10:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813132900.o73rfe3h6vag7pdv@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=tseidelmann@linode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).