Netfilter-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success
@ 2020-05-11 21:33 Maciej Żenczykowski
  2020-05-14 12:25 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Maciej Żenczykowski @ 2020-05-11 21:33 UTC (permalink / raw)
  To: Maciej Żenczykowski, Pablo Neira Ayuso, Florian Westphal
  Cc: Linux Network Development Mailing List,
	Netfilter Development Mailing List

From: Maciej Żenczykowski <maze@google.com>

This looks like an oversight which is easy to fix.

Furthermore:
  git grep ';;OK'
does not find any other matches, so this is the last unverified test case.

Test:
  [root@f32vm IPT]# uname -r
  5.6.10-300.fc32.x86_64

  [root@f32vm IPT]# md5sum extensions/libip6t_srh.t
  b98864bdd6c39a0dd96022c47e652edb  extensions/libip6t_srh.t

  [root@f32vm IPT]# ./iptables-test.py extensions/libip6t_srh.t
  extensions/libip6t_srh.t: OK
  1 test files, 27 unit tests, 27 passed

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 extensions/libip6t_srh.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/extensions/libip6t_srh.t b/extensions/libip6t_srh.t
index 07b54031..5b02a71b 100644
--- a/extensions/libip6t_srh.t
+++ b/extensions/libip6t_srh.t
@@ -23,6 +23,6 @@
 -m srh ! --srh-tag 0;=;OK
 -m srh --srh-next-hdr 17 --srh-segs-left-eq 1 --srh-last-entry-eq 4 --srh-tag 0;=;OK
 -m srh ! --srh-next-hdr 17 ! --srh-segs-left-eq 0 --srh-tag 0;=;OK
--m srh --srh-psid A::/64 --srh-nsid B:: --srh-lsid C::/0;;OK
--m srh ! --srh-psid A::/64 ! --srh-nsid B:: ! --srh-lsid C::/0;;OK
+-m srh --srh-psid a::/64 --srh-nsid b::/128 --srh-lsid c::/0;=;OK
+-m srh ! --srh-psid a::/64 ! --srh-nsid b::/128 ! --srh-lsid c::/0;=;OK
 -m srh;=;OK
-- 
2.26.2.645.ge9eca65c58-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success
  2020-05-11 21:33 [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success Maciej Żenczykowski
@ 2020-05-14 12:25 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-05-14 12:25 UTC (permalink / raw)
  To: Maciej Żenczykowski
  Cc: Maciej Żenczykowski, Florian Westphal,
	Linux Network Development Mailing List,
	Netfilter Development Mailing List

On Mon, May 11, 2020 at 02:33:49PM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> This looks like an oversight which is easy to fix.

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 21:33 [PATCH] libip6t_srh.t: switch to lowercase, add /128 suffix, require success Maciej Żenczykowski
2020-05-14 12:25 ` Pablo Neira Ayuso

Netfilter-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \
		netfilter-devel@vger.kernel.org
	public-inbox-index netfilter-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git