From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>, greg.depoire@gmail.com
Subject: Re: [Nouveau] [RFC v3 00/10] drm: Extract DPCD backlight helpers from i915, add support in nouveau
Date: Mon, 08 Feb 2021 17:52:52 -0500 [thread overview]
Message-ID: <b8353198b93e9935fb08bd4187f009264210504a.camel@redhat.com> (raw)
In-Reply-To: <20210205234515.1216538-1-lyude@redhat.com>
thanks for the review comments everyone! I'm going through them now but realized
I should probably point out that I somehow sent this patch series and did not
realize I did so in the middle of a rebase, and as such completely forgot the
parts here that actually started using these helpers in nouveau. lol....
anyway-will fix when I sent out the respin today
On Fri, 2021-02-05 at 18:45 -0500, Lyude Paul wrote:
> This series:
> * Cleans up i915's DPCD backlight code a little bit
> * Extracts i915's DPCD backlight code into a set of shared DRM helpers
> * Starts using those helpers in nouveau to add support to nouveau for
> DPCD backlight control
>
> v2 series-wide changes:
> * Rebase
> v3 series-wide changes:
> * Split up the changes to intel's backlight code into separate patches
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Dave Airlie <airlied@gmail.com>
> Cc: greg.depoire@gmail.com
>
> Lyude Paul (10):
> drm/nouveau/kms/nv40-/backlight: Assign prop type once
> drm/nouveau/kms: Don't probe eDP connectors more then once
> drm/i915/dpcd_bl: Remove redundant AUX backlight frequency
> calculations
> drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly
> drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit
> drm/i915/dpcd_bl: Cache some backlight capabilities in
> intel_panel.backlight
> drm/i915/dpcd_bl: Move VESA backlight enabling code closer together
> drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't
> read PWMGEN_BIT_COUNT
> drm/i915/dpcd_bl: Print return codes for VESA backlight failures
> drm/dp: Extract i915's eDP backlight code into DRM helpers
>
> drivers/gpu/drm/drm_dp_helper.c | 332 ++++++++++++++++++
> .../drm/i915/display/intel_display_types.h | 2 +-
> .../drm/i915/display/intel_dp_aux_backlight.c | 329 +++--------------
> drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_connector.c | 6 +
> include/drm/drm_dp_helper.h | 48 +++
> 6 files changed, 428 insertions(+), 293 deletions(-)
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
prev parent reply other threads:[~2021-02-08 22:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 23:45 [Nouveau] [RFC v3 00/10] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 01/10] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 02/10] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 03/10] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 04/10] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly Lyude Paul
2021-02-08 11:11 ` Rodrigo Vivi
2021-02-05 23:45 ` [Nouveau] [RFC v3 05/10] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit Lyude Paul
2021-02-06 0:07 ` Ilia Mirkin
2021-02-05 23:45 ` [Nouveau] [RFC v3 06/10] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight Lyude Paul
2021-02-08 11:13 ` Rodrigo Vivi
2021-02-05 23:45 ` [Nouveau] [RFC v3 07/10] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together Lyude Paul
2021-02-08 11:14 ` Rodrigo Vivi
2021-02-05 23:45 ` [Nouveau] [RFC v3 08/10] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 09/10] drm/i915/dpcd_bl: Print return codes for VESA backlight failures Lyude Paul
2021-02-05 23:45 ` [Nouveau] [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-08 8:46 ` Thomas Zimmermann
2021-02-08 23:03 ` Lyude Paul
2021-02-15 18:34 ` Thomas Zimmermann
2021-02-15 20:26 ` Lyude Paul
2021-02-08 22:52 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8353198b93e9935fb08bd4187f009264210504a.camel@redhat.com \
--to=lyude@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg.depoire@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).