nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: 'Dan Williams' <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: RE: [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon
Date: Mon, 2 Apr 2018 00:10:25 +0000	[thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3222764B881@g01jpexmbkw01> (raw)
In-Reply-To: <CAPcyv4gVxw8OCnm0PsbC0PrBxpUBupvkK=w4L4p=gWQRsk4ouQ@mail.gmail.com>

> >>
> >> This seems to needlessly tie ndctl to systemd, it should be able to
> >> operate without requiring systemd. I expect it would be
> >> straightforward to copy the configuration file implementation from git.
> >
> > Would you like to explain why it should be able to operate without requiring
> systemd?
> 
> systemd is not universally available in all distributions and it is useful to have custom
> configuration files for manually started daemons.
> 
> Another consideration is that a sub-set of monitoring activities can be done without
> root privileges. It would be unforunate if a user could not specify changes to the
> configuration because those files are root-only and owned by systemd.
> 
> > The reason we want to add the configuration file is that when starting
> > the monitors by systemd, options and arguments cannot be passed by systemd.
> > When we start monitors by using "# ndctl monitor" command, we do not
> > need any configuration files, because options and arguments can be added
> directly.
> >
> > Furthermore, if we choose configuration file implementation, we may encounter
> the following problem.
> > If we start the monitor with command like "# ndctl monitor --dimm
> > nmem1 --daemon --conf-file /etc/ndctl.conf", when the variable of dimm
> > in configuration file is not the same as the argument of [--dimm] option, which
> argument should the filter_dimm() refer to?
> 
> The command line option should union with the configuration file for filtering options.
> I.e. if the config file says to monitor nmem0 and the command line says to monitor
> nmem1 then the tool should monitor both. If there are other settings the might be
> in conflict then command line should override the configuration file.
> 
> This matches the policy of most daemons that I have encountered in Linux.

OK, I see. Thank you very much.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-04-02  0:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 11:33 [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon QI Fuli
2018-03-14 18:19 ` Dan Williams
2018-03-15 10:41   ` Qi, Fuli
2018-03-16  1:03     ` Dan Williams
2018-03-16  7:33       ` Yasunori Goto
2018-03-16 10:01         ` Qi, Fuli
2018-03-16  6:55   ` Yasunori Goto
2018-03-16 13:28     ` Dan Williams
2018-03-17  0:23       ` Yasunori Goto
2018-03-19 11:27   ` Qi, Fuli
2018-03-19 14:27     ` Dan Williams
2018-03-20  1:03       ` Qi, Fuli
2018-03-29 10:02   ` Qi, Fuli
2018-03-29 22:59     ` Dan Williams
2018-03-30  7:34       ` Qi, Fuli
2018-03-30 16:34         ` Dan Williams
2018-04-02  0:10           ` Qi, Fuli [this message]
2018-04-05 23:17       ` Qi, Fuli
2018-04-06 19:02         ` Dan Williams
2018-04-09  8:38           ` Qi, Fuli
2018-04-09 17:45             ` Dan Williams
2018-04-10  2:15               ` Qi, Fuli
2018-04-10  3:06               ` Verma, Vishal L
2018-04-04 14:28     ` Jeff Moyer
2018-04-05 21:08       ` Qi, Fuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0DEDF3B159719A448A49EF0E7B11E3222764B881@g01jpexmbkw01 \
    --to=qi.fuli@jp.fujitsu.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).