From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon
Date: Fri, 16 Mar 2018 15:55:18 +0900 [thread overview]
Message-ID: <20180316155515.7293.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <CAPcyv4jPghKyQ6AuVJ-R=fiKcQufzHs-DExzcyHTbshF-2bq1Q@mail.gmail.com>
Hi,
> > +static void log_syslog(struct ndctl_ctx *ctx, int priority, const char *file,
> > + int line, const char *fn, const char *format, va_list args)
> > +{
> > + char *buf = (char *)malloc(BUF_SIZE);
> > + vsnprintf(buf, BUF_SIZE, format, args);
> > + syslog(priority, "%s", buf);
> > + free(buf);
> > +}
>
> This seems to be reinventing setting up a log file that I'm sure we
> could borrow or link to...
>
> ndctl borrows heavily from git, and git does logging in it's daemon.c,
> I'd be happier if you copied that.
Maybe silly question...., but is it OK about OSS lisence?
In my understanding, basically the lisence of git is GPL2,
LGPL is used just for use xdiff/ or some libc code in git....
https://github.com/git/git/blob/master/COPYING
https://github.com/git/git/blob/master/LGPL-2.1
However, the lisence of ndctl is LGPL2.1
https://github.com/pmem/ndctl/blob/master/COPYING
If we copied from git to ndctl, then I suppose that ndctl
daemon may have to use GPL2 rather than LGPL2.1, right?
Bye,
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-03-16 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 11:33 [RFC PATCH v4] ndctl: monitor: add ndctl monitor daemon QI Fuli
2018-03-14 18:19 ` Dan Williams
2018-03-15 10:41 ` Qi, Fuli
2018-03-16 1:03 ` Dan Williams
2018-03-16 7:33 ` Yasunori Goto
2018-03-16 10:01 ` Qi, Fuli
2018-03-16 6:55 ` Yasunori Goto [this message]
2018-03-16 13:28 ` Dan Williams
2018-03-17 0:23 ` Yasunori Goto
2018-03-19 11:27 ` Qi, Fuli
2018-03-19 14:27 ` Dan Williams
2018-03-20 1:03 ` Qi, Fuli
2018-03-29 10:02 ` Qi, Fuli
2018-03-29 22:59 ` Dan Williams
2018-03-30 7:34 ` Qi, Fuli
2018-03-30 16:34 ` Dan Williams
2018-04-02 0:10 ` Qi, Fuli
2018-04-05 23:17 ` Qi, Fuli
2018-04-06 19:02 ` Dan Williams
2018-04-09 8:38 ` Qi, Fuli
2018-04-09 17:45 ` Dan Williams
2018-04-10 2:15 ` Qi, Fuli
2018-04-10 3:06 ` Verma, Vishal L
2018-04-04 14:28 ` Jeff Moyer
2018-04-05 21:08 ` Qi, Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316155515.7293.E1E9C6FF@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).