* [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent
@ 2018-07-30 19:35 Vishal Verma
2018-07-31 2:05 ` Qi, Fuli
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Verma @ 2018-07-30 19:35 UTC (permalink / raw)
To: linux-nvdimm
Change the inject-smart field from -s to -m when testing the
dimm-media-temperature event. The -s seems to have been a copy-paste
error.
Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
test/monitor.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/monitor.sh b/test/monitor.sh
index 1bbfd14..29d4ea1 100755
--- a/test/monitor.sh
+++ b/test/monitor.sh
@@ -152,7 +152,7 @@ test_filter_dimmevent()
inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r .[]."health"."temperature_threshold")
inject_value=$((inject_value + 1))
start_monitor "-d $monitor_dimms -D dimm-media-temperature"
- inject_smart "-s $inject_value"
+ inject_smart "-m $inject_value"
check_result "$monitor_dimms"
stop_monitor
}
--
2.14.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent
2018-07-30 19:35 [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent Vishal Verma
@ 2018-07-31 2:05 ` Qi, Fuli
0 siblings, 0 replies; 2+ messages in thread
From: Qi, Fuli @ 2018-07-31 2:05 UTC (permalink / raw)
To: 'Vishal Verma', linux-nvdimm
> -----Original Message-----
> From: Vishal Verma [mailto:vishal.l.verma@intel.com]
> Sent: Tuesday, July 31, 2018 4:35 AM
> To: linux-nvdimm@lists.01.org
> Cc: Vishal Verma <vishal.l.verma@intel.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>
> Subject: [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in
> test_filter_dimmevent
>
> Change the inject-smart field from -s to -m when testing the dimm-media-temperature
> event. The -s seems to have been a copy-paste error.
>
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> test/monitor.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/monitor.sh b/test/monitor.sh index 1bbfd14..29d4ea1 100755
> --- a/test/monitor.sh
> +++ b/test/monitor.sh
> @@ -152,7 +152,7 @@ test_filter_dimmevent()
> inject_value=$($NDCTL list -H -d $monitor_dimms | jq
> -r .[]."health"."temperature_threshold")
> inject_value=$((inject_value + 1))
> start_monitor "-d $monitor_dimms -D dimm-media-temperature"
> - inject_smart "-s $inject_value"
> + inject_smart "-m $inject_value"
> check_result "$monitor_dimms"
> stop_monitor
> }
Hi Vishal,
Yes, this is a copy-paste error and I am sorry for this.
Thank you very much.
QI
> --
> 2.14.4
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-31 2:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 19:35 [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent Vishal Verma
2018-07-31 2:05 ` Qi, Fuli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).