Re: [ndctl V5 4/4] Use page size as alignment value

Re: [ndctl V5 4/4] Use page size as alignment value

[Verma, Vishal L]

On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote:
> On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote:
> > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k,
> > the default page size on x86. Change those to the default page size on that
> > architecture (sysconf/getconf). No functional changes otherwise.
> > 
> > Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> > ---
> >  test/dpa-alloc.c    | 15 ++++++++-------
> >  test/multi-dax.sh   |  6 ++++--
> >  test/sector-mode.sh |  4 +++-
> >  3 files changed, 15 insertions(+), 10 deletions(-)
> 
> Thanks for the updates, these look good - I've applied them and pushed
> out on 'pending'.
> 
> 
Hi Santosh,

Dan noticed that this patch[1] got dropped from the series - just
making sure that was intentional?

Thanks,
-Vishal

Re: [ndctl V5 4/4] Use page size as alignment value

[Verma, Vishal L]

On Wed, 2021-05-26 at 19:31 +0000, Verma, Vishal L wrote:
> On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote:
> > On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote:
> > > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k,
> > > the default page size on x86. Change those to the default page size on that
> > > architecture (sysconf/getconf). No functional changes otherwise.
> > > 
> > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> > > ---
> > >  test/dpa-alloc.c    | 15 ++++++++-------
> > >  test/multi-dax.sh   |  6 ++++--
> > >  test/sector-mode.sh |  4 +++-
> > >  3 files changed, 15 insertions(+), 10 deletions(-)
> > 
> > Thanks for the updates, these look good - I've applied them and pushed
> > out on 'pending'.
> > 
> > 
> Hi Santosh,
> 
> Dan noticed that this patch[1] got dropped from the series - just
> making sure that was intentional?

Oops, hit send too early.

[1]: https://lore.kernel.org/linux-nvdimm/20201222042516.2984348-4-santosh@fossix.org/

> 
> Thanks,
> -Vishal

Re: [ndctl V5 4/4] Use page size as alignment value

[Santosh Sivaraj]

"Verma, Vishal L" <vishal.l.verma@intel.com> writes:
Hi Vishal,

> On Wed, 2021-05-26 at 19:31 +0000, Verma, Vishal L wrote:
>> On Thu, 2021-05-13 at 18:17 +0000, Verma, Vishal L wrote:
>> > On Thu, 2021-05-13 at 11:42 +0530, Santosh Sivaraj wrote:
>> > > The alignment sizes passed to ndctl in the tests are all hardcoded to 4k,
>> > > the default page size on x86. Change those to the default page size on that
>> > > architecture (sysconf/getconf). No functional changes otherwise.
>> > > 
>> > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
>> > > ---
>> > >  test/dpa-alloc.c    | 15 ++++++++-------
>> > >  test/multi-dax.sh   |  6 ++++--
>> > >  test/sector-mode.sh |  4 +++-
>> > >  3 files changed, 15 insertions(+), 10 deletions(-)
>> > 
>> > Thanks for the updates, these look good - I've applied them and pushed
>> > out on 'pending'.
>> > 
>> > 
>> Hi Santosh,
>> 
>> Dan noticed that this patch[1] got dropped from the series - just
>> making sure that was intentional?

Yes, that's right. It is intentional. The support SMART test cases are
here[1] sent by Shiva, which I have combined with error injection test and sent
as one patch series.

[1]: https://lkml.kernel.org/r/20210517084259.181236-1-santosh@fossix.org

Thanks,
Santosh
>
> Oops, hit send too early.
>
> [1]: https://lore.kernel.org/linux-nvdimm/20201222042516.2984348-4-santosh@fossix.org/
>
>> 
>> Thanks,
>> -Vishal