From: Kees Cook <kees@kernel.org>
To: kernel test robot <lkp@intel.com>,
Azeem Shaikh <azeemshaikh38@gmail.com>,
Maxim Krasnyansky <maxk@qti.qualcomm.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy
Date: Tue, 30 May 2023 21:41:25 -0700 [thread overview]
Message-ID: <09A0C6FA-669F-4B73-9620-43AEA17E5D0C@kernel.org> (raw)
In-Reply-To: <202305311135.zGMT1gYR-lkp@intel.com>
On May 30, 2023 8:18:42 PM PDT, kernel test robot <lkp@intel.com> wrote:
>Hi Azeem,
>
>kernel test robot noticed the following build errors:
>
>[auto build test ERROR on uml/next]
>[also build test ERROR on uml/fixes wireless-next/main wireless/main linus/master v6.4-rc4 next-20230530]
>[If your patch is applied to the wrong git tree, kindly drop us a note.
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
>url: https://github.com/intel-lab-lkp/linux/commits/Azeem-Shaikh/uml-Replace-all-non-returning-strlcpy-with-strscpy/20230531-004115
>base: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux next
>patch link: https://lore.kernel.org/r/20230530164004.986750-1-azeemshaikh38%40gmail.com
>patch subject: [PATCH] uml: Replace all non-returning strlcpy with strscpy
>config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230531/202305311135.zGMT1gYR-lkp@intel.com/config)
>compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>reproduce (this is a W=1 build):
> # https://github.com/intel-lab-lkp/linux/commit/c51d7beb37cfbda321feb3811bbe0e381f804899
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Azeem-Shaikh/uml-Replace-all-non-returning-strlcpy-with-strscpy/20230531-004115
> git checkout c51d7beb37cfbda321feb3811bbe0e381f804899
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=um SUBARCH=i386 olddefconfig
> make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
>
>If you fix the issue, kindly add following tag where applicable
>| Reported-by: kernel test robot <lkp@intel.com>
>| Closes: https://lore.kernel.org/oe-kbuild-all/202305311135.zGMT1gYR-lkp@intel.com/
>
>All errors (new ones prefixed by >>):
>
> arch/um/os-Linux/drivers/tuntap_user.c: In function 'tuntap_open':
>>> arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of function 'strscpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration]
> 149 | strscpy(ifr.ifr_name, pri->dev_name, sizeof(ifr.ifr_name));
> | ^~~~~~~
> | strncpy
> cc1: some warnings being treated as errors
Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this strlcpy for now.
-Keed
--
Kees Cook
next prev parent reply other threads:[~2023-05-31 4:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230530164004.986750-1-azeemshaikh38@gmail.com>
2023-05-31 3:18 ` [PATCH] uml: Replace all non-returning strlcpy with strscpy kernel test robot
2023-05-31 4:41 ` Kees Cook [this message]
2023-05-31 6:18 ` Johannes Berg
2023-05-31 6:26 ` Richard Weinberger
2023-05-31 6:23 ` Richard Weinberger
2023-05-31 8:05 ` Geert Uytterhoeven
2023-05-31 14:48 ` Azeem Shaikh
2023-06-05 20:07 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09A0C6FA-669F-4B73-9620-43AEA17E5D0C@kernel.org \
--to=kees@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=azeemshaikh38@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=lkp@intel.com \
--cc=maxk@qti.qualcomm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).