From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Richard Weinberger <richard@nod.at>
Cc: Kees Cook <kees@kernel.org>,
Azeem Shaikh <azeemshaikh38@gmail.com>,
kernel test robot <lkp@intel.com>,
Maxim Krasnyansky <maxk@qti.qualcomm.com>,
oe-kbuild-all <oe-kbuild-all@lists.linux.dev>,
linux-hardening@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um <linux-um@lists.infradead.org>
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy
Date: Wed, 31 May 2023 10:05:03 +0200 [thread overview]
Message-ID: <CAMuHMdU70uRxnMNb8KCJe8M3BRPPxowRXtj+POcrh+KLkfQyAA@mail.gmail.com> (raw)
In-Reply-To: <103925562.158061.1685514200368.JavaMail.zimbra@nod.at>
On Wed, May 31, 2023 at 8:23 AM Richard Weinberger <richard@nod.at> wrote:
> ----- Ursprüngliche Mail -----
> >>>> arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of
> >>>> function 'strscpy'; did you mean 'strncpy'?
> >>>> [-Werror=implicit-function-declaration]
> >> 149 | strscpy(ifr.ifr_name, pri->dev_name,
> >> sizeof(ifr.ifr_name));
> >> | ^~~~~~~
> >> | strncpy
> >> cc1: some warnings being treated as errors
> >
> > Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this
> > strlcpy for now.
>
> Well, actually it's another case of "not even compile tested". :-(
"But the AI said it was correct?!?" ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-05-31 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230530164004.986750-1-azeemshaikh38@gmail.com>
2023-05-31 3:18 ` [PATCH] uml: Replace all non-returning strlcpy with strscpy kernel test robot
2023-05-31 4:41 ` Kees Cook
2023-05-31 6:18 ` Johannes Berg
2023-05-31 6:26 ` Richard Weinberger
2023-05-31 6:23 ` Richard Weinberger
2023-05-31 8:05 ` Geert Uytterhoeven [this message]
2023-05-31 14:48 ` Azeem Shaikh
2023-06-05 20:07 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU70uRxnMNb8KCJe8M3BRPPxowRXtj+POcrh+KLkfQyAA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=azeemshaikh38@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=lkp@intel.com \
--cc=maxk@qti.qualcomm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).