Re: [PATCH v1 RFC Zisslpcfi 09/20] riscv mmu: riscv shadow stack page fault handling

Re: [PATCH v1 RFC Zisslpcfi 09/20] riscv mmu: riscv shadow stack page fault handling

[kernel test robot]

Hi Deepak,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on kees/for-next/execve]
[also build test WARNING on linus/master arnd-asm-generic/master v6.2-rc8]
[cannot apply to next-20230213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Deepak-Gupta/sslp-stubs-shadow-stack-and-landing-pad-stubs/20230213-125630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve
patch link:    https://lore.kernel.org/r/20230213045351.3945824-10-debug%40rivosinc.com
patch subject: [PATCH v1 RFC Zisslpcfi 09/20] riscv mmu: riscv shadow stack page fault handling
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230214/202302140351.iqujxGOS-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5bc0c094c6a280c8b4f16d7db053873e5c4fb5aa
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Deepak-Gupta/sslp-stubs-shadow-stack-and-landing-pad-stubs/20230213-125630
        git checkout 5bc0c094c6a280c8b4f16d7db053873e5c4fb5aa
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302140351.iqujxGOS-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/riscv/kernel/traps.c:101:6: warning: no previous prototype for 'is_ss_load_store_insn' [-Wmissing-prototypes]
     101 | bool is_ss_load_store_insn(unsigned long insn)
         |      ^~~~~~~~~~~~~~~~~~~~~
>> arch/riscv/kernel/traps.c:115:7: warning: no previous prototype for 'get_instruction' [-Wmissing-prototypes]
     115 | ulong get_instruction(ulong epc)
         |       ^~~~~~~~~~~~~~~


vim +/is_ss_load_store_insn +101 arch/riscv/kernel/traps.c

   100	
 > 101	bool is_ss_load_store_insn(unsigned long insn)
   102	{
   103		if ((insn & SS_PUSH_POP) == SS_PUSH_POP)
   104			return true;
   105		/*
   106		 * SS_AMOSWAP overlaps with LP_S_LL.
   107		 * But LP_S_LL can never raise access fault
   108		 */
   109		if ((insn & SS_AMOSWAP) == SS_AMOSWAP)
   110			return true;
   111	
   112		return false;
   113	}
   114	
 > 115	ulong get_instruction(ulong epc)
   116	{
   117		ulong *epc_ptr = (ulong *) epc;
   118		ulong insn = 0;
   119	
   120		__enable_user_access();
   121		insn = *epc_ptr;
   122		__disable_user_access();
   123		return insn;
   124	}
   125	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests