From: kernel test robot <lkp@intel.com>
To: Dmitry Safonov <dima@arista.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
Dmitry Safonov <dima@arista.com>,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
Salam Noureddine <noureddine@arista.com>
Subject: Re: [PATCH v4 05/21] net/tcp: Calculate TCP-AO traffic keys
Date: Thu, 16 Feb 2023 06:50:49 +0800 [thread overview]
Message-ID: <202302160619.lvY45Sx5-lkp@intel.com> (raw)
In-Reply-To: <20230215183335.800122-6-dima@arista.com>
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on e1c04510f521e853019afeca2a5991a5ef8d6a5b]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836
base: e1c04510f521e853019afeca2a5991a5ef8d6a5b
patch link: https://lore.kernel.org/r/20230215183335.800122-6-dima%40arista.com
patch subject: [PATCH v4 05/21] net/tcp: Calculate TCP-AO traffic keys
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230216/202302160619.lvY45Sx5-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e93c86e7edccffd9992748d03591579a4ebc2731
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836
git checkout e93c86e7edccffd9992748d03591579a4ebc2731
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302160619.lvY45Sx5-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/ipv4/tcp_ao.c:59:20: warning: no previous prototype for 'tcp_ao_matched_key' [-Wmissing-prototypes]
59 | struct tcp_ao_key *tcp_ao_matched_key(struct tcp_ao_info *ao,
| ^~~~~~~~~~~~~~~~~~
>> net/ipv4/tcp_ao.c:245:5: warning: no previous prototype for 'tcp_ao_calc_key_sk' [-Wmissing-prototypes]
245 | int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
| ^~~~~~~~~~~~~~~~~~
vim +/tcp_ao_calc_key_sk +245 net/ipv4/tcp_ao.c
244
> 245 int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
246 const struct sock *sk,
247 __be32 sisn, __be32 disn,
248 bool send)
249 {
250 if (mkt->family == AF_INET)
251 return tcp_v4_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
252 else
253 return tcp_v6_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
254 }
255
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
parent reply other threads:[~2023-02-15 22:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230215183335.800122-6-dima@arista.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302160619.lvY45Sx5-lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).