Re: [PATCH 2/2] tracing/hist: add modulus operator

Re: [PATCH 2/2] tracing/hist: add modulus operator

[kernel test robot]

Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on rostedt-trace/for-next v6.2 next-20230302]
[cannot apply to rostedt-trace/for-next-urgent]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mark-Rutland/tracing-hist-simplify-contains_operator/20230303-012033
patch link:    https://lore.kernel.org/r/20230302171755.1821653-3-mark.rutland%40arm.com
patch subject: [PATCH 2/2] tracing/hist: add modulus operator
config: i386-randconfig-a016 (https://download.01.org/0day-ci/archive/20230303/202303030527.tCXUA4Xo-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/a2602e97de77834320fed5f928662f154f72d7ce
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mark-Rutland/tracing-hist-simplify-contains_operator/20230303-012033
        git checkout a2602e97de77834320fed5f928662f154f72d7ce
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303030527.tCXUA4Xo-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: kernel/trace/trace_events_hist.o: in function `hist_field_mod':
>> kernel/trace/trace_events_hist.c:454: undefined reference to `__umoddi3'


vim +454 kernel/trace/trace_events_hist.c

   441	
   442	static u64 hist_field_mod(struct hist_field *hist_field,
   443				  struct tracing_map_elt *elt,
   444				  struct trace_buffer *buffer,
   445				  struct ring_buffer_event *rbe,
   446				  void *event)
   447	{
   448		struct hist_field *operand1 = hist_field->operands[0];
   449		struct hist_field *operand2 = hist_field->operands[1];
   450	
   451		u64 val1 = hist_fn_call(operand1, elt, buffer, rbe, event);
   452		u64 val2 = hist_fn_call(operand2, elt, buffer, rbe, event);
   453	
 > 454		return val1 % val2;
   455	}
   456	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [PATCH 2/2] tracing/hist: add modulus operator

[kernel test robot]

Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on rostedt-trace/for-next v6.2 next-20230303]
[cannot apply to rostedt-trace/for-next-urgent]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mark-Rutland/tracing-hist-simplify-contains_operator/20230303-012033
patch link:    https://lore.kernel.org/r/20230302171755.1821653-3-mark.rutland%40arm.com
patch subject: [PATCH 2/2] tracing/hist: add modulus operator
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230303/202303032025.sa7xWAu3-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/a2602e97de77834320fed5f928662f154f72d7ce
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mark-Rutland/tracing-hist-simplify-contains_operator/20230303-012033
        git checkout a2602e97de77834320fed5f928662f154f72d7ce
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303032025.sa7xWAu3-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: kernel/trace/trace_events_hist.o: in function `hist_fn_call':
>> trace_events_hist.c:(.text+0xa007): undefined reference to `__umoddi3'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests