Re: [RFC 12/12] module: use aliases to find module on find_module_all()

From: kernel test robot <lkp@intel.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC 12/12] module: use aliases to find module on find_module_all()
Date: Sun, 12 Mar 2023 01:06:52 +0800	[thread overview]
Message-ID: <202303120005.XZm2NRcW-lkp@intel.com> (raw)
In-Reply-To: <20230311051712.4095040-13-mcgrof@kernel.org>

Hi Luis,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mcgrof/modules-next]
[also build test ERROR on linus/master v6.3-rc1 next-20230310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luis-Chamberlain/module-use-goto-errors-on-check_modinfo-and-layout_and_allocate/20230311-131905
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
patch link:    https://lore.kernel.org/r/20230311051712.4095040-13-mcgrof%40kernel.org
patch subject: [RFC 12/12] module: use aliases to find module on find_module_all()
config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20230312/202303120005.XZm2NRcW-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d92029475386e6bbbea10a2f56a87d37e61a2b38
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Luis-Chamberlain/module-use-goto-errors-on-check_modinfo-and-layout_and_allocate/20230311-131905
        git checkout d92029475386e6bbbea10a2f56a87d37e61a2b38
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303120005.XZm2NRcW-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/module/main.c:351:21: error: no member named 'num_aliases' in 'struct module'
           for (i=0; i < mod->num_aliases; i++) {
                         ~~~  ^
>> kernel/module/main.c:352:16: error: no member named 'aliases' in 'struct module'
                   alias = mod->aliases[i];
                           ~~~  ^
   2 errors generated.

vim +351 kernel/module/main.c

   340	
   341	static bool module_name_match(struct module *mod, const char *name, size_t len)
   342	{
   343		unsigned int i;
   344		const char *alias;
   345	
   346		if (strlen(mod->name) == len && !memcmp(mod->name, name, len))
   347			return true;
   348	
   349		return module_name_match_aliases(mod, name, len);
   350	
 > 351		for (i=0; i < mod->num_aliases; i++) {
 > 352			alias = mod->aliases[i];
   353			if (strlen(alias) == len && !memcmp(alias, name, len)) {
   354				pr_debug("module %s alias matched: alias[%u] = %s\n",
   355					 mod->name, i, alias);
   356				return true;
   357			}
   358		}
   359	
   360		return false;
   361	}
   362	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests