oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [android-common:android12-trusty-5.10 1/1] drivers/trusty/trusty-log.c:678:9: warning: no previous prototype for 'trusty_log_sfile_dev_read'
@ 2023-03-14  1:42 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-14  1:42 UTC (permalink / raw)
  To: cros-kernel-buildreports; +Cc: oe-kbuild-all

tree:   https://android.googlesource.com/kernel/common android12-trusty-5.10
head:   2cb5328839ee3dede473b095b8d8e4c8371c44e5
commit: 2cb5328839ee3dede473b095b8d8e4c8371c44e5 [1/1] ANDROID: trusty-log: fix potential use-after-free
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230314/202303140923.6NrZ0Yfy-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add android-common https://android.googlesource.com/kernel/common
        git fetch --no-tags android-common android12-trusty-5.10
        git checkout 2cb5328839ee3dede473b095b8d8e4c8371c44e5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303140923.6NrZ0Yfy-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/trusty/trusty-log.c: In function 'trusty_log_seq_next':
   drivers/trusty/trusty-log.c:455:21: warning: left shift count >= width of type [-Wshift-count-overflow]
     455 |         *pos = (1UL << 32) + log_sfile_sink->get;
         |                     ^~
   drivers/trusty/trusty-log.c: At top level:
>> drivers/trusty/trusty-log.c:678:9: warning: no previous prototype for 'trusty_log_sfile_dev_read' [-Wmissing-prototypes]
     678 | ssize_t trusty_log_sfile_dev_read(struct file *filp, char __user *buf,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/trusty_log_sfile_dev_read +678 drivers/trusty/trusty-log.c

   677	
 > 678	ssize_t trusty_log_sfile_dev_read(struct file *filp, char __user *buf,
   679					  size_t size, loff_t *ppos)
   680	{
   681		struct seq_file *sfile;
   682		struct trusty_log_sfile *lb;
   683		struct trusty_log_state *s;
   684	
   685		sfile = filp->private_data;
   686		lb = sfile->private;
   687		s = container_of(lb, struct trusty_log_state, log_sfile);
   688	
   689		if (!s->registered) {
   690			dev_err(s->dev, "invalid read fd\n");
   691			return -EINVAL;
   692		}
   693	
   694		return seq_read(filp, buf, size, ppos);
   695	}
   696	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-14  1:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14  1:42 [android-common:android12-trusty-5.10 1/1] drivers/trusty/trusty-log.c:678:9: warning: no previous prototype for 'trusty_log_sfile_dev_read' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).