oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [jimc:dd-drm-fix-next 2/20] lib/dynamic_debug.c:1315:5: warning: no previous prototype for function 'ddebug_remove_module'
@ 2023-03-18  6:37 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-03-18  6:37 UTC (permalink / raw)
  To: Jim Cromie; +Cc: oe-kbuild-all

tree:   https://github.com/jimc/linux.git dd-drm-fix-next
head:   cd23709c1ee6c57c8cee65dd371c3c03bd8d3220
commit: 6d401a03e8e7c163a40988faf567cf9d25ec8665 [2/20] dyndbg: use the module notifier callbacks
config: i386-randconfig-a014-20230313 (https://download.01.org/0day-ci/archive/20230318/202303181437.B9xpvXNJ-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jimc/linux/commit/6d401a03e8e7c163a40988faf567cf9d25ec8665
        git remote add jimc https://github.com/jimc/linux.git
        git fetch --no-tags jimc dd-drm-fix-next
        git checkout 6d401a03e8e7c163a40988faf567cf9d25ec8665
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303181437.B9xpvXNJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> lib/dynamic_debug.c:1315:5: warning: no previous prototype for function 'ddebug_remove_module' [-Wmissing-prototypes]
   int ddebug_remove_module(const char *mod_name)
       ^
   lib/dynamic_debug.c:1315:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ddebug_remove_module(const char *mod_name)
   ^
   static 
   1 warning generated.


vim +/ddebug_remove_module +1315 lib/dynamic_debug.c

e9d376f0fa66bd Jason Baron      2009-02-05  1310  
e9d376f0fa66bd Jason Baron      2009-02-05  1311  /*
e9d376f0fa66bd Jason Baron      2009-02-05  1312   * Called in response to a module being unloaded.  Removes
e9d376f0fa66bd Jason Baron      2009-02-05  1313   * any ddebug_table's which point at the module.
e9d376f0fa66bd Jason Baron      2009-02-05  1314   */
ff49d74ad383f5 Yehuda Sadeh     2010-07-03 @1315  int ddebug_remove_module(const char *mod_name)
e9d376f0fa66bd Jason Baron      2009-02-05  1316  {
e9d376f0fa66bd Jason Baron      2009-02-05  1317  	struct ddebug_table *dt, *nextdt;
e9d376f0fa66bd Jason Baron      2009-02-05  1318  	int ret = -ENOENT;
e9d376f0fa66bd Jason Baron      2009-02-05  1319  
e9d376f0fa66bd Jason Baron      2009-02-05  1320  	mutex_lock(&ddebug_lock);
e9d376f0fa66bd Jason Baron      2009-02-05  1321  	list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) {
4573fe15437c90 Rasmus Villemoes 2019-03-07  1322  		if (dt->mod_name == mod_name) {
e9d376f0fa66bd Jason Baron      2009-02-05  1323  			ddebug_table_free(dt);
e9d376f0fa66bd Jason Baron      2009-02-05  1324  			ret = 0;
4573fe15437c90 Rasmus Villemoes 2019-03-07  1325  			break;
e9d376f0fa66bd Jason Baron      2009-02-05  1326  		}
e9d376f0fa66bd Jason Baron      2009-02-05  1327  	}
e9d376f0fa66bd Jason Baron      2009-02-05  1328  	mutex_unlock(&ddebug_lock);
7a5e202dfb8ab7 Jim Cromie       2021-10-13  1329  	if (!ret)
7a5e202dfb8ab7 Jim Cromie       2021-10-13  1330  		v2pr_info("removed module \"%s\"\n", mod_name);
e9d376f0fa66bd Jason Baron      2009-02-05  1331  	return ret;
e9d376f0fa66bd Jason Baron      2009-02-05  1332  }
e9d376f0fa66bd Jason Baron      2009-02-05  1333  

:::::: The code at line 1315 was first introduced by commit
:::::: ff49d74ad383f54041378144ca1a229ee9aeaa59 module: initialize module dynamic debug later

:::::: TO: Yehuda Sadeh <yehuda@hq.newdream.net>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [jimc:dd-drm-fix-next 2/20] lib/dynamic_debug.c:1315:5: warning: no previous prototype for function 'ddebug_remove_module'
@ 2023-02-18 22:24 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-02-18 22:24 UTC (permalink / raw)
  To: Jim Cromie; +Cc: oe-kbuild-all

tree:   https://github.com/jimc/linux.git dd-drm-fix-next
head:   23def6f5fa9da6a03e232b4368bfa5908d7e3194
commit: cf693cfaeb0eb6df6fb46cfd8f9c168c708596d4 [2/20] dyndbg: use the module notifier callbacks
config: arm-randconfig-r014-20230219 (https://download.01.org/0day-ci/archive/20230219/202302190642.KXfTMWCt-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/jimc/linux/commit/cf693cfaeb0eb6df6fb46cfd8f9c168c708596d4
        git remote add jimc https://github.com/jimc/linux.git
        git fetch --no-tags jimc dd-drm-fix-next
        git checkout cf693cfaeb0eb6df6fb46cfd8f9c168c708596d4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302190642.KXfTMWCt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> lib/dynamic_debug.c:1315:5: warning: no previous prototype for function 'ddebug_remove_module' [-Wmissing-prototypes]
   int ddebug_remove_module(const char *mod_name)
       ^
   lib/dynamic_debug.c:1315:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ddebug_remove_module(const char *mod_name)
   ^
   static 
   1 warning generated.


vim +/ddebug_remove_module +1315 lib/dynamic_debug.c

e9d376f0fa66bd Jason Baron      2009-02-05  1310  
e9d376f0fa66bd Jason Baron      2009-02-05  1311  /*
e9d376f0fa66bd Jason Baron      2009-02-05  1312   * Called in response to a module being unloaded.  Removes
e9d376f0fa66bd Jason Baron      2009-02-05  1313   * any ddebug_table's which point at the module.
e9d376f0fa66bd Jason Baron      2009-02-05  1314   */
ff49d74ad383f5 Yehuda Sadeh     2010-07-03 @1315  int ddebug_remove_module(const char *mod_name)
e9d376f0fa66bd Jason Baron      2009-02-05  1316  {
e9d376f0fa66bd Jason Baron      2009-02-05  1317  	struct ddebug_table *dt, *nextdt;
e9d376f0fa66bd Jason Baron      2009-02-05  1318  	int ret = -ENOENT;
e9d376f0fa66bd Jason Baron      2009-02-05  1319  
e9d376f0fa66bd Jason Baron      2009-02-05  1320  	mutex_lock(&ddebug_lock);
e9d376f0fa66bd Jason Baron      2009-02-05  1321  	list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) {
4573fe15437c90 Rasmus Villemoes 2019-03-07  1322  		if (dt->mod_name == mod_name) {
e9d376f0fa66bd Jason Baron      2009-02-05  1323  			ddebug_table_free(dt);
e9d376f0fa66bd Jason Baron      2009-02-05  1324  			ret = 0;
4573fe15437c90 Rasmus Villemoes 2019-03-07  1325  			break;
e9d376f0fa66bd Jason Baron      2009-02-05  1326  		}
e9d376f0fa66bd Jason Baron      2009-02-05  1327  	}
e9d376f0fa66bd Jason Baron      2009-02-05  1328  	mutex_unlock(&ddebug_lock);
7a5e202dfb8ab7 Jim Cromie       2021-10-13  1329  	if (!ret)
7a5e202dfb8ab7 Jim Cromie       2021-10-13  1330  		v2pr_info("removed module \"%s\"\n", mod_name);
e9d376f0fa66bd Jason Baron      2009-02-05  1331  	return ret;
e9d376f0fa66bd Jason Baron      2009-02-05  1332  }
e9d376f0fa66bd Jason Baron      2009-02-05  1333  

:::::: The code at line 1315 was first introduced by commit
:::::: ff49d74ad383f54041378144ca1a229ee9aeaa59 module: initialize module dynamic debug later

:::::: TO: Yehuda Sadeh <yehuda@hq.newdream.net>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-18  6:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-18  6:37 [jimc:dd-drm-fix-next 2/20] lib/dynamic_debug.c:1315:5: warning: no previous prototype for function 'ddebug_remove_module' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-02-18 22:24 kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).