From: kernel test robot <lkp@intel.com>
To: "jingle.wu" <jingle.wu@emc.com.tw>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com
Cc: oe-kbuild-all@lists.linux.dev, phoenix@emc.com.tw,
josh.chen@emc.com.tw, dave.wang@emc.com.tw,
"jingle.wu" <jingle.wu@emc.com.tw>
Subject: Re: [PATCH] Input: elan_i2c - Implement inhibit/uninhibit functions.
Date: Sun, 19 Mar 2023 10:17:00 +0800 [thread overview]
Message-ID: <202303191024.mbwWRV3A-lkp@intel.com> (raw)
In-Reply-To: <20230317071646.977357-1-jingle.wu@emc.com.tw>
Hi jingle.wu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus hid/for-next linus/master v6.3-rc2 next-20230317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/jingle-wu/Input-elan_i2c-Implement-inhibit-uninhibit-functions/20230317-152004
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20230317071646.977357-1-jingle.wu%40emc.com.tw
patch subject: [PATCH] Input: elan_i2c - Implement inhibit/uninhibit functions.
config: nios2-randconfig-m031-20230319 (https://download.01.org/0day-ci/archive/20230319/202303191024.mbwWRV3A-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303191024.mbwWRV3A-lkp@intel.com/
smatch warnings:
drivers/input/mouse/elan_i2c_core.c:342 elan_reactivate() warn: inconsistent indenting
vim +342 drivers/input/mouse/elan_i2c_core.c
331
332 static int elan_reactivate(struct elan_tp_data *data)
333 {
334 struct device *dev = &data->client->dev;
335 int ret;
336
337 ret = elan_set_power(data, true);
338 if (ret)
339 dev_err(dev, "failed to restore power: %d\n", ret);
340
341 ret = data->ops->sleep_control(data->client, false);
> 342 if (ret) {
343 dev_err(dev,
344 "failed to wake device up: %d\n", ret);
345 return ret;
346 }
347
348 return ret;
349 }
350
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
parent reply other threads:[~2023-03-19 2:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230317071646.977357-1-jingle.wu@emc.com.tw>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303191024.mbwWRV3A-lkp@intel.com \
--to=lkp@intel.com \
--cc=dave.wang@emc.com.tw \
--cc=dmitry.torokhov@gmail.com \
--cc=jingle.wu@emc.com.tw \
--cc=josh.chen@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=phoenix@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).