* drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting
@ 2023-03-21 5:01 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-03-21 5:01 UTC (permalink / raw)
To: Ranjan Kumar
Cc: oe-kbuild-all, linux-kernel, Martin K. Petersen, Sreekanth Reddy
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 17214b70a159c6547df9ae204a6275d983146f6b
commit: 8e45183978d64699df639e795235433a60f35047 scsi: mpi3mr: Bad drive in topology results kernel crash
date: 2 weeks ago
config: riscv-randconfig-m031-20230319 (https://download.01.org/0day-ci/archive/20230321/202303211202.uf1kNr2C-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303211202.uf1kNr2C-lkp@intel.com/
New smatch warnings:
drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting
Old smatch warnings:
drivers/scsi/mpi3mr/mpi3mr_transport.c:2064 mpi3mr_expander_add() warn: returning -1 instead of -ENOMEM is sloppy
vim +2365 drivers/scsi/mpi3mr/mpi3mr_transport.c
7f56c791969e0c Sreekanth Reddy 2022-08-04 2304
7f56c791969e0c Sreekanth Reddy 2022-08-04 2305 /**
7f56c791969e0c Sreekanth Reddy 2022-08-04 2306 * mpi3mr_report_tgtdev_to_sas_transport - expose dev to SAS TL
7f56c791969e0c Sreekanth Reddy 2022-08-04 2307 * @mrioc: Adapter instance reference
7f56c791969e0c Sreekanth Reddy 2022-08-04 2308 * @tgtdev: Target device
7f56c791969e0c Sreekanth Reddy 2022-08-04 2309 *
7f56c791969e0c Sreekanth Reddy 2022-08-04 2310 * This function exposes the target device after
7f56c791969e0c Sreekanth Reddy 2022-08-04 2311 * preparing host_phy, setting up link rate etc.
7f56c791969e0c Sreekanth Reddy 2022-08-04 2312 *
7f56c791969e0c Sreekanth Reddy 2022-08-04 2313 * Return: 0 on success, non-zero for failure.
7f56c791969e0c Sreekanth Reddy 2022-08-04 2314 */
7f56c791969e0c Sreekanth Reddy 2022-08-04 2315 int mpi3mr_report_tgtdev_to_sas_transport(struct mpi3mr_ioc *mrioc,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2316 struct mpi3mr_tgt_dev *tgtdev)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2317 {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2318 int retval = 0;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2319 u8 link_rate, parent_phy_number;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2320 u64 sas_address_parent, sas_address;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2321 struct mpi3mr_hba_port *hba_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2322 u8 port_id;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2323
7f56c791969e0c Sreekanth Reddy 2022-08-04 2324 if ((tgtdev->dev_type != MPI3_DEVICE_DEVFORM_SAS_SATA) ||
7f56c791969e0c Sreekanth Reddy 2022-08-04 2325 !mrioc->sas_transport_enabled)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2326 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2327
7f56c791969e0c Sreekanth Reddy 2022-08-04 2328 sas_address = tgtdev->dev_spec.sas_sata_inf.sas_address;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2329 if (!mrioc->sas_hba.num_phys)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2330 mpi3mr_sas_host_add(mrioc);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2331 else
7f56c791969e0c Sreekanth Reddy 2022-08-04 2332 mpi3mr_sas_host_refresh(mrioc);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2333
7f56c791969e0c Sreekanth Reddy 2022-08-04 2334 if (mpi3mr_get_sas_address(mrioc, tgtdev->parent_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2335 &sas_address_parent) != 0) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2336 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
7f56c791969e0c Sreekanth Reddy 2022-08-04 2337 __FILE__, __LINE__, __func__);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2338 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2339 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2340 tgtdev->dev_spec.sas_sata_inf.sas_address_parent = sas_address_parent;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2341
7f56c791969e0c Sreekanth Reddy 2022-08-04 2342 parent_phy_number = tgtdev->dev_spec.sas_sata_inf.phy_id;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2343 port_id = tgtdev->io_unit_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2344
7f56c791969e0c Sreekanth Reddy 2022-08-04 2345 hba_port = mpi3mr_get_hba_port_by_id(mrioc, port_id);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2346 if (!hba_port) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2347 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
7f56c791969e0c Sreekanth Reddy 2022-08-04 2348 __FILE__, __LINE__, __func__);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2349 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2350 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2351 tgtdev->dev_spec.sas_sata_inf.hba_port = hba_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2352
7f56c791969e0c Sreekanth Reddy 2022-08-04 2353 link_rate = mpi3mr_get_sas_negotiated_logical_linkrate(mrioc, tgtdev);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2354
7f56c791969e0c Sreekanth Reddy 2022-08-04 2355 mpi3mr_update_links(mrioc, sas_address_parent, tgtdev->dev_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2356 parent_phy_number, link_rate, hba_port);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2357
7f56c791969e0c Sreekanth Reddy 2022-08-04 2358 tgtdev->host_exposed = 1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2359 if (!mpi3mr_sas_port_add(mrioc, tgtdev->dev_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2360 sas_address_parent, hba_port)) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2361 retval = -1;
8e45183978d646 Ranjan Kumar 2023-02-28 2362 } else if ((!tgtdev->starget) && (!mrioc->is_driver_loading)) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2363 mpi3mr_sas_port_remove(mrioc, sas_address,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2364 sas_address_parent, hba_port);
7f56c791969e0c Sreekanth Reddy 2022-08-04 @2365 retval = -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2366 }
8e45183978d646 Ranjan Kumar 2023-02-28 2367 if (retval) {
8e45183978d646 Ranjan Kumar 2023-02-28 2368 tgtdev->dev_spec.sas_sata_inf.hba_port = NULL;
8e45183978d646 Ranjan Kumar 2023-02-28 2369 tgtdev->host_exposed = 0;
8e45183978d646 Ranjan Kumar 2023-02-28 2370 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2371 return retval;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2372 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2373
:::::: The code at line 2365 was first introduced by commit
:::::: 7f56c791969e0c19b8b5ee12058b636bf173eb90 scsi: mpi3mr: Add SAS SATA end devices to STL
:::::: TO: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting
@ 2023-10-05 5:33 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-10-05 5:33 UTC (permalink / raw)
To: Ranjan Kumar
Cc: oe-kbuild-all, linux-kernel, Martin K. Petersen, Sreekanth Reddy
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3006adf3be79cde4d14b1800b963b82b6e5572e0
commit: 8e45183978d64699df639e795235433a60f35047 scsi: mpi3mr: Bad drive in topology results kernel crash
date: 7 months ago
config: x86_64-randconfig-161-20231005 (https://download.01.org/0day-ci/archive/20231005/202310051319.KRYast5J-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20231005/202310051319.KRYast5J-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310051319.KRYast5J-lkp@intel.com/
New smatch warnings:
drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting
Old smatch warnings:
drivers/scsi/mpi3mr/mpi3mr_transport.c:2064 mpi3mr_expander_add() warn: returning -1 instead of -ENOMEM is sloppy
vim +2365 drivers/scsi/mpi3mr/mpi3mr_transport.c
7f56c791969e0c Sreekanth Reddy 2022-08-04 2304
7f56c791969e0c Sreekanth Reddy 2022-08-04 2305 /**
7f56c791969e0c Sreekanth Reddy 2022-08-04 2306 * mpi3mr_report_tgtdev_to_sas_transport - expose dev to SAS TL
7f56c791969e0c Sreekanth Reddy 2022-08-04 2307 * @mrioc: Adapter instance reference
7f56c791969e0c Sreekanth Reddy 2022-08-04 2308 * @tgtdev: Target device
7f56c791969e0c Sreekanth Reddy 2022-08-04 2309 *
7f56c791969e0c Sreekanth Reddy 2022-08-04 2310 * This function exposes the target device after
7f56c791969e0c Sreekanth Reddy 2022-08-04 2311 * preparing host_phy, setting up link rate etc.
7f56c791969e0c Sreekanth Reddy 2022-08-04 2312 *
7f56c791969e0c Sreekanth Reddy 2022-08-04 2313 * Return: 0 on success, non-zero for failure.
7f56c791969e0c Sreekanth Reddy 2022-08-04 2314 */
7f56c791969e0c Sreekanth Reddy 2022-08-04 2315 int mpi3mr_report_tgtdev_to_sas_transport(struct mpi3mr_ioc *mrioc,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2316 struct mpi3mr_tgt_dev *tgtdev)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2317 {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2318 int retval = 0;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2319 u8 link_rate, parent_phy_number;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2320 u64 sas_address_parent, sas_address;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2321 struct mpi3mr_hba_port *hba_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2322 u8 port_id;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2323
7f56c791969e0c Sreekanth Reddy 2022-08-04 2324 if ((tgtdev->dev_type != MPI3_DEVICE_DEVFORM_SAS_SATA) ||
7f56c791969e0c Sreekanth Reddy 2022-08-04 2325 !mrioc->sas_transport_enabled)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2326 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2327
7f56c791969e0c Sreekanth Reddy 2022-08-04 2328 sas_address = tgtdev->dev_spec.sas_sata_inf.sas_address;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2329 if (!mrioc->sas_hba.num_phys)
7f56c791969e0c Sreekanth Reddy 2022-08-04 2330 mpi3mr_sas_host_add(mrioc);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2331 else
7f56c791969e0c Sreekanth Reddy 2022-08-04 2332 mpi3mr_sas_host_refresh(mrioc);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2333
7f56c791969e0c Sreekanth Reddy 2022-08-04 2334 if (mpi3mr_get_sas_address(mrioc, tgtdev->parent_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2335 &sas_address_parent) != 0) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2336 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
7f56c791969e0c Sreekanth Reddy 2022-08-04 2337 __FILE__, __LINE__, __func__);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2338 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2339 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2340 tgtdev->dev_spec.sas_sata_inf.sas_address_parent = sas_address_parent;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2341
7f56c791969e0c Sreekanth Reddy 2022-08-04 2342 parent_phy_number = tgtdev->dev_spec.sas_sata_inf.phy_id;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2343 port_id = tgtdev->io_unit_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2344
7f56c791969e0c Sreekanth Reddy 2022-08-04 2345 hba_port = mpi3mr_get_hba_port_by_id(mrioc, port_id);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2346 if (!hba_port) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2347 ioc_err(mrioc, "failure at %s:%d/%s()!\n",
7f56c791969e0c Sreekanth Reddy 2022-08-04 2348 __FILE__, __LINE__, __func__);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2349 return -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2350 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2351 tgtdev->dev_spec.sas_sata_inf.hba_port = hba_port;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2352
7f56c791969e0c Sreekanth Reddy 2022-08-04 2353 link_rate = mpi3mr_get_sas_negotiated_logical_linkrate(mrioc, tgtdev);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2354
7f56c791969e0c Sreekanth Reddy 2022-08-04 2355 mpi3mr_update_links(mrioc, sas_address_parent, tgtdev->dev_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2356 parent_phy_number, link_rate, hba_port);
7f56c791969e0c Sreekanth Reddy 2022-08-04 2357
7f56c791969e0c Sreekanth Reddy 2022-08-04 2358 tgtdev->host_exposed = 1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2359 if (!mpi3mr_sas_port_add(mrioc, tgtdev->dev_handle,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2360 sas_address_parent, hba_port)) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2361 retval = -1;
8e45183978d646 Ranjan Kumar 2023-02-28 2362 } else if ((!tgtdev->starget) && (!mrioc->is_driver_loading)) {
7f56c791969e0c Sreekanth Reddy 2022-08-04 2363 mpi3mr_sas_port_remove(mrioc, sas_address,
7f56c791969e0c Sreekanth Reddy 2022-08-04 2364 sas_address_parent, hba_port);
7f56c791969e0c Sreekanth Reddy 2022-08-04 @2365 retval = -1;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2366 }
8e45183978d646 Ranjan Kumar 2023-02-28 2367 if (retval) {
8e45183978d646 Ranjan Kumar 2023-02-28 2368 tgtdev->dev_spec.sas_sata_inf.hba_port = NULL;
8e45183978d646 Ranjan Kumar 2023-02-28 2369 tgtdev->host_exposed = 0;
8e45183978d646 Ranjan Kumar 2023-02-28 2370 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2371 return retval;
7f56c791969e0c Sreekanth Reddy 2022-08-04 2372 }
7f56c791969e0c Sreekanth Reddy 2022-08-04 2373
:::::: The code at line 2365 was first introduced by commit
:::::: 7f56c791969e0c19b8b5ee12058b636bf173eb90 scsi: mpi3mr: Add SAS SATA end devices to STL
:::::: TO: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-05 5:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 5:01 drivers/scsi/mpi3mr/mpi3mr_transport.c:2365 mpi3mr_report_tgtdev_to_sas_transport() warn: inconsistent indenting kernel test robot
2023-10-05 5:33 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).