* [linux-stable-rc:queue/5.15 10/14] drivers/interconnect/qcom/icc-rpmh.c:221:9: error: implicit declaration of function 'icc_provider_init'; did you mean 'icc_provider_del'?
@ 2023-03-23 6:03 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-23 6:03 UTC (permalink / raw)
To: Johan Hovold; +Cc: oe-kbuild-all, Sasha Levin, Konrad Dybcio, Georgi Djakov
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.15
head: 63f11815ccc27da754b99f5819faf19077089d30
commit: 80bc2d12ba3ae13f5baf85f247042996d4af209d [10/14] interconnect: qcom: rpmh: fix registration race
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230323/202303231314.2m0ACuNY-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=80bc2d12ba3ae13f5baf85f247042996d4af209d
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc queue/5.15
git checkout 80bc2d12ba3ae13f5baf85f247042996d4af209d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303231314.2m0ACuNY-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/interconnect/qcom/icc-rpmh.c: In function 'qcom_icc_rpmh_probe':
>> drivers/interconnect/qcom/icc-rpmh.c:221:9: error: implicit declaration of function 'icc_provider_init'; did you mean 'icc_provider_del'? [-Werror=implicit-function-declaration]
221 | icc_provider_init(provider);
| ^~~~~~~~~~~~~~~~~
| icc_provider_del
>> drivers/interconnect/qcom/icc-rpmh.c:257:15: error: implicit declaration of function 'icc_provider_register'; did you mean 'icc_provider_del'? [-Werror=implicit-function-declaration]
257 | ret = icc_provider_register(provider);
| ^~~~~~~~~~~~~~~~~~~~~
| icc_provider_del
drivers/interconnect/qcom/icc-rpmh.c: In function 'qcom_icc_rpmh_remove':
>> drivers/interconnect/qcom/icc-rpmh.c:276:9: error: implicit declaration of function 'icc_provider_deregister'; did you mean 'icc_provider_del'? [-Werror=implicit-function-declaration]
276 | icc_provider_deregister(&qp->provider);
| ^~~~~~~~~~~~~~~~~~~~~~~
| icc_provider_del
cc1: some warnings being treated as errors
vim +221 drivers/interconnect/qcom/icc-rpmh.c
185
186 int qcom_icc_rpmh_probe(struct platform_device *pdev)
187 {
188 const struct qcom_icc_desc *desc;
189 struct device *dev = &pdev->dev;
190 struct icc_onecell_data *data;
191 struct icc_provider *provider;
192 struct qcom_icc_node **qnodes, *qn;
193 struct qcom_icc_provider *qp;
194 struct icc_node *node;
195 size_t num_nodes, i, j;
196 int ret;
197
198 desc = of_device_get_match_data(dev);
199 if (!desc)
200 return -EINVAL;
201
202 qnodes = desc->nodes;
203 num_nodes = desc->num_nodes;
204
205 qp = devm_kzalloc(dev, sizeof(*qp), GFP_KERNEL);
206 if (!qp)
207 return -ENOMEM;
208
209 data = devm_kzalloc(dev, struct_size(data, nodes, num_nodes), GFP_KERNEL);
210 if (!data)
211 return -ENOMEM;
212
213 provider = &qp->provider;
214 provider->dev = dev;
215 provider->set = qcom_icc_set;
216 provider->pre_aggregate = qcom_icc_pre_aggregate;
217 provider->aggregate = qcom_icc_aggregate;
218 provider->xlate_extended = qcom_icc_xlate_extended;
219 provider->data = data;
220
> 221 icc_provider_init(provider);
222
223 qp->dev = dev;
224 qp->bcms = desc->bcms;
225 qp->num_bcms = desc->num_bcms;
226
227 qp->voter = of_bcm_voter_get(qp->dev, NULL);
228 if (IS_ERR(qp->voter))
229 return PTR_ERR(qp->voter);
230
231 for (i = 0; i < qp->num_bcms; i++)
232 qcom_icc_bcm_init(qp->bcms[i], dev);
233
234 for (i = 0; i < num_nodes; i++) {
235 qn = qnodes[i];
236 if (!qn)
237 continue;
238
239 node = icc_node_create(qn->id);
240 if (IS_ERR(node)) {
241 ret = PTR_ERR(node);
242 goto err_remove_nodes;
243 }
244
245 node->name = qn->name;
246 node->data = qn;
247 icc_node_add(node, provider);
248
249 for (j = 0; j < qn->num_links; j++)
250 icc_link_create(node, qn->links[j]);
251
252 data->nodes[i] = node;
253 }
254
255 data->num_nodes = num_nodes;
256
> 257 ret = icc_provider_register(provider);
258 if (ret)
259 goto err_remove_nodes;
260
261 platform_set_drvdata(pdev, qp);
262
263 return 0;
264
265 err_remove_nodes:
266 icc_nodes_remove(provider);
267
268 return ret;
269 }
270 EXPORT_SYMBOL_GPL(qcom_icc_rpmh_probe);
271
272 int qcom_icc_rpmh_remove(struct platform_device *pdev)
273 {
274 struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
275
> 276 icc_provider_deregister(&qp->provider);
277 icc_nodes_remove(&qp->provider);
278
279 return 0;
280 }
281 EXPORT_SYMBOL_GPL(qcom_icc_rpmh_remove);
282
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-23 6:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 6:03 [linux-stable-rc:queue/5.15 10/14] drivers/interconnect/qcom/icc-rpmh.c:221:9: error: implicit declaration of function 'icc_provider_init'; did you mean 'icc_provider_del'? kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).