Re: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info

Re: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info

[kernel test robot]

Hi Krzysztof,

kernel test robot noticed the following build warnings:

[auto build test WARNING on sre-power-supply/for-next]
[also build test WARNING on linus/master v6.3-rc5 next-20230406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Krzysztof-Kozlowski/power-supply-hwmon-constify-pointers-to-hwmon_channel_info/20230407-231258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20230407150326.80183-1-krzysztof.kozlowski%40linaro.org
patch subject: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230408/202304080128.dlkdpYww-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/54a815cb7128a140e1a6e18ef6bbafa22b98aadf
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Krzysztof-Kozlowski/power-supply-hwmon-constify-pointers-to-hwmon_channel_info/20230407-231258
        git checkout 54a815cb7128a140e1a6e18ef6bbafa22b98aadf
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/power/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304080128.dlkdpYww-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/power/supply/power_supply_hwmon.c:324:17: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     324 |         .info = power_supply_hwmon_info,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~


vim +/const +324 drivers/power/supply/power_supply_hwmon.c

e67d4dfc9ff19d Andrey Smirnov 2019-06-12  321  
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  322  static const struct hwmon_chip_info power_supply_hwmon_chip_info = {
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  323  	.ops = &power_supply_hwmon_ops,
e67d4dfc9ff19d Andrey Smirnov 2019-06-12 @324  	.info = power_supply_hwmon_info,
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  325  };
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  326  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info

[kernel test robot]

Hi Krzysztof,

kernel test robot noticed the following build errors:

[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on linus/master v6.3-rc5 next-20230406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Krzysztof-Kozlowski/power-supply-hwmon-constify-pointers-to-hwmon_channel_info/20230407-231258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20230407150326.80183-1-krzysztof.kozlowski%40linaro.org
patch subject: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel_info
config: x86_64-randconfig-a003-20230403 (https://download.01.org/0day-ci/archive/20230408/202304080217.3MDH0o8U-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/54a815cb7128a140e1a6e18ef6bbafa22b98aadf
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Krzysztof-Kozlowski/power-supply-hwmon-constify-pointers-to-hwmon_channel_info/20230407-231258
        git checkout 54a815cb7128a140e1a6e18ef6bbafa22b98aadf
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304080217.3MDH0o8U-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/power/supply/power_supply_hwmon.c:324:10: error: initializing 'const struct hwmon_channel_info **' with an expression of type 'const struct hwmon_channel_info *const[4]' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           .info = power_supply_hwmon_info,
                   ^~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +324 drivers/power/supply/power_supply_hwmon.c

e67d4dfc9ff19d Andrey Smirnov 2019-06-12  321  
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  322  static const struct hwmon_chip_info power_supply_hwmon_chip_info = {
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  323  	.ops = &power_supply_hwmon_ops,
e67d4dfc9ff19d Andrey Smirnov 2019-06-12 @324  	.info = power_supply_hwmon_info,
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  325  };
e67d4dfc9ff19d Andrey Smirnov 2019-06-12  326  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests