oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [stable:linux-5.15.y 9393/9999] arch/um/drivers/virt-pci.c:644:9: error: implicit declaration of function 'virtio_reset_device'; did you mean 'virtio_break_device'?
@ 2023-04-10 15:03 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-04-10 15:03 UTC (permalink / raw)
  To: Benjamin Berg
  Cc: oe-kbuild-all, Greg Kroah-Hartman, Richard Weinberger, Sasha Levin

Hi Benjamin,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.15.y
head:   d86dfc4d95cd218246b10ca7adf22c8626547599
commit: a27e95a6ff3fd633422ca44c6d571ef84392f5b8 [9393/9999] um: virt-pci: properly remove PCI device from bus
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20230410/202304102242.uAOzWxHJ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=a27e95a6ff3fd633422ca44c6d571ef84392f5b8
        git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
        git fetch --no-tags stable linux-5.15.y
        git checkout a27e95a6ff3fd633422ca44c6d571ef84392f5b8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um olddefconfig
        make W=1 O=build_dir ARCH=um SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304102242.uAOzWxHJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/um/drivers/virt-pci.c: In function 'um_pci_virtio_remove':
>> arch/um/drivers/virt-pci.c:644:9: error: implicit declaration of function 'virtio_reset_device'; did you mean 'virtio_break_device'? [-Werror=implicit-function-declaration]
     644 |         virtio_reset_device(vdev);
         |         ^~~~~~~~~~~~~~~~~~~
         |         virtio_break_device
   cc1: some warnings being treated as errors


vim +644 arch/um/drivers/virt-pci.c

   615	
   616	static void um_pci_virtio_remove(struct virtio_device *vdev)
   617	{
   618		struct um_pci_device *dev = vdev->priv;
   619		int i;
   620	
   621		device_set_wakeup_enable(&vdev->dev, false);
   622	
   623		mutex_lock(&um_pci_mtx);
   624		for (i = 0; i < MAX_DEVICES; i++) {
   625			if (um_pci_devices[i].dev != dev)
   626				continue;
   627	
   628			um_pci_devices[i].dev = NULL;
   629			irq_free_desc(dev->irq);
   630	
   631			break;
   632		}
   633		mutex_unlock(&um_pci_mtx);
   634	
   635		if (i < MAX_DEVICES) {
   636			struct pci_dev *pci_dev;
   637	
   638			pci_dev = pci_get_slot(bridge->bus, i);
   639			if (pci_dev)
   640				pci_stop_and_remove_bus_device_locked(pci_dev);
   641		}
   642	
   643		/* Stop all virtqueues */
 > 644		virtio_reset_device(vdev);
   645		dev->cmd_vq = NULL;
   646		dev->irq_vq = NULL;
   647		vdev->config->del_vqs(vdev);
   648	
   649		kfree(dev);
   650	}
   651	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-10 15:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 15:03 [stable:linux-5.15.y 9393/9999] arch/um/drivers/virt-pci.c:644:9: error: implicit declaration of function 'virtio_reset_device'; did you mean 'virtio_break_device'? kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).