oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [tzungbi-chrome-platform:for-next 4/4] drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
@ 2023-04-11  6:26 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-04-11  6:26 UTC (permalink / raw)
  To: Tzung-Bi Shih; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git for-next
head:   4696f24c5655dafc277c778bc7c20812bd72d44b
commit: 4696f24c5655dafc277c778bc7c20812bd72d44b [4/4] platform/chrome: cros_ec: Separate logic for getting panic info
config: i386-randconfig-a002-20230410 (https://download.01.org/0day-ci/archive/20230411/202304111451.2jNVy9ao-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git/commit/?id=4696f24c5655dafc277c778bc7c20812bd72d44b
        git remote add tzungbi-chrome-platform https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git
        git fetch --no-tags tzungbi-chrome-platform for-next
        git checkout 4696f24c5655dafc277c778bc7c20812bd72d44b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/chrome/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304111451.2jNVy9ao-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Returns the size of the panicinfo data fetched from the EC


vim +404 drivers/platform/chrome/cros_ec_debugfs.c

   402	
   403	/**
 > 404	 * Returns the size of the panicinfo data fetched from the EC
   405	 */
   406	static int cros_ec_get_panicinfo(struct cros_ec_device *ec_dev, uint8_t *data,
   407					 int data_size)
   408	{
   409		int ret;
   410		struct cros_ec_command *msg;
   411	
   412		if (!data || data_size <= 0 || data_size > ec_dev->max_response)
   413			return -EINVAL;
   414	
   415		msg = kzalloc(sizeof(*msg) + data_size, GFP_KERNEL);
   416		if (!msg)
   417			return -ENOMEM;
   418	
   419		msg->command = EC_CMD_GET_PANIC_INFO;
   420		msg->insize = data_size;
   421	
   422		ret = cros_ec_cmd_xfer_status(ec_dev, msg);
   423		if (ret < 0)
   424			goto free;
   425	
   426		memcpy(data, msg->data, data_size);
   427	
   428	free:
   429		kfree(msg);
   430		return ret;
   431	}
   432	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tzungbi-chrome-platform:for-next 4/4] drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
@ 2023-04-11  5:14 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-04-11  5:14 UTC (permalink / raw)
  To: Tzung-Bi Shih; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git for-next
head:   4696f24c5655dafc277c778bc7c20812bd72d44b
commit: 4696f24c5655dafc277c778bc7c20812bd72d44b [4/4] platform/chrome: cros_ec: Separate logic for getting panic info
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230411/202304111306.f3AWxKuA-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git/commit/?id=4696f24c5655dafc277c778bc7c20812bd72d44b
        git remote add tzungbi-chrome-platform https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git
        git fetch --no-tags tzungbi-chrome-platform for-next
        git checkout 4696f24c5655dafc277c778bc7c20812bd72d44b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/platform/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304111306.f3AWxKuA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Returns the size of the panicinfo data fetched from the EC


vim +404 drivers/platform/chrome/cros_ec_debugfs.c

   402	
   403	/**
 > 404	 * Returns the size of the panicinfo data fetched from the EC
   405	 */
   406	static int cros_ec_get_panicinfo(struct cros_ec_device *ec_dev, uint8_t *data,
   407					 int data_size)
   408	{
   409		int ret;
   410		struct cros_ec_command *msg;
   411	
   412		if (!data || data_size <= 0 || data_size > ec_dev->max_response)
   413			return -EINVAL;
   414	
   415		msg = kzalloc(sizeof(*msg) + data_size, GFP_KERNEL);
   416		if (!msg)
   417			return -ENOMEM;
   418	
   419		msg->command = EC_CMD_GET_PANIC_INFO;
   420		msg->insize = data_size;
   421	
   422		ret = cros_ec_cmd_xfer_status(ec_dev, msg);
   423		if (ret < 0)
   424			goto free;
   425	
   426		memcpy(data, msg->data, data_size);
   427	
   428	free:
   429		kfree(msg);
   430		return ret;
   431	}
   432	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-11  6:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-11  6:26 [tzungbi-chrome-platform:for-next 4/4] drivers/platform/chrome/cros_ec_debugfs.c:404: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-04-11  5:14 kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).