oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [mcgrof-next:20230506-fs-freeze 1/6] fs/gfs2/sys.c:167:31: error: 'sb' undeclared; did you mean 's8'?
@ 2023-05-07  8:54 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-05-07  8:54 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20230506-fs-freeze
head:   f89cf429edea2c04c26d2bd2bf2f16268ba2b181
commit: 61958780e6d30f6e846f14a5cf2c29250310520a [1/6] fs: unify locking semantics for fs freeze / thaw
config: arc-buildonly-randconfig-r003-20230507 (https://download.01.org/0day-ci/archive/20230507/202305071612.dVnL10lt-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=61958780e6d30f6e846f14a5cf2c29250310520a
        git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
        git fetch --no-tags mcgrof-next 20230506-fs-freeze
        git checkout 61958780e6d30f6e846f14a5cf2c29250310520a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs/gfs2/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305071612.dVnL10lt-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/gfs2/sys.c: In function 'freeze_store':
>> fs/gfs2/sys.c:167:31: error: 'sb' undeclared (first use in this function); did you mean 's8'?
     167 |         if (!get_active_super(sb->s_bdev))
         |                               ^~
         |                               s8
   fs/gfs2/sys.c:167:31: note: each undeclared identifier is reported only once for each function it appears in
--
   fs/gfs2/util.c: In function 'gfs2_withdraw':
>> fs/gfs2/util.c:348:39: error: 'sb' undeclared (first use in this function); did you mean 's8'?
     348 |                 if (!get_active_super(sb->s_bdev)) {
         |                                       ^~
         |                                       s8
   fs/gfs2/util.c:348:39: note: each undeclared identifier is reported only once for each function it appears in


vim +167 fs/gfs2/sys.c

   155	
   156	static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)
   157	{
   158		int error, n;
   159	
   160		error = kstrtoint(buf, 0, &n);
   161		if (error)
   162			return error;
   163	
   164		if (!capable(CAP_SYS_ADMIN))
   165			return -EPERM;
   166	
 > 167		if (!get_active_super(sb->s_bdev))
   168			return -ENOTTY;
   169	
   170		switch (n) {
   171		case 0:
   172			error = thaw_super(sdp->sd_vfs);
   173			break;
   174		case 1:
   175			error = freeze_super(sdp->sd_vfs);
   176			break;
   177		default:
   178			deactivate_locked_super(sb);
   179			return -EINVAL;
   180		}
   181	
   182		deactivate_locked_super(sb);
   183	
   184		if (error) {
   185			fs_warn(sdp, "freeze %d error %d\n", n, error);
   186			return error;
   187		}
   188	
   189		return len;
   190	}
   191	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-07  8:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-07  8:54 [mcgrof-next:20230506-fs-freeze 1/6] fs/gfs2/sys.c:167:31: error: 'sb' undeclared; did you mean 's8'? kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).