oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [jgunthorpe:iommu_all_defdom 32/46] drivers/iommu/iommu.c:291:6: warning: no previous prototype for 'iommu_device_unregister_bus'
@ 2023-05-08  2:01 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-05-08  2:01 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: oe-kbuild-all

tree:   https://github.com/jgunthorpe/linux iommu_all_defdom
head:   0d32aaa7c58040c56a21127e0619a38a53a70da6
commit: 859d9dfcd9c5074b4148b9fb260f2f449e81ad65 [32/46] iommufd/selftest: Make the mock iommu driver into a real driver
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20230508/202305080942.RuCeGped-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jgunthorpe/linux/commit/859d9dfcd9c5074b4148b9fb260f2f449e81ad65
        git remote add jgunthorpe https://github.com/jgunthorpe/linux
        git fetch --no-tags jgunthorpe iommu_all_defdom
        git checkout 859d9dfcd9c5074b4148b9fb260f2f449e81ad65
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/iommu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305080942.RuCeGped-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iommu/iommu.c:291:6: warning: no previous prototype for 'iommu_device_unregister_bus' [-Wmissing-prototypes]
     291 | void iommu_device_unregister_bus(struct iommu_device *iommu,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iommu/iommu.c:305:5: warning: no previous prototype for 'iommu_device_register_bus' [-Wmissing-prototypes]
     305 | int iommu_device_register_bus(struct iommu_device *iommu,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/iommu_device_unregister_bus +291 drivers/iommu/iommu.c

   289	
   290	#if IS_ENABLED(CONFIG_IOMMUFD_TEST)
 > 291	void iommu_device_unregister_bus(struct iommu_device *iommu,
   292					 struct bus_type *bus,
   293					 struct notifier_block *nb)
   294	{
   295		bus_unregister_notifier(bus, nb);
   296		iommu_device_unregister(iommu);
   297	}
   298	EXPORT_SYMBOL_NS_GPL(iommu_device_unregister_bus, IOMMUFD);
   299	
   300	/*
   301	 * Register an iommu driver against a single bus. This is only used by iommufd
   302	 * selftest to create a mock iommu driver. The caller must provide
   303	 * some memory to hold a notifier_block.
   304	 */
 > 305	int iommu_device_register_bus(struct iommu_device *iommu,
   306				      const struct iommu_ops *ops, struct bus_type *bus,
   307				      struct notifier_block *nb)
   308	{
   309		int err;
   310	
   311		iommu->ops = ops;
   312		nb->notifier_call = iommu_bus_notifier;
   313		err = bus_register_notifier(bus, nb);
   314		if (err)
   315			return err;
   316	
   317		spin_lock(&iommu_device_lock);
   318		list_add_tail(&iommu->list, &iommu_device_list);
   319		spin_unlock(&iommu_device_lock);
   320	
   321		bus->iommu_ops = ops;
   322		err = bus_iommu_probe(bus);
   323		if (err) {
   324			iommu_device_unregister_bus(iommu, bus, nb);
   325			return err;
   326		}
   327		return 0;
   328	}
   329	EXPORT_SYMBOL_NS_GPL(iommu_device_register_bus, IOMMUFD);
   330	#endif
   331	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-08  2:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08  2:01 [jgunthorpe:iommu_all_defdom 32/46] drivers/iommu/iommu.c:291:6: warning: no previous prototype for 'iommu_device_unregister_bus' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).