oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH RFC 2/2] net: remove __skb_frag_set_page()
       [not found] <20230508123922.39284-3-linyunsheng@huawei.com>
@ 2023-05-08 14:58 ` kernel test robot
  2023-05-09  0:56 ` kernel test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-05-08 14:58 UTC (permalink / raw)
  To: Yunsheng Lin; +Cc: oe-kbuild-all

Hi Yunsheng,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.4-rc1 next-20230508]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yunsheng-Lin/net-introduce-and-use-skb_frag_fill_page_desc/20230508-204326
base:   net/main
patch link:    https://lore.kernel.org/r/20230508123922.39284-3-linyunsheng%40huawei.com
patch subject: [PATCH RFC 2/2] net: remove __skb_frag_set_page()
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230508/202305082238.59BxXcwS-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/999d6693757a196e863558b6d7663425165a7acb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yunsheng-Lin/net-introduce-and-use-skb_frag_fill_page_desc/20230508-204326
        git checkout 999d6693757a196e863558b6d7663425165a7acb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305082238.59BxXcwS-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function '__bnxt_rx_agg_pages':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:1105:38: warning: variable 'nr_frags' set but not used [-Wunused-but-set-variable]
    1105 |                         unsigned int nr_frags;
         |                                      ^~~~~~~~


vim +/nr_frags +1105 drivers/net/ethernet/broadcom/bnxt/bnxt.c

c0c050c58d8409 Michael Chan    2015-10-22  1054  
23e4c0469ad03f Andy Gospodarek 2022-04-08  1055  static u32 __bnxt_rx_agg_pages(struct bnxt *bp,
e44758b78ae814 Michael Chan    2018-10-14  1056  			       struct bnxt_cp_ring_info *cpr,
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1057  			       struct skb_shared_info *shinfo,
31b9998bf225ec Andy Gospodarek 2022-04-08  1058  			       u16 idx, u32 agg_bufs, bool tpa,
31b9998bf225ec Andy Gospodarek 2022-04-08  1059  			       struct xdp_buff *xdp)
c0c050c58d8409 Michael Chan    2015-10-22  1060  {
e44758b78ae814 Michael Chan    2018-10-14  1061  	struct bnxt_napi *bnapi = cpr->bnapi;
c0c050c58d8409 Michael Chan    2015-10-22  1062  	struct pci_dev *pdev = bp->pdev;
b6ab4b01f53b5f Michael Chan    2016-01-02  1063  	struct bnxt_rx_ring_info *rxr = bnapi->rx_ring;
c0c050c58d8409 Michael Chan    2015-10-22  1064  	u16 prod = rxr->rx_agg_prod;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1065  	u32 i, total_frag_len = 0;
bfcd8d791ec184 Michael Chan    2019-07-29  1066  	bool p5_tpa = false;
c0c050c58d8409 Michael Chan    2015-10-22  1067  
bfcd8d791ec184 Michael Chan    2019-07-29  1068  	if ((bp->flags & BNXT_FLAG_CHIP_P5) && tpa)
bfcd8d791ec184 Michael Chan    2019-07-29  1069  		p5_tpa = true;
bfcd8d791ec184 Michael Chan    2019-07-29  1070  
c0c050c58d8409 Michael Chan    2015-10-22  1071  	for (i = 0; i < agg_bufs; i++) {
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1072  		skb_frag_t *frag = &shinfo->frags[i];
c0c050c58d8409 Michael Chan    2015-10-22  1073  		u16 cons, frag_len;
c0c050c58d8409 Michael Chan    2015-10-22  1074  		struct rx_agg_cmp *agg;
c0c050c58d8409 Michael Chan    2015-10-22  1075  		struct bnxt_sw_rx_agg_bd *cons_rx_buf;
c0c050c58d8409 Michael Chan    2015-10-22  1076  		struct page *page;
c0c050c58d8409 Michael Chan    2015-10-22  1077  		dma_addr_t mapping;
c0c050c58d8409 Michael Chan    2015-10-22  1078  
bfcd8d791ec184 Michael Chan    2019-07-29  1079  		if (p5_tpa)
bfcd8d791ec184 Michael Chan    2019-07-29  1080  			agg = bnxt_get_tpa_agg_p5(bp, rxr, idx, i);
bfcd8d791ec184 Michael Chan    2019-07-29  1081  		else
4a228a3a5e58e5 Michael Chan    2019-07-29  1082  			agg = bnxt_get_agg(bp, cpr, idx, i);
c0c050c58d8409 Michael Chan    2015-10-22  1083  		cons = agg->rx_agg_cmp_opaque;
c0c050c58d8409 Michael Chan    2015-10-22  1084  		frag_len = (le32_to_cpu(agg->rx_agg_cmp_len_flags_type) &
c0c050c58d8409 Michael Chan    2015-10-22  1085  			    RX_AGG_CMP_LEN) >> RX_AGG_CMP_LEN_SHIFT;
c0c050c58d8409 Michael Chan    2015-10-22  1086  
c0c050c58d8409 Michael Chan    2015-10-22  1087  		cons_rx_buf = &rxr->rx_agg_ring[cons];
9501ff8f37986d Yunsheng Lin    2023-05-08  1088  		skb_frag_fill_page_desc(frag, cons_rx_buf->page,
9501ff8f37986d Yunsheng Lin    2023-05-08  1089  					cons_rx_buf->offset, frag_len);
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1090  		shinfo->nr_frags = i + 1;
c0c050c58d8409 Michael Chan    2015-10-22  1091  		__clear_bit(cons, rxr->rx_agg_bmap);
c0c050c58d8409 Michael Chan    2015-10-22  1092  
c0c050c58d8409 Michael Chan    2015-10-22  1093  		/* It is possible for bnxt_alloc_rx_page() to allocate
c0c050c58d8409 Michael Chan    2015-10-22  1094  		 * a sw_prod index that equals the cons index, so we
c0c050c58d8409 Michael Chan    2015-10-22  1095  		 * need to clear the cons entry now.
c0c050c58d8409 Michael Chan    2015-10-22  1096  		 */
11cd119d31a71b Michael Chan    2017-02-06  1097  		mapping = cons_rx_buf->mapping;
c0c050c58d8409 Michael Chan    2015-10-22  1098  		page = cons_rx_buf->page;
c0c050c58d8409 Michael Chan    2015-10-22  1099  		cons_rx_buf->page = NULL;
c0c050c58d8409 Michael Chan    2015-10-22  1100  
31b9998bf225ec Andy Gospodarek 2022-04-08  1101  		if (xdp && page_is_pfmemalloc(page))
31b9998bf225ec Andy Gospodarek 2022-04-08  1102  			xdp_buff_set_frag_pfmemalloc(xdp);
31b9998bf225ec Andy Gospodarek 2022-04-08  1103  
c0c050c58d8409 Michael Chan    2015-10-22  1104  		if (bnxt_alloc_rx_page(bp, rxr, prod, GFP_ATOMIC) != 0) {
c0c050c58d8409 Michael Chan    2015-10-22 @1105  			unsigned int nr_frags;
c0c050c58d8409 Michael Chan    2015-10-22  1106  
c0c050c58d8409 Michael Chan    2015-10-22  1107  			nr_frags = --shinfo->nr_frags;
c0c050c58d8409 Michael Chan    2015-10-22  1108  			cons_rx_buf->page = page;
c0c050c58d8409 Michael Chan    2015-10-22  1109  
c0c050c58d8409 Michael Chan    2015-10-22  1110  			/* Update prod since possibly some pages have been
c0c050c58d8409 Michael Chan    2015-10-22  1111  			 * allocated already.
c0c050c58d8409 Michael Chan    2015-10-22  1112  			 */
c0c050c58d8409 Michael Chan    2015-10-22  1113  			rxr->rx_agg_prod = prod;
4a228a3a5e58e5 Michael Chan    2019-07-29  1114  			bnxt_reuse_rx_agg_bufs(cpr, idx, i, agg_bufs - i, tpa);
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1115  			return 0;
c0c050c58d8409 Michael Chan    2015-10-22  1116  		}
c0c050c58d8409 Michael Chan    2015-10-22  1117  
c519fe9a4f0d1a Shannon Nelson  2017-05-09  1118  		dma_unmap_page_attrs(&pdev->dev, mapping, BNXT_RX_PAGE_SIZE,
9a6aa350488533 Andy Gospodarek 2022-04-08  1119  				     bp->rx_dir,
c519fe9a4f0d1a Shannon Nelson  2017-05-09  1120  				     DMA_ATTR_WEAK_ORDERING);
c0c050c58d8409 Michael Chan    2015-10-22  1121  
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1122  		total_frag_len += frag_len;
c0c050c58d8409 Michael Chan    2015-10-22  1123  		prod = NEXT_RX_AGG(prod);
c0c050c58d8409 Michael Chan    2015-10-22  1124  	}
c0c050c58d8409 Michael Chan    2015-10-22  1125  	rxr->rx_agg_prod = prod;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1126  	return total_frag_len;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1127  }
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1128  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH RFC 2/2] net: remove __skb_frag_set_page()
       [not found] <20230508123922.39284-3-linyunsheng@huawei.com>
  2023-05-08 14:58 ` [PATCH RFC 2/2] net: remove __skb_frag_set_page() kernel test robot
@ 2023-05-09  0:56 ` kernel test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-05-09  0:56 UTC (permalink / raw)
  To: Yunsheng Lin; +Cc: llvm, oe-kbuild-all

Hi Yunsheng,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.4-rc1 next-20230508]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yunsheng-Lin/net-introduce-and-use-skb_frag_fill_page_desc/20230508-204326
base:   net/main
patch link:    https://lore.kernel.org/r/20230508123922.39284-3-linyunsheng%40huawei.com
patch subject: [PATCH RFC 2/2] net: remove __skb_frag_set_page()
config: x86_64-randconfig-a004-20230508 (https://download.01.org/0day-ci/archive/20230509/202305090842.2IQADg4N-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/999d6693757a196e863558b6d7663425165a7acb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yunsheng-Lin/net-introduce-and-use-skb_frag_fill_page_desc/20230508-204326
        git checkout 999d6693757a196e863558b6d7663425165a7acb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/broadcom/bnxt/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305090842.2IQADg4N-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:1105:17: warning: variable 'nr_frags' set but not used [-Wunused-but-set-variable]
                           unsigned int nr_frags;
                                        ^
   1 warning generated.


vim +/nr_frags +1105 drivers/net/ethernet/broadcom/bnxt/bnxt.c

c0c050c58d8409 Michael Chan    2015-10-22  1054  
23e4c0469ad03f Andy Gospodarek 2022-04-08  1055  static u32 __bnxt_rx_agg_pages(struct bnxt *bp,
e44758b78ae814 Michael Chan    2018-10-14  1056  			       struct bnxt_cp_ring_info *cpr,
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1057  			       struct skb_shared_info *shinfo,
31b9998bf225ec Andy Gospodarek 2022-04-08  1058  			       u16 idx, u32 agg_bufs, bool tpa,
31b9998bf225ec Andy Gospodarek 2022-04-08  1059  			       struct xdp_buff *xdp)
c0c050c58d8409 Michael Chan    2015-10-22  1060  {
e44758b78ae814 Michael Chan    2018-10-14  1061  	struct bnxt_napi *bnapi = cpr->bnapi;
c0c050c58d8409 Michael Chan    2015-10-22  1062  	struct pci_dev *pdev = bp->pdev;
b6ab4b01f53b5f Michael Chan    2016-01-02  1063  	struct bnxt_rx_ring_info *rxr = bnapi->rx_ring;
c0c050c58d8409 Michael Chan    2015-10-22  1064  	u16 prod = rxr->rx_agg_prod;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1065  	u32 i, total_frag_len = 0;
bfcd8d791ec184 Michael Chan    2019-07-29  1066  	bool p5_tpa = false;
c0c050c58d8409 Michael Chan    2015-10-22  1067  
bfcd8d791ec184 Michael Chan    2019-07-29  1068  	if ((bp->flags & BNXT_FLAG_CHIP_P5) && tpa)
bfcd8d791ec184 Michael Chan    2019-07-29  1069  		p5_tpa = true;
bfcd8d791ec184 Michael Chan    2019-07-29  1070  
c0c050c58d8409 Michael Chan    2015-10-22  1071  	for (i = 0; i < agg_bufs; i++) {
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1072  		skb_frag_t *frag = &shinfo->frags[i];
c0c050c58d8409 Michael Chan    2015-10-22  1073  		u16 cons, frag_len;
c0c050c58d8409 Michael Chan    2015-10-22  1074  		struct rx_agg_cmp *agg;
c0c050c58d8409 Michael Chan    2015-10-22  1075  		struct bnxt_sw_rx_agg_bd *cons_rx_buf;
c0c050c58d8409 Michael Chan    2015-10-22  1076  		struct page *page;
c0c050c58d8409 Michael Chan    2015-10-22  1077  		dma_addr_t mapping;
c0c050c58d8409 Michael Chan    2015-10-22  1078  
bfcd8d791ec184 Michael Chan    2019-07-29  1079  		if (p5_tpa)
bfcd8d791ec184 Michael Chan    2019-07-29  1080  			agg = bnxt_get_tpa_agg_p5(bp, rxr, idx, i);
bfcd8d791ec184 Michael Chan    2019-07-29  1081  		else
4a228a3a5e58e5 Michael Chan    2019-07-29  1082  			agg = bnxt_get_agg(bp, cpr, idx, i);
c0c050c58d8409 Michael Chan    2015-10-22  1083  		cons = agg->rx_agg_cmp_opaque;
c0c050c58d8409 Michael Chan    2015-10-22  1084  		frag_len = (le32_to_cpu(agg->rx_agg_cmp_len_flags_type) &
c0c050c58d8409 Michael Chan    2015-10-22  1085  			    RX_AGG_CMP_LEN) >> RX_AGG_CMP_LEN_SHIFT;
c0c050c58d8409 Michael Chan    2015-10-22  1086  
c0c050c58d8409 Michael Chan    2015-10-22  1087  		cons_rx_buf = &rxr->rx_agg_ring[cons];
9501ff8f37986d Yunsheng Lin    2023-05-08  1088  		skb_frag_fill_page_desc(frag, cons_rx_buf->page,
9501ff8f37986d Yunsheng Lin    2023-05-08  1089  					cons_rx_buf->offset, frag_len);
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1090  		shinfo->nr_frags = i + 1;
c0c050c58d8409 Michael Chan    2015-10-22  1091  		__clear_bit(cons, rxr->rx_agg_bmap);
c0c050c58d8409 Michael Chan    2015-10-22  1092  
c0c050c58d8409 Michael Chan    2015-10-22  1093  		/* It is possible for bnxt_alloc_rx_page() to allocate
c0c050c58d8409 Michael Chan    2015-10-22  1094  		 * a sw_prod index that equals the cons index, so we
c0c050c58d8409 Michael Chan    2015-10-22  1095  		 * need to clear the cons entry now.
c0c050c58d8409 Michael Chan    2015-10-22  1096  		 */
11cd119d31a71b Michael Chan    2017-02-06  1097  		mapping = cons_rx_buf->mapping;
c0c050c58d8409 Michael Chan    2015-10-22  1098  		page = cons_rx_buf->page;
c0c050c58d8409 Michael Chan    2015-10-22  1099  		cons_rx_buf->page = NULL;
c0c050c58d8409 Michael Chan    2015-10-22  1100  
31b9998bf225ec Andy Gospodarek 2022-04-08  1101  		if (xdp && page_is_pfmemalloc(page))
31b9998bf225ec Andy Gospodarek 2022-04-08  1102  			xdp_buff_set_frag_pfmemalloc(xdp);
31b9998bf225ec Andy Gospodarek 2022-04-08  1103  
c0c050c58d8409 Michael Chan    2015-10-22  1104  		if (bnxt_alloc_rx_page(bp, rxr, prod, GFP_ATOMIC) != 0) {
c0c050c58d8409 Michael Chan    2015-10-22 @1105  			unsigned int nr_frags;
c0c050c58d8409 Michael Chan    2015-10-22  1106  
c0c050c58d8409 Michael Chan    2015-10-22  1107  			nr_frags = --shinfo->nr_frags;
c0c050c58d8409 Michael Chan    2015-10-22  1108  			cons_rx_buf->page = page;
c0c050c58d8409 Michael Chan    2015-10-22  1109  
c0c050c58d8409 Michael Chan    2015-10-22  1110  			/* Update prod since possibly some pages have been
c0c050c58d8409 Michael Chan    2015-10-22  1111  			 * allocated already.
c0c050c58d8409 Michael Chan    2015-10-22  1112  			 */
c0c050c58d8409 Michael Chan    2015-10-22  1113  			rxr->rx_agg_prod = prod;
4a228a3a5e58e5 Michael Chan    2019-07-29  1114  			bnxt_reuse_rx_agg_bufs(cpr, idx, i, agg_bufs - i, tpa);
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1115  			return 0;
c0c050c58d8409 Michael Chan    2015-10-22  1116  		}
c0c050c58d8409 Michael Chan    2015-10-22  1117  
c519fe9a4f0d1a Shannon Nelson  2017-05-09  1118  		dma_unmap_page_attrs(&pdev->dev, mapping, BNXT_RX_PAGE_SIZE,
9a6aa350488533 Andy Gospodarek 2022-04-08  1119  				     bp->rx_dir,
c519fe9a4f0d1a Shannon Nelson  2017-05-09  1120  				     DMA_ATTR_WEAK_ORDERING);
c0c050c58d8409 Michael Chan    2015-10-22  1121  
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1122  		total_frag_len += frag_len;
c0c050c58d8409 Michael Chan    2015-10-22  1123  		prod = NEXT_RX_AGG(prod);
c0c050c58d8409 Michael Chan    2015-10-22  1124  	}
c0c050c58d8409 Michael Chan    2015-10-22  1125  	rxr->rx_agg_prod = prod;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1126  	return total_frag_len;
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1127  }
ca1df2dd8e2f2c Andy Gospodarek 2022-04-08  1128  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230508123922.39284-3-linyunsheng@huawei.com>
2023-05-08 14:58 ` [PATCH RFC 2/2] net: remove __skb_frag_set_page() kernel test robot
2023-05-09  0:56 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).