Re: [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended

* Re: [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
       [not found] <20230504045052.22347-1-quic_ugoswami@quicinc.com>
@ 2023-05-04  7:28 ` kernel test robot
  2023-05-09 22:04 ` kernel test robot
  2023-05-10  7:32 ` Dan Carpenter
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-05-04  7:28 UTC (permalink / raw)
  To: Udipto Goswami, Thinh Nguyen, Greg Kroah-Hartman
  Cc: oe-kbuild-all, Pratham Pratap, Jack Pham, Johan Hovold,
	Oliver Neukum, linux-usb, Udipto Goswami

Hi Udipto,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus johan-usb-serial/usb-next johan-usb-serial/usb-linus linus/master v6.3 next-20230428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Udipto-Goswami/usb-dwc3-debugfs-Prevent-any-register-access-when-devices-is-runtime-suspended/20230504-125225
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20230504045052.22347-1-quic_ugoswami%40quicinc.com
patch subject: [PATCH v8] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230504/202305041526.hBiM1g2W-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1c53edaeee33380f0fc3e0d262829ffaa66f45e1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Udipto-Goswami/usb-dwc3-debugfs-Prevent-any-register-access-when-devices-is-runtime-suspended/20230504-125225
        git checkout 1c53edaeee33380f0fc3e0d262829ffaa66f45e1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/usb/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305041526.hBiM1g2W-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/usb/dwc3/debugfs.c: In function 'dwc3_rx_fifo_size_show':
>> drivers/usb/dwc3/debugfs.c:718:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     718 |         if (ret < 0)
         |         ^~
   drivers/usb/dwc3/debugfs.c:720:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     720 |                 return ret;
         |                 ^~~~~~

vim +/if +718 drivers/usb/dwc3/debugfs.c

   707	
   708	static int dwc3_rx_fifo_size_show(struct seq_file *s, void *unused)
   709	{
   710		struct dwc3_ep		*dep = s->private;
   711		struct dwc3		*dwc = dep->dwc;
   712		unsigned long		flags;
   713		u32			mdwidth;
   714		u32			val;
   715		int			ret;
   716	
   717		ret = pm_runtime_resume_and_get(dwc->dev);
 > 718		if (ret < 0)
   719			pm_runtime_put_sync(dwc->dev);
   720			return ret;
   721	
   722		spin_lock_irqsave(&dwc->lock, flags);
   723		val = dwc3_core_fifo_space(dep, DWC3_RXFIFO);
   724	
   725		/* Convert to bytes */
   726		mdwidth = dwc3_mdwidth(dwc);
   727	
   728		val *= mdwidth;
   729		val >>= 3;
   730		seq_printf(s, "%u\n", val);
   731		spin_unlock_irqrestore(&dwc->lock, flags);
   732	
   733		pm_runtime_put_sync(dwc->dev);
   734		return 0;
   735	}
   736	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 4+ messages in thread