* Re: [PATCH V7] can: usb: f81604: add Fintek F81604 support
[not found] <20230509073821.25289-1-peter_hong@fintek.com.tw>
@ 2023-05-09 10:17 ` kernel test robot
2023-05-09 12:14 ` Marc Kleine-Budde
2023-05-10 10:54 ` kernel test robot
1 sibling, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-05-09 10:17 UTC (permalink / raw)
To: Ji-Ze Hong (Peter Hong),
wg, mkl, michal.swiatkowski, Steen.Hegelund, mailhol.vincent
Cc: oe-kbuild-all, davem, edumazet, kuba, pabeni, frank.jungclaus,
linux-kernel, linux-can, netdev, hpeter+linux_kernel,
Ji-Ze Hong (Peter Hong)
Hi Ji-Ze,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linus/master v6.4-rc1 next-20230509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link: https://lore.kernel.org/r/20230509073821.25289-1-peter_hong%40fintek.com.tw
patch subject: [PATCH V7] can: usb: f81604: add Fintek F81604 support
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230509/202305091802.pRFS6n2j-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/9549380f8d5eea359f8c83f48e10a0becfd13541
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
git checkout 9549380f8d5eea359f8c83f48e10a0becfd13541
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305091802.pRFS6n2j-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/can/usb/f81604.c: In function 'f81604_read_bulk_callback':
>> drivers/net/can/usb/f81604.c:440:67: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
440 | netdev_warn(netdev, "URB length %u not equal to %lu\n",
| ~~^
| |
| long unsigned int
| %u
441 | urb->actual_length, sizeof(*frame));
| ~~~~~~~~~~~~~~
| |
| unsigned int
vim +440 drivers/net/can/usb/f81604.c
411
412 static void f81604_read_bulk_callback(struct urb *urb)
413 {
414 struct f81604_can_frame *frame = urb->transfer_buffer;
415 struct net_device *netdev = urb->context;
416 int ret;
417
418 if (!netif_device_present(netdev))
419 return;
420
421 if (urb->status)
422 netdev_info(netdev, "%s: URB aborted %pe\n", __func__,
423 ERR_PTR(urb->status));
424
425 switch (urb->status) {
426 case 0: /* success */
427 break;
428
429 case -ENOENT:
430 case -EPIPE:
431 case -EPROTO:
432 case -ESHUTDOWN:
433 return;
434
435 default:
436 goto resubmit_urb;
437 }
438
439 if (urb->actual_length != sizeof(*frame)) {
> 440 netdev_warn(netdev, "URB length %u not equal to %lu\n",
441 urb->actual_length, sizeof(*frame));
442 goto resubmit_urb;
443 }
444
445 f81604_process_rx_packet(netdev, frame);
446
447 resubmit_urb:
448 ret = usb_submit_urb(urb, GFP_ATOMIC);
449 if (ret == -ENODEV)
450 netif_device_detach(netdev);
451 else if (ret)
452 netdev_err(netdev,
453 "%s: failed to resubmit read bulk urb: %pe\n",
454 __func__, ERR_PTR(ret));
455 }
456
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V7] can: usb: f81604: add Fintek F81604 support
[not found] <20230509073821.25289-1-peter_hong@fintek.com.tw>
2023-05-09 10:17 ` [PATCH V7] can: usb: f81604: add Fintek F81604 support kernel test robot
@ 2023-05-10 10:54 ` kernel test robot
1 sibling, 0 replies; 5+ messages in thread
From: kernel test robot @ 2023-05-10 10:54 UTC (permalink / raw)
To: Ji-Ze Hong (Peter Hong),
wg, mkl, michal.swiatkowski, Steen.Hegelund, mailhol.vincent
Cc: llvm, oe-kbuild-all, davem, edumazet, kuba, pabeni,
frank.jungclaus, linux-kernel, linux-can, netdev,
hpeter+linux_kernel, Ji-Ze Hong (Peter Hong)
Hi Ji-Ze,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linus/master v6.4-rc1 next-20230510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link: https://lore.kernel.org/r/20230509073821.25289-1-peter_hong%40fintek.com.tw
patch subject: [PATCH V7] can: usb: f81604: add Fintek F81604 support
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20230510/202305101816.meuESNdN-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b0fb98227c90adf2536c9ad644a74d5e92961111)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/9549380f8d5eea359f8c83f48e10a0becfd13541
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
git checkout 9549380f8d5eea359f8c83f48e10a0becfd13541
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/hwmon/ drivers/net/can/usb/ drivers/watchdog/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305101816.meuESNdN-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/can/usb/f81604.c:7:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/net/can/usb/f81604.c:7:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/net/can/usb/f81604.c:7:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> drivers/net/can/usb/f81604.c:441:28: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
urb->actual_length, sizeof(*frame));
^~~~~~~~~~~~~~
7 warnings generated.
vim +441 drivers/net/can/usb/f81604.c
411
412 static void f81604_read_bulk_callback(struct urb *urb)
413 {
414 struct f81604_can_frame *frame = urb->transfer_buffer;
415 struct net_device *netdev = urb->context;
416 int ret;
417
418 if (!netif_device_present(netdev))
419 return;
420
421 if (urb->status)
422 netdev_info(netdev, "%s: URB aborted %pe\n", __func__,
423 ERR_PTR(urb->status));
424
425 switch (urb->status) {
426 case 0: /* success */
427 break;
428
429 case -ENOENT:
430 case -EPIPE:
431 case -EPROTO:
432 case -ESHUTDOWN:
433 return;
434
435 default:
436 goto resubmit_urb;
437 }
438
439 if (urb->actual_length != sizeof(*frame)) {
440 netdev_warn(netdev, "URB length %u not equal to %lu\n",
> 441 urb->actual_length, sizeof(*frame));
442 goto resubmit_urb;
443 }
444
445 f81604_process_rx_packet(netdev, frame);
446
447 resubmit_urb:
448 ret = usb_submit_urb(urb, GFP_ATOMIC);
449 if (ret == -ENODEV)
450 netif_device_detach(netdev);
451 else if (ret)
452 netdev_err(netdev,
453 "%s: failed to resubmit read bulk urb: %pe\n",
454 __func__, ERR_PTR(ret));
455 }
456
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 5+ messages in thread