[stable:linux-4.14.y 4888/5126] drivers/video/fbdev/imsttfb.c:1457:10: warning: 'return' with a value, in function returning void

[stable:linux-4.14.y 4888/5126] drivers/video/fbdev/imsttfb.c:1457:10: warning: 'return' with a value, in function returning void

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y
head:   42c4d61793d56abc629911c78aaa9ed24293151a
commit: 8f05ae0e3fdd533865dbd1b0b2632986c0706a50 [4888/5126] fbdev: imsttfb: Release framebuffer and dealloc cmap on error path
config: x86_64-randconfig-r022-20230811 (https://download.01.org/0day-ci/archive/20230811/202308111903.QndKHO7x-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce: (https://download.01.org/0day-ci/archive/20230811/202308111903.QndKHO7x-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308111903.QndKHO7x-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/video/fbdev/imsttfb.c: In function 'init_imstt':
>> drivers/video/fbdev/imsttfb.c:1457:10: warning: 'return' with a value, in function returning void
      return -ENODEV;
             ^
   drivers/video/fbdev/imsttfb.c:1351:13: note: declared here
    static void init_imstt(struct fb_info *info)
                ^~~~~~~~~~


vim +/return +1457 drivers/video/fbdev/imsttfb.c

  1418	
  1419		if ((info->var.xres * info->var.yres) * (info->var.bits_per_pixel >> 3) > info->fix.smem_len
  1420		    || !(compute_imstt_regvals(par, info->var.xres, info->var.yres))) {
  1421			printk("imsttfb: %ux%ux%u not supported\n", info->var.xres, info->var.yres, info->var.bits_per_pixel);
  1422			framebuffer_release(info);
  1423			return;
  1424		}
  1425	
  1426		sprintf(info->fix.id, "IMS TT (%s)", par->ramdac == IBM ? "IBM" : "TVP");
  1427		info->fix.mmio_len = 0x1000;
  1428		info->fix.accel = FB_ACCEL_IMS_TWINTURBO;
  1429		info->fix.type = FB_TYPE_PACKED_PIXELS;
  1430		info->fix.visual = info->var.bits_per_pixel == 8 ? FB_VISUAL_PSEUDOCOLOR
  1431								: FB_VISUAL_DIRECTCOLOR;
  1432		info->fix.line_length = info->var.xres * (info->var.bits_per_pixel >> 3);
  1433		info->fix.xpanstep = 8;
  1434		info->fix.ypanstep = 1;
  1435		info->fix.ywrapstep = 0;
  1436	
  1437		info->var.accel_flags = FB_ACCELF_TEXT;
  1438	
  1439	//	if (par->ramdac == IBM)
  1440	//		imstt_cursor_init(info);
  1441		if (info->var.green.length == 6)
  1442			set_565(par);
  1443		else
  1444			set_555(par);
  1445		set_imstt_regvals(info, info->var.bits_per_pixel);
  1446	
  1447		info->var.pixclock = 1000000 / getclkMHz(par);
  1448	
  1449		info->fbops = &imsttfb_ops;
  1450		info->flags = FBINFO_DEFAULT |
  1451	                      FBINFO_HWACCEL_COPYAREA |
  1452		              FBINFO_HWACCEL_FILLRECT |
  1453		              FBINFO_HWACCEL_YPAN;
  1454	
  1455		if (fb_alloc_cmap(&info->cmap, 0, 0)) {
  1456			framebuffer_release(info);
> 1457			return -ENODEV;
  1458		}
  1459	
  1460		if (register_framebuffer(info) < 0) {
  1461			fb_dealloc_cmap(&info->cmap);
  1462			framebuffer_release(info);
  1463			return;
  1464		}
  1465	
  1466		tmp = (read_reg_le32(par->dc_regs, SSTATUS) & 0x0f00) >> 8;
  1467		fb_info(info, "%s frame buffer; %uMB vram; chip version %u\n",
  1468			info->fix.id, info->fix.smem_len >> 20, tmp);
  1469	}
  1470	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki