oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [davejiang:cxl-ide 17/24] drivers/acpi/numa/srat.c:535:31: warning: implicit conversion from 'enum acpi_cedt_type' to 'enum acpi_keyp_type'
@ 2023-08-11 18:19 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-08-11 18:19 UTC (permalink / raw)
  To: Dave Jiang; +Cc: oe-kbuild-all

tree:   https://github.com/davejiang/linux.git cxl-ide
head:   ee3a63e65f46140bcb484e3d0052d641abceb9da
commit: 7e72c9ad3fa55da9f48f56720b09f5e74e00dc92 [17/24] acpi: Add KEYP support to fw_table parsing
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20230812/202308120229.j9Q3DVIT-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308120229.j9Q3DVIT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308120229.j9Q3DVIT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/acpi/numa/srat.c:15:
   include/linux/acpi.h:241:19: error: conflicting types for 'acpi_table_parse_cedt'; have 'int(enum acpi_keyp_type,  int (*)(union acpi_subtable_headers *, void *, const long unsigned int), void *)'
     241 | static inline int acpi_table_parse_cedt(enum acpi_keyp_type id,
         |                   ^~~~~~~~~~~~~~~~~~~~~
   include/linux/acpi.h:233:1: note: previous declaration of 'acpi_table_parse_cedt' with type 'int(enum acpi_cedt_type,  int (*)(union acpi_subtable_headers *, void *, const long unsigned int), void *)'
     233 | acpi_table_parse_cedt(enum acpi_cedt_type id,
         | ^~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/numa/srat.c: In function 'acpi_numa_init':
>> drivers/acpi/numa/srat.c:535:31: warning: implicit conversion from 'enum acpi_cedt_type' to 'enum acpi_keyp_type' [-Wenum-conversion]
     535 |         acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_parse_cfmws,
         |                               ^~~~~~~~~~~~~~~~~~~~


vim +535 drivers/acpi/numa/srat.c

^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  483  
20e6926dcbafa1 drivers/acpi/numa.c      Yinghai Lu          2013-03-01  484  int __init acpi_numa_init(void)
e8d1955258091e drivers/acpi/numa.c      Tang Chen           2013-02-22  485  {
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  486  	int i, fake_pxm, cnt = 0;
20e6926dcbafa1 drivers/acpi/numa.c      Yinghai Lu          2013-03-01  487  
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  488  	if (acpi_disabled)
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  489  		return -EINVAL;
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  490  
d3bd058826aa8b drivers/acpi/numa.c      Yinghai Lu          2010-12-16  491  	/*
d3bd058826aa8b drivers/acpi/numa.c      Yinghai Lu          2010-12-16  492  	 * Should not limit number with cpu num that is from NR_CPUS or nr_cpus=
d3bd058826aa8b drivers/acpi/numa.c      Yinghai Lu          2010-12-16  493  	 * SRAT cpu entries could have different order with that in MADT.
d3bd058826aa8b drivers/acpi/numa.c      Yinghai Lu          2010-12-16  494  	 * So go over all cpu entries in SRAT to get apicid to node mapping.
d3bd058826aa8b drivers/acpi/numa.c      Yinghai Lu          2010-12-16  495  	 */
8716273caef7f5 drivers/acpi/numa.c      David Rientjes      2009-09-25  496  
02cb489be7ad07 drivers/acpi/numa.c      Ross Zwisler        2017-07-21  497  	/* SRAT: System Resource Affinity Table */
7f8f97c3cc75d5 drivers/acpi/numa.c      Len Brown           2007-02-10  498  	if (!acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) {
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  499  		struct acpi_subtable_proc srat_proc[4];
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  500  
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  501  		memset(srat_proc, 0, sizeof(srat_proc));
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  502  		srat_proc[0].id = ACPI_SRAT_TYPE_CPU_AFFINITY;
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  503  		srat_proc[0].handler = acpi_parse_processor_affinity;
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  504  		srat_proc[1].id = ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY;
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  505  		srat_proc[1].handler = acpi_parse_x2apic_affinity;
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  506  		srat_proc[2].id = ACPI_SRAT_TYPE_GICC_AFFINITY;
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  507  		srat_proc[2].handler = acpi_parse_gicc_affinity;
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  508  		srat_proc[3].id = ACPI_SRAT_TYPE_GENERIC_AFFINITY;
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  509  		srat_proc[3].handler = acpi_parse_gi_affinity;
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  510  
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  511  		acpi_table_parse_entries_array(ACPI_SIG_SRAT,
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  512  					sizeof(struct acpi_table_srat),
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  513  					srat_proc, ARRAY_SIZE(srat_proc), 0);
702b07fcc9b264 drivers/acpi/numa.c      Lukasz Anaczkowski  2016-04-21  514  
20e6926dcbafa1 drivers/acpi/numa.c      Yinghai Lu          2013-03-01  515  		cnt = acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY,
fd3e454366603c drivers/acpi/numa.c      Ganapatrao Kulkarni 2017-11-15  516  					    acpi_parse_memory_affinity, 0);
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  517  	}
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  518  
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  519  	/* SLIT: System Locality Information Table */
7f8f97c3cc75d5 drivers/acpi/numa.c      Len Brown           2007-02-10  520  	acpi_table_parse(ACPI_SIG_SLIT, acpi_parse_slit);
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  521  
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  522  	/*
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  523  	 * CXL Fixed Memory Window Structures (CFMWS) must be parsed
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  524  	 * after the SRAT. Create NUMA Nodes for CXL memory ranges that
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  525  	 * are defined in the CFMWS and not already defined in the SRAT.
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  526  	 * Initialize a fake_pxm as the first available PXM to emulate.
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  527  	 */
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  528  
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  529  	/* fake_pxm is the next unused PXM value after SRAT parsing */
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  530  	for (i = 0, fake_pxm = -1; i < MAX_NUMNODES - 1; i++) {
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  531  		if (node_to_pxm_map[i] > fake_pxm)
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  532  			fake_pxm = node_to_pxm_map[i];
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  533  	}
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  534  	fake_pxm++;
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29 @535  	acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_parse_cfmws,
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  536  			      &fake_pxm);
fd49f99c180996 drivers/acpi/numa/srat.c Alison Schofield    2021-10-29  537  
20e6926dcbafa1 drivers/acpi/numa.c      Yinghai Lu          2013-03-01  538  	if (cnt < 0)
20e6926dcbafa1 drivers/acpi/numa.c      Yinghai Lu          2013-03-01  539  		return cnt;
095adbb6441172 drivers/acpi/numa.c      Thomas Renninger    2012-07-31  540  	else if (!parsed_numa_memblks)
f3946fb6e50b75 drivers/acpi/numa.c      Thomas Renninger    2012-07-31  541  		return -ENOENT;
940fed2e79a15c drivers/acpi/numa.c      Tejun Heo           2011-02-16  542  	return 0;
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  543  }
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  544  

:::::: The code at line 535 was first introduced by commit
:::::: fd49f99c180996cef2d707ad71bee4f060dbe367 ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT

:::::: TO: Alison Schofield <alison.schofield@intel.com>
:::::: CC: Dan Williams <dan.j.williams@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-11 18:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-11 18:19 [davejiang:cxl-ide 17/24] drivers/acpi/numa/srat.c:535:31: warning: implicit conversion from 'enum acpi_cedt_type' to 'enum acpi_keyp_type' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).