[frank-w-bpi-r2-4.14:6.5-dango-r4 7928/8003] drivers/net/phy/mediatek-ge-soc.c:1167:68: warning: ordered comparison of pointer with integer zero

[frank-w-bpi-r2-4.14:6.5-dango-r4 7928/8003] drivers/net/phy/mediatek-ge-soc.c:1167:68: warning: ordered comparison of pointer with integer zero

[kernel test robot]

tree:   https://github.com/frank-w/BPI-R2-4.14 6.5-dango-r4
head:   33ae06cdbe7cdded20d1ac549403343243272109
commit: 4925a0544e38db9487984608af613ce54c49ba3b [7928/8003] net: phy: mediatek-ge-soc: implement LED control API
config: m68k-randconfig-r013-20230812 (https://download.01.org/0day-ci/archive/20230812/202308121113.j2xPfEUY-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308121113.j2xPfEUY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308121113.j2xPfEUY-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/phy/mediatek-ge-soc.c: In function 'mt798x_phy_led_blink_set':
>> drivers/net/phy/mediatek-ge-soc.c:1167:68: warning: ordered comparison of pointer with integer zero [-Wextra]
    1167 |         if (delay_on && delay_off && *delay_on > 0 && & *delay_off > 0) {
         |                                                                    ^


vim +1167 drivers/net/phy/mediatek-ge-soc.c

  1156	
  1157	static int mt798x_phy_led_blink_set(struct phy_device *phydev, u8 index,
  1158					  unsigned long *delay_on,
  1159					  unsigned long *delay_off)
  1160	{
  1161		bool blinking = false;
  1162		int err = 0;
  1163	
  1164		if (index > 1)
  1165			return -EINVAL;
  1166	
> 1167		if (delay_on && delay_off && *delay_on > 0 && & *delay_off > 0) {
  1168			blinking = true;
  1169			*delay_on = 50;
  1170			*delay_off = 50;
  1171		}
  1172	
  1173		err = mt798x_phy_hw_led_blink_set(phydev, index, blinking);
  1174		if (err)
  1175			return err;
  1176	
  1177		return mt798x_phy_hw_led_on_set(phydev, index, false);
  1178	}
  1179	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki