* [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP'
@ 2023-08-12 8:31 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-08-12 8:31 UTC (permalink / raw)
To: Hector Martin; +Cc: oe-kbuild-all
tree: https://github.com/AsahiLinux/linux bits/140-pci
head: 924aefff015d104293101a46281fca901e2ccd3f
commit: 21000f7d389e4de57b4885912f084033c8336bd1 [10/15] PCIE: apple: Add T602x PCIe support
config: sparc64-randconfig-r026-20230812 (https://download.01.org/0day-ci/archive/20230812/202308121618.9ZixwlLw-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308121618.9ZixwlLw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308121618.9ZixwlLw-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pci/controller/pcie-apple.c: In function 'apple_pcie_port_setup_irq':
>> drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
468 | writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +468 drivers/pci/controller/pcie-apple.c
430
431 static int apple_pcie_port_setup_irq(struct apple_pcie_port *port)
432 {
433 struct fwnode_handle *fwnode = &port->np->fwnode;
434 struct apple_pcie *pcie = port->pcie;
435 unsigned int irq;
436
437 /* FIXME: consider moving each interrupt under each port */
438 irq = irq_of_parse_and_map(to_of_node(dev_fwnode(port->pcie->dev)),
439 port->idx);
440 if (!irq)
441 return -ENXIO;
442
443 port->domain = irq_domain_create_linear(fwnode, 32,
444 &apple_port_irq_domain_ops,
445 port);
446 if (!port->domain)
447 return -ENOMEM;
448
449 /* Disable all interrupts */
450 writel_relaxed(~0, port->base + PORT_INTMSK);
451 writel_relaxed(~0, port->base + PORT_INTSTAT);
452 writel_relaxed(~0, port->base + PORT_LINKCMDSTS);
453
454 irq_set_chained_handler_and_data(irq, apple_port_irq_handler, port);
455
456 /* Configure MSI base address */
457 BUG_ON(upper_32_bits(DOORBELL_ADDR));
458 writel_relaxed(lower_32_bits(DOORBELL_ADDR),
459 port->base + pcie->hw->port_msiaddr);
460 if (pcie->hw->port_msiaddr_hi)
461 writel_relaxed(0, port->base + pcie->hw->port_msiaddr_hi);
462
463 /* Enable MSIs, shared between all ports */
464 if (pcie->hw->port_msimap) {
465 int i;
466
467 for (i = 0; i < pcie->nvecs; i++) {
> 468 writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
469 PORT_MSIMAP_ENABLE,
470 port->base + pcie->hw->port_msimap + 4 * i);
471 }
472
473 writel_relaxed(PORT_MSICFG_EN, port->base + PORT_MSICFG);
474 } else {
475 writel_relaxed(0, port->base + PORT_MSIBASE);
476 writel_relaxed((ilog2(pcie->nvecs) << PORT_MSICFG_L2MSINUM_SHIFT) |
477 PORT_MSICFG_EN, port->base + PORT_MSICFG);
478 }
479
480 return 0;
481 }
482
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP'
@ 2023-10-01 10:26 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-10-01 10:26 UTC (permalink / raw)
To: Hector Martin; +Cc: oe-kbuild-all
tree: https://github.com/AsahiLinux/linux bits/140-pci
head: 07c5be0c765a02a50f5777ec7cb2e33c82d641c3
commit: bc47733313473d25b60a7f875cf6f806d62a641d [10/15] PCIE: apple: Add T602x PCIe support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231001/202310011802.cL64lJDc-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011802.cL64lJDc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310011802.cL64lJDc-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pci/controller/pcie-apple.c: In function 'apple_pcie_port_setup_irq':
>> drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
468 | writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +468 drivers/pci/controller/pcie-apple.c
430
431 static int apple_pcie_port_setup_irq(struct apple_pcie_port *port)
432 {
433 struct fwnode_handle *fwnode = &port->np->fwnode;
434 struct apple_pcie *pcie = port->pcie;
435 unsigned int irq;
436
437 /* FIXME: consider moving each interrupt under each port */
438 irq = irq_of_parse_and_map(to_of_node(dev_fwnode(port->pcie->dev)),
439 port->idx);
440 if (!irq)
441 return -ENXIO;
442
443 port->domain = irq_domain_create_linear(fwnode, 32,
444 &apple_port_irq_domain_ops,
445 port);
446 if (!port->domain)
447 return -ENOMEM;
448
449 /* Disable all interrupts */
450 writel_relaxed(~0, port->base + PORT_INTMSK);
451 writel_relaxed(~0, port->base + PORT_INTSTAT);
452 writel_relaxed(~0, port->base + PORT_LINKCMDSTS);
453
454 irq_set_chained_handler_and_data(irq, apple_port_irq_handler, port);
455
456 /* Configure MSI base address */
457 BUG_ON(upper_32_bits(DOORBELL_ADDR));
458 writel_relaxed(lower_32_bits(DOORBELL_ADDR),
459 port->base + pcie->hw->port_msiaddr);
460 if (pcie->hw->port_msiaddr_hi)
461 writel_relaxed(0, port->base + pcie->hw->port_msiaddr_hi);
462
463 /* Enable MSIs, shared between all ports */
464 if (pcie->hw->port_msimap) {
465 int i;
466
467 for (i = 0; i < pcie->nvecs; i++) {
> 468 writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
469 PORT_MSIMAP_ENABLE,
470 port->base + pcie->hw->port_msimap + 4 * i);
471 }
472
473 writel_relaxed(PORT_MSICFG_EN, port->base + PORT_MSICFG);
474 } else {
475 writel_relaxed(0, port->base + PORT_MSIBASE);
476 writel_relaxed((ilog2(pcie->nvecs) << PORT_MSICFG_L2MSINUM_SHIFT) |
477 PORT_MSICFG_EN, port->base + PORT_MSICFG);
478 }
479
480 return 0;
481 }
482
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP'
@ 2023-07-28 0:51 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-07-28 0:51 UTC (permalink / raw)
To: Hector Martin; +Cc: oe-kbuild-all
Hi Hector,
FYI, the error/warning still remains.
tree: https://github.com/AsahiLinux/linux bits/140-pci
head: 924aefff015d104293101a46281fca901e2ccd3f
commit: f5cbf03cdd67d8c68765cde5f8de62feac0230de [10/15] PCIE: apple: Add T602x PCIe support
config: powerpc-randconfig-r013-20230727 (https://download.01.org/0day-ci/archive/20230728/202307280816.rY6C5dfe-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230728/202307280816.rY6C5dfe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307280816.rY6C5dfe-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/io.h:13,
from include/linux/iopoll.h:14,
from drivers/pci/controller/pcie-apple.c:23:
drivers/pci/controller/pcie-apple.c: In function 'apple_pcie_port_setup_irq':
>> drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
468 | writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
| ^~~~~~~~~~
arch/powerpc/include/asm/io.h:695:40: note: in definition of macro 'writel_relaxed'
695 | #define writel_relaxed(v, addr) writel(v, addr)
| ^
cc1: some warnings being treated as errors
vim +/FIELD_PREP +468 drivers/pci/controller/pcie-apple.c
430
431 static int apple_pcie_port_setup_irq(struct apple_pcie_port *port)
432 {
433 struct fwnode_handle *fwnode = &port->np->fwnode;
434 struct apple_pcie *pcie = port->pcie;
435 unsigned int irq;
436
437 /* FIXME: consider moving each interrupt under each port */
438 irq = irq_of_parse_and_map(to_of_node(dev_fwnode(port->pcie->dev)),
439 port->idx);
440 if (!irq)
441 return -ENXIO;
442
443 port->domain = irq_domain_create_linear(fwnode, 32,
444 &apple_port_irq_domain_ops,
445 port);
446 if (!port->domain)
447 return -ENOMEM;
448
449 /* Disable all interrupts */
450 writel_relaxed(~0, port->base + PORT_INTMSK);
451 writel_relaxed(~0, port->base + PORT_INTSTAT);
452 writel_relaxed(~0, port->base + PORT_LINKCMDSTS);
453
454 irq_set_chained_handler_and_data(irq, apple_port_irq_handler, port);
455
456 /* Configure MSI base address */
457 BUG_ON(upper_32_bits(DOORBELL_ADDR));
458 writel_relaxed(lower_32_bits(DOORBELL_ADDR),
459 port->base + pcie->hw->port_msiaddr);
460 if (pcie->hw->port_msiaddr_hi)
461 writel_relaxed(0, port->base + pcie->hw->port_msiaddr_hi);
462
463 /* Enable MSIs, shared between all ports */
464 if (pcie->hw->port_msimap) {
465 int i;
466
467 for (i = 0; i < pcie->nvecs; i++) {
> 468 writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
469 PORT_MSIMAP_ENABLE,
470 port->base + pcie->hw->port_msimap + 4 * i);
471 }
472
473 writel_relaxed(PORT_MSICFG_EN, port->base + PORT_MSICFG);
474 } else {
475 writel_relaxed(0, port->base + PORT_MSIBASE);
476 writel_relaxed((ilog2(pcie->nvecs) << PORT_MSICFG_L2MSINUM_SHIFT) |
477 PORT_MSICFG_EN, port->base + PORT_MSICFG);
478 }
479
480 return 0;
481 }
482
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-01 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-12 8:31 [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-10-01 10:26 kernel test robot
2023-07-28 0:51 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).