From: kernel test robot <lkp@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: drivers/opp/core.c:2809: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config'
Date: Sat, 9 Sep 2023 16:05:02 +0800 [thread overview]
Message-ID: <202309091558.x3JJrxFI-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6099776f9f268e61fe5ecd721f994a8cfce5306f
commit: 11b9b663585c4f8b00846089ebbca4d1e3283e86 OPP: Add dev_pm_opp_set_config() and friends
date: 1 year, 2 months ago
config: csky-defconfig (https://download.01.org/0day-ci/archive/20230909/202309091558.x3JJrxFI-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309091558.x3JJrxFI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309091558.x3JJrxFI-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/opp/core.c:2113: warning: Excess function parameter 'count' description in 'dev_pm_opp_set_regulators'
drivers/opp/core.c:2251: warning: Excess function parameter 'count' description in 'devm_pm_opp_set_regulators'
>> drivers/opp/core.c:2809: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config'
>> drivers/opp/core.c:2809: warning: Excess function parameter 'opp_table' description in 'dev_pm_opp_clear_config'
vim +2809 drivers/opp/core.c
2794
2795 /**
2796 * dev_pm_opp_clear_config() - Releases resources blocked for OPP configuration.
2797 * @opp_table: OPP table returned from dev_pm_opp_set_config().
2798 *
2799 * This allows all device OPP configurations to be cleared at once. This must be
2800 * called once for each call made to dev_pm_opp_set_config(), in order to free
2801 * the OPPs properly.
2802 *
2803 * Currently the first call itself ends up freeing all the OPP configurations,
2804 * while the later ones only drop the OPP table reference. This works well for
2805 * now as we would never want to use an half initialized OPP table and want to
2806 * remove the configurations together.
2807 */
2808 void dev_pm_opp_clear_config(int token)
> 2809 {
2810 struct opp_config_data *data;
2811
2812 /*
2813 * This lets the callers call this unconditionally and keep their code
2814 * simple.
2815 */
2816 if (unlikely(token <= 0))
2817 return;
2818
2819 data = xa_erase(&opp_configs, token);
2820 if (WARN_ON(!data))
2821 return;
2822
2823 _opp_clear_config(data);
2824 }
2825 EXPORT_SYMBOL_GPL(dev_pm_opp_clear_config);
2826
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-09-09 8:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309091558.x3JJrxFI-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).