oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kenechukwu maduechesi <maduechesik@gmail.com>,
	shreeya.patel23498@gmail.com, outreachy@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Add parenthesis to macro arguments
Date: Sun, 22 Oct 2023 14:13:36 +0800	[thread overview]
Message-ID: <202310221433.99xPzVri-lkp@intel.com> (raw)
In-Reply-To: <20231020065439.GA3579@ubuntu>

Hi kenechukwu,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-linus]
[also build test ERROR on linus/master v6.6-rc6]
[cannot apply to staging/staging-testing staging/staging-next next-20231020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/kenechukwu-maduechesi/staging-rts5208-Add-parenthesis-to-macro-arguments/20231020-145549
base:   staging/staging-linus
patch link:    https://lore.kernel.org/r/20231020065439.GA3579%40ubuntu
patch subject: [PATCH] staging: rts5208: Add parenthesis to macro arguments
config: arc-randconfig-001-20231022 (https://download.01.org/0day-ci/archive/20231022/202310221433.99xPzVri-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231022/202310221433.99xPzVri-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310221433.99xPzVri-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/staging/rts5208/rtsx_scsi.c:17:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx_scsi.c: In function 'read_host_reg':
>> drivers/staging/rts5208/rtsx_scsi.c:1350:15: error: implicit declaration of function 'rtsx_readl'; did you mean 'rtsx_dev'? [-Werror=implicit-function-declaration]
    1350 |         val = rtsx_readl(chip, addr);
         |               ^~~~~~~~~~
         |               rtsx_dev
   drivers/staging/rts5208/rtsx_scsi.c: In function 'write_host_reg':
>> drivers/staging/rts5208/rtsx_scsi.c:1388:9: error: implicit declaration of function 'rtsx_writel' [-Werror=implicit-function-declaration]
    1388 |         rtsx_writel(chip, addr, val);
         |         ^~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/rts5208/spi.c:16:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
--
   In file included from drivers/staging/rts5208/sd.c:16:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/sd.c: In function 'sd_check_wp_state':
>> drivers/staging/rts5208/sd.c:2278:15: error: implicit declaration of function 'rtsx_readl'; did you mean 'rtsx_dev'? [-Werror=implicit-function-declaration]
    2278 |         val = rtsx_readl(chip, RTSX_BIPR);
         |               ^~~~~~~~~~
         |               rtsx_dev
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/rts5208/rtsx_transport.c:16:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx_transport.c: In function 'rtsx_send_cmd_no_wait':
>> drivers/staging/rts5208/rtsx_transport.c:215:9: error: implicit declaration of function 'rtsx_writel'; did you mean 'vfs_write'? [-Werror=implicit-function-declaration]
     215 |         rtsx_writel(chip, RTSX_HCBAR, chip->host_cmds_addr);
         |         ^~~~~~~~~~~
         |         vfs_write
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/rts5208/rtsx_chip.c:18:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx_chip.c: In function 'rtsx_enable_card_int':
>> drivers/staging/rts5208/rtsx_chip.c:37:19: error: implicit declaration of function 'rtsx_readl'; did you mean 'rtsx_dev'? [-Werror=implicit-function-declaration]
      37 |         u32 reg = rtsx_readl(chip, RTSX_BIER);
         |                   ^~~~~~~~~~
         |                   rtsx_dev
>> drivers/staging/rts5208/rtsx_chip.c:51:9: error: implicit declaration of function 'rtsx_writel'; did you mean 'vfs_write'? [-Werror=implicit-function-declaration]
      51 |         rtsx_writel(chip, RTSX_BIER, reg);
         |         ^~~~~~~~~~~
         |         vfs_write
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/rts5208/rtsx_card.c:18:
>> drivers/staging/rts5208/rtsx.h:42:27: error: expected parameter name, found "("
      42 | #define rtsx_writel(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:44:26: error: expected parameter name, found "("
      44 | #define rtsx_readl(chip, (reg) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:46:27: error: expected parameter name, found "("
      46 | #define rtsx_writew(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:48:26: error: expected parameter name, found "("
      48 | #define rtsx_readw(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx.h:50:27: error: expected parameter name, found "("
      50 | #define rtsx_writeb(chip, (reg), value) \
         |                           ^
   drivers/staging/rts5208/rtsx.h:52:26: error: expected parameter name, found "("
      52 | #define rtsx_readb(chip, (reg)) \
         |                          ^
   drivers/staging/rts5208/rtsx_card.c: In function 'rtsx_release_cards':
>> drivers/staging/rts5208/rtsx_card.c:328:25: error: implicit declaration of function 'rtsx_readl'; did you mean 'rtsx_dev'? [-Werror=implicit-function-declaration]
     328 |         chip->int_reg = rtsx_readl(chip, RTSX_BIPR);
         |                         ^~~~~~~~~~
         |                         rtsx_dev
   cc1: some warnings being treated as errors


vim +42 drivers/staging/rts5208/rtsx.h

    38	
    39	/*
    40	 * macros for easy use
    41	 */
  > 42	#define rtsx_writel(chip, (reg), value) \
    43		iowrite32(value, (chip)->rtsx->remap_addr + reg)
    44	#define rtsx_readl(chip, (reg) \
    45		ioread32((chip)->rtsx->remap_addr + reg)
    46	#define rtsx_writew(chip, (reg), value) \
    47		iowrite16(value, (chip)->rtsx->remap_addr + reg)
    48	#define rtsx_readw(chip, (reg)) \
    49		ioread16((chip)->rtsx->remap_addr + reg)
    50	#define rtsx_writeb(chip, (reg), value) \
    51		iowrite8(value, (chip)->rtsx->remap_addr + reg)
    52	#define rtsx_readb(chip, (reg)) \
    53		ioread8((chip)->rtsx->remap_addr + reg)
    54	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

           reply	other threads:[~2023-10-22  6:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20231020065439.GA3579@ubuntu>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310221433.99xPzVri-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=maduechesik@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).