From: kernel test robot <lkp@intel.com>
To: Eberhard Stoll <estl@gmx.net>, Han Xu <han.xu@nxp.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
"Eberhard Stoll" <eberhard.stoll@kontron.de>,
"Frieder Schrempf" <frieder.schrempf@kontron.de>,
"Amit Kumar Mahapatra" <amit.kumar-mahapatra@amd.com>,
"Amit Kumar Mahapatra via Alsa-devel"
<alsa-devel@alsa-project.org>, "Michal Simek" <monstr@monstr.eu>,
"Rob Herring" <robh@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Yang Yingliang" <yangyingliang@huawei.com>
Subject: Re: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment
Date: Fri, 27 Oct 2023 04:03:04 +0800 [thread overview]
Message-ID: <202310270332.mcbckKCr-lkp@intel.com> (raw)
In-Reply-To: <20231026152316.2729575-5-estl@gmx.net>
Hi Eberhard,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1]
url: https://github.com/intel-lab-lkp/linux/commits/Eberhard-Stoll/spi-Add-parameter-for-clock-to-rx-delay/20231026-232547
base: 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
patch link: https://lore.kernel.org/r/20231026152316.2729575-5-estl%40gmx.net
patch subject: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231027/202310270332.mcbckKCr-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270332.mcbckKCr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310270332.mcbckKCr-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/spi/spi-fsl-qspi.c: In function 'fsl_qspi_select_mem':
>> drivers/spi/spi-fsl-qspi.c:558:38: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
558 | if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns |
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +558 drivers/spi/spi-fsl-qspi.c
550
551 static void fsl_qspi_select_mem(struct fsl_qspi *q, struct spi_device *spi)
552 {
553 unsigned long rate = spi->max_speed_hz;
554 int ret;
555 struct fsl_qspi_chip_data *chip = spi_get_ctldata(spi);
556 const char *sampling_ident = sampling_mode[0];
557
> 558 if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns |
559 chip->rate != rate) {
560 chip->rx_sample_delay_ns = spi->rx_sample_delay_ns;
561 chip->rate = rate;
562
563 chip->smpr_sampling =
564 (2 * spi->rx_sample_delay_ns * (rate >> 10)) / (1000000000 >> 10);
565 dev_dbg(q->dev, "smpr_sampling = %u (delay %u ns)\n",
566 chip->smpr_sampling, spi->rx_sample_delay_ns);
567
568 if (chip->smpr_sampling > 3) {
569 dev_err(q->dev, "rx sample delay for device %s exceeds hw capabilities! Clamp value to maximum setting.\n",
570 dev_name(&spi->dev));
571 chip->smpr_sampling = 3;
572 sampling_ident = "(I2 clamped to max)";
573 } else {
574 sampling_ident = sampling_mode[chip->smpr_sampling];
575 }
576
577 chip->smpr_sampling <<= 5;
578 dev_info(q->dev, "sampling point %s at %lu kHz used for device %s\n",
579 sampling_ident, rate / 1000, dev_name(&spi->dev));
580 fsl_qspi_update_smpr_sampling(q, chip->smpr_sampling);
581 }
582
583 if (q->selected == spi_get_chipselect(spi, 0))
584 return;
585
586 fsl_qspi_update_smpr_sampling(q, chip->smpr_sampling);
587
588 if (needs_4x_clock(q))
589 rate *= 4;
590
591 fsl_qspi_clk_disable_unprep(q);
592
593 ret = clk_set_rate(q->clk, rate);
594 if (ret)
595 return;
596
597 ret = fsl_qspi_clk_prep_enable(q);
598 if (ret)
599 return;
600
601 q->selected = spi_get_chipselect(spi, 0);
602
603 fsl_qspi_invalidate(q);
604 }
605
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2023-10-26 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231026152316.2729575-5-estl@gmx.net>
2023-10-26 20:03 ` kernel test robot [this message]
2023-10-27 6:51 ` [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment Frieder Schrempf
2023-10-27 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310270332.mcbckKCr-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amit.kumar-mahapatra@amd.com \
--cc=broonie@kernel.org \
--cc=eberhard.stoll@kontron.de \
--cc=estl@gmx.net \
--cc=frieder.schrempf@kontron.de \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).