From: kernel test robot <lkp@intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>
Subject: drivers/clocksource/timer-ti-dm.c:82: warning: Excess function parameter 'value' description in 'dmtimer_write'
Date: Sat, 4 Nov 2023 04:35:28 +0800 [thread overview]
Message-ID: <202311040403.DzIiBuwU-lkp@intel.com> (raw)
Hi Tony,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8f6f76a6a29f36d2f3e4510d0bde5046672f6924
commit: 49cd16bb573e43dc2ee64d734b9b545475dbb35f clocksource/drivers/timer-ti-dm: Simplify register writes with dmtimer_write()
date: 1 year, 1 month ago
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20231104/202311040403.DzIiBuwU-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040403.DzIiBuwU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040403.DzIiBuwU-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/clocksource/timer-ti-dm.c:82: warning: Function parameter or member 'val' not described in 'dmtimer_write'
>> drivers/clocksource/timer-ti-dm.c:82: warning: Excess function parameter 'value' description in 'dmtimer_write'
vim +82 drivers/clocksource/timer-ti-dm.c
41e79b1d4584772 Tony Lindgren 2022-04-08 70
49cd16bb573e43d Tony Lindgren 2022-08-15 71 /**
49cd16bb573e43d Tony Lindgren 2022-08-15 72 * dmtimer_write - write timer registers in posted and non-posted mode
49cd16bb573e43d Tony Lindgren 2022-08-15 73 * @timer: timer pointer over which write operation is to perform
49cd16bb573e43d Tony Lindgren 2022-08-15 74 * @reg: lowest byte holds the register offset
49cd16bb573e43d Tony Lindgren 2022-08-15 75 * @value: data to write into the register
49cd16bb573e43d Tony Lindgren 2022-08-15 76 *
49cd16bb573e43d Tony Lindgren 2022-08-15 77 * The posted mode bit is encoded in reg. Note that in posted mode, the write
49cd16bb573e43d Tony Lindgren 2022-08-15 78 * pending bit must be checked. Otherwise a write on a register which has a
49cd16bb573e43d Tony Lindgren 2022-08-15 79 * pending write will be lost.
49cd16bb573e43d Tony Lindgren 2022-08-15 80 */
49cd16bb573e43d Tony Lindgren 2022-08-15 81 static inline void dmtimer_write(struct omap_dm_timer *timer, u32 reg, u32 val)
41e79b1d4584772 Tony Lindgren 2022-04-08 @82 {
49cd16bb573e43d Tony Lindgren 2022-08-15 83 u16 wp, offset;
49cd16bb573e43d Tony Lindgren 2022-08-15 84
49cd16bb573e43d Tony Lindgren 2022-08-15 85 wp = reg >> WPSHIFT;
49cd16bb573e43d Tony Lindgren 2022-08-15 86 offset = reg & 0xff;
49cd16bb573e43d Tony Lindgren 2022-08-15 87
49cd16bb573e43d Tony Lindgren 2022-08-15 88 /* Wait for a possible write pending bit in posted mode */
49cd16bb573e43d Tony Lindgren 2022-08-15 89 if (wp && timer->posted)
49cd16bb573e43d Tony Lindgren 2022-08-15 90 while (readl_relaxed(timer->pend) & wp)
41e79b1d4584772 Tony Lindgren 2022-04-08 91 cpu_relax();
41e79b1d4584772 Tony Lindgren 2022-04-08 92
49cd16bb573e43d Tony Lindgren 2022-08-15 93 writel_relaxed(val, timer->func_base + offset);
41e79b1d4584772 Tony Lindgren 2022-04-08 94 }
41e79b1d4584772 Tony Lindgren 2022-04-08 95
:::::: The code at line 82 was first introduced by commit
:::::: 41e79b1d458477212d0a880c87622bcaa69ab3ea clocksource/drivers/timer-ti-dm: Move inline functions to driver for am6
:::::: TO: Tony Lindgren <tony@atomide.com>
:::::: CC: Daniel Lezcano <daniel.lezcano@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-11-03 20:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311040403.DzIiBuwU-lkp@intel.com \
--to=lkp@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).