Re: [PATCH v5 3/3] media: i2c: gc2145: Galaxy Core GC2145 sensor support

[kernel test robot <lkp@intel.com>]

Hi Alain,

kernel test robot noticed the following build errors:

[auto build test ERROR on linuxtv-media-stage/master]
[also build test ERROR on linus/master v6.7-rc2 next-20231122]
[cannot apply to media-tree/master robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alain-Volmat/dt-bindings-vendor-prefixes-Add-prefix-for-GalaxyCore-Inc/20231122-155443
base:   https://git.linuxtv.org/media_stage.git master
patch link:    https://lore.kernel.org/r/20231122075154.789431-4-alain.volmat%40foss.st.com
patch subject: [PATCH v5 3/3] media: i2c: gc2145: Galaxy Core GC2145 sensor support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231123/202311230621.ATIDPgtm-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231123/202311230621.ATIDPgtm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311230621.ATIDPgtm-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/i2c/gc2145.c: In function 'gc2145_init_cfg':
>> drivers/media/i2c/gc2145.c:664:18: error: implicit declaration of function 'v4l2_subdev_state_get_format'; did you mean 'v4l2_subdev_state_get_stream_format'? [-Werror=implicit-function-declaration]
     664 |         format = v4l2_subdev_state_get_format(state, 0);
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                  v4l2_subdev_state_get_stream_format
   drivers/media/i2c/gc2145.c:664:16: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     664 |         format = v4l2_subdev_state_get_format(state, 0);
         |                ^
>> drivers/media/i2c/gc2145.c:669:16: error: implicit declaration of function 'v4l2_subdev_state_get_crop'; did you mean 'v4l2_subdev_state_get_stream_crop'? [-Werror=implicit-function-declaration]
     669 |         crop = v4l2_subdev_state_get_crop(state, 0);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |                v4l2_subdev_state_get_stream_crop
   drivers/media/i2c/gc2145.c:669:14: warning: assignment to 'struct v4l2_rect *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     669 |         crop = v4l2_subdev_state_get_crop(state, 0);
         |              ^
   drivers/media/i2c/gc2145.c: In function 'gc2145_get_selection':
   drivers/media/i2c/gc2145.c:681:26: error: invalid type argument of unary '*' (have 'int')
     681 |                 sel->r = *v4l2_subdev_state_get_crop(sd_state, 0);
         |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/gc2145.c: In function 'gc2145_set_pad_format':
   drivers/media/i2c/gc2145.c:758:18: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     758 |         framefmt = v4l2_subdev_state_get_format(sd_state, fmt->pad);
         |                  ^
   drivers/media/i2c/gc2145.c:770:14: warning: assignment to 'struct v4l2_rect *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     770 |         crop = v4l2_subdev_state_get_crop(sd_state, fmt->pad);
         |              ^
   drivers/media/i2c/gc2145.c: In function 'gc2145_start_streaming':
   drivers/media/i2c/gc2145.c:874:13: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     874 |         fmt = v4l2_subdev_state_get_format(state, 0);
         |             ^
   cc1: some warnings being treated as errors


vim +664 drivers/media/i2c/gc2145.c

   655	
   656	static int gc2145_init_cfg(struct v4l2_subdev *sd,
   657				   struct v4l2_subdev_state *state)
   658	{
   659		struct gc2145 *gc2145 = to_gc2145(sd);
   660		struct v4l2_mbus_framefmt *format;
   661		struct v4l2_rect *crop;
   662	
   663		/* Initialize pad format */
 > 664		format = v4l2_subdev_state_get_format(state, 0);
   665		gc2145_update_pad_format(gc2145, &supported_modes[0], format,
   666					 MEDIA_BUS_FMT_RGB565_1X16);
   667	
   668		/* Initialize crop rectangle. */
 > 669		crop = v4l2_subdev_state_get_crop(state, 0);
   670		*crop = supported_modes[0].crop;
   671	
   672		return 0;
   673	}
   674	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki