Re: [PATCH 5/5] crypto: starfive: Add sm4 support for JH8100

From: kernel test robot <lkp@intel.com>
To: Jia Jie Ho <jiajie.ho@starfivetech.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 5/5] crypto: starfive: Add sm4 support for JH8100
Date: Sun, 17 Dec 2023 08:23:56 +0800	[thread overview]
Message-ID: <202312170811.OzUPuAUd-lkp@intel.com> (raw)
In-Reply-To: <20231216141234.417498-6-jiajie.ho@starfivetech.com>

Hi Jia,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on next-20231215]
[cannot apply to robh/for-next linus/master v6.7-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jia-Jie-Ho/dt-bindings-crypto-starfive-Add-jh8100-compatible-string/20231216-221614
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20231216141234.417498-6-jiajie.ho%40starfivetech.com
patch subject: [PATCH 5/5] crypto: starfive: Add sm4 support for JH8100
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20231217/202312170811.OzUPuAUd-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312170811.OzUPuAUd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312170811.OzUPuAUd-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/crypto/starfive/jh8100-sm4.c:1088:5: warning: no previous prototype for function 'starfive_sm4_register_algs' [-Wmissing-prototypes]
    1088 | int starfive_sm4_register_algs(void)
         |     ^
   drivers/crypto/starfive/jh8100-sm4.c:1088:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    1088 | int starfive_sm4_register_algs(void)
         | ^
         | static 
>> drivers/crypto/starfive/jh8100-sm4.c:1103:6: warning: no previous prototype for function 'starfive_sm4_unregister_algs' [-Wmissing-prototypes]
    1103 | void starfive_sm4_unregister_algs(void)
         |      ^
   drivers/crypto/starfive/jh8100-sm4.c:1103:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    1103 | void starfive_sm4_unregister_algs(void)
         | ^
         | static 
   2 warnings generated.

vim +/starfive_sm4_register_algs +1088 drivers/crypto/starfive/jh8100-sm4.c

  1087	
> 1088	int starfive_sm4_register_algs(void)
  1089	{
  1090		int ret;
  1091	
  1092		ret = crypto_engine_register_skciphers(skcipher_sm4, ARRAY_SIZE(skcipher_sm4));
  1093		if (ret)
  1094			return ret;
  1095	
  1096		ret = crypto_engine_register_aeads(aead_sm4, ARRAY_SIZE(aead_sm4));
  1097		if (ret)
  1098			crypto_engine_unregister_skciphers(skcipher_sm4, ARRAY_SIZE(skcipher_sm4));
  1099	
  1100		return ret;
  1101	}
  1102	
> 1103	void starfive_sm4_unregister_algs(void)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki