From: kernel test robot <lkp@intel.com>
To: Markus Elfring <Markus.Elfring@web.de>,
virtualization@lists.linux.dev, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Gonglei <arei.gonglei@huawei.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
cocci@inria.fr
Subject: Re: [PATCH] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection
Date: Tue, 26 Dec 2023 08:54:01 +0800 [thread overview]
Message-ID: <202312260852.0ge5O8IL-lkp@intel.com> (raw)
In-Reply-To: <2413f22f-f0c3-45e0-9f6b-a551bdf0f54c@web.de>
Hi Markus,
kernel test robot noticed the following build errors:
[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/crypto-virtio-Less-function-calls-in-__virtio_crypto_akcipher_do_req-after-error-detection/20231225-154431
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/2413f22f-f0c3-45e0-9f6b-a551bdf0f54c%40web.de
patch subject: [PATCH] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection
config: arm-randconfig-001-20231225 (https://download.01.org/0day-ci/archive/20231226/202312260852.0ge5O8IL-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231226/202312260852.0ge5O8IL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312260852.0ge5O8IL-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:281:1: error: use of undeclared identifier 'free_src'; did you mean 'free_irq'?
free_src;
^~~~~~~~
free_irq
include/linux/interrupt.h:196:20: note: 'free_irq' declared here
extern const void *free_irq(unsigned int, void *);
^
>> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:257:9: error: use of undeclared label 'free_src'
goto free_src;
^
>> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:281:1: warning: expression result unused [-Wunused-value]
free_src;
^~~~~~~~
1 warning and 2 errors generated.
vim +281 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
218
219 static int __virtio_crypto_akcipher_do_req(struct virtio_crypto_akcipher_request *vc_akcipher_req,
220 struct akcipher_request *req, struct data_queue *data_vq)
221 {
222 struct virtio_crypto_akcipher_ctx *ctx = vc_akcipher_req->akcipher_ctx;
223 struct virtio_crypto_request *vc_req = &vc_akcipher_req->base;
224 struct virtio_crypto *vcrypto = ctx->vcrypto;
225 struct virtio_crypto_op_data_req *req_data = vc_req->req_data;
226 struct scatterlist *sgs[4], outhdr_sg, inhdr_sg, srcdata_sg, dstdata_sg;
227 void *src_buf, *dst_buf = NULL;
228 unsigned int num_out = 0, num_in = 0;
229 int node = dev_to_node(&vcrypto->vdev->dev);
230 unsigned long flags;
231 int ret;
232 bool verify = vc_akcipher_req->opcode == VIRTIO_CRYPTO_AKCIPHER_VERIFY;
233 unsigned int src_len = verify ? req->src_len + req->dst_len : req->src_len;
234
235 /* out header */
236 sg_init_one(&outhdr_sg, req_data, sizeof(*req_data));
237 sgs[num_out++] = &outhdr_sg;
238
239 /* src data */
240 src_buf = kcalloc_node(src_len, 1, GFP_KERNEL, node);
241 if (!src_buf)
242 return -ENOMEM;
243
244 if (verify) {
245 /* for verify operation, both src and dst data work as OUT direction */
246 sg_copy_to_buffer(req->src, sg_nents(req->src), src_buf, src_len);
247 sg_init_one(&srcdata_sg, src_buf, src_len);
248 sgs[num_out++] = &srcdata_sg;
249 } else {
250 sg_copy_to_buffer(req->src, sg_nents(req->src), src_buf, src_len);
251 sg_init_one(&srcdata_sg, src_buf, src_len);
252 sgs[num_out++] = &srcdata_sg;
253
254 /* dst data */
255 dst_buf = kcalloc_node(req->dst_len, 1, GFP_KERNEL, node);
256 if (!dst_buf)
> 257 goto free_src;
258
259 sg_init_one(&dstdata_sg, dst_buf, req->dst_len);
260 sgs[num_out + num_in++] = &dstdata_sg;
261 }
262
263 vc_akcipher_req->src_buf = src_buf;
264 vc_akcipher_req->dst_buf = dst_buf;
265
266 /* in header */
267 sg_init_one(&inhdr_sg, &vc_req->status, sizeof(vc_req->status));
268 sgs[num_out + num_in++] = &inhdr_sg;
269
270 spin_lock_irqsave(&data_vq->lock, flags);
271 ret = virtqueue_add_sgs(data_vq->vq, sgs, num_out, num_in, vc_req, GFP_ATOMIC);
272 virtqueue_kick(data_vq->vq);
273 spin_unlock_irqrestore(&data_vq->lock, flags);
274 if (ret)
275 goto err;
276
277 return 0;
278
279 err:
280 kfree(dst_buf);
> 281 free_src;
282 kfree(src_buf);
283 return -ENOMEM;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2023-12-26 0:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2413f22f-f0c3-45e0-9f6b-a551bdf0f54c@web.de>
2023-12-26 0:54 ` kernel test robot [this message]
2023-12-26 10:12 ` [PATCH v2] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection Markus Elfring
2023-12-26 12:22 ` Gonglei (Arei)
2024-01-09 23:42 ` Justin Stitt
2024-01-10 7:46 ` Markus Elfring
2024-01-26 8:55 ` [PATCH v2] " Herbert Xu
2023-12-26 2:57 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312260852.0ge5O8IL-lkp@intel.com \
--to=lkp@intel.com \
--cc=Markus.Elfring@web.de \
--cc=arei.gonglei@huawei.com \
--cc=cocci@inria.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).